Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23896

PATCH: CommandInterpreter.join(...) doesn't have access to the Build object

      core/src/main/java/hudson/tasks/CommandInterpreter.java defines a join(Proc p) method that's supposed to be able to set the result to Result.UNSTABLE.

      However, it has no access to the build object to call setResult(...)

      It's an extension point, so while it's not used in-tree it isn't clear if there might be out-of-tree code using it. As such just replacing it with a version that takes more parameters may not be wise.

      I think it's necessary to add a member variable to track the build and a protected accessor; that way the same call interface can be retained. Patch pending.

          [JENKINS-23896] PATCH: CommandInterpreter.join(...) doesn't have access to the Build object

          Craig Ringer created issue -
          Craig Ringer made changes -
          Link New: This issue is related to JENKINS-23786 [ JENKINS-23786 ]
          Craig Ringer made changes -
          Labels New: build core patch unstable
          Summary Original: CommandInterpreter.join(...) doesn't have access to the Build object New: PATCH: CommandInterpreter.join(...) doesn't have access to the Build object
          Craig Ringer made changes -
          Labels Original: build core patch unstable New: build core patch pull_request unstable
          Craig Ringer made changes -
          Link Original: This issue is related to JENKINS-23786 [ JENKINS-23786 ]
          Craig Ringer made changes -
          Link New: This issue is blocking JENKINS-23786 [ JENKINS-23786 ]
          Craig Ringer made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Craig Ringer made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 156761 ] New: JNJira + In-Review [ 179381 ]

            Unassigned Unassigned
            ringerc Craig Ringer
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: