Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23963

Computer's sidepanel.jelly should use ${rootURL}/${it.url} instead of relative URLs

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • None

    Description

      Since the fix for JENKINS-21357, the monitoring plugin displays the computer's actions on the left with Computer's sidepanel.jelly.
      But most links for the Computer's actions are broken, because Computer's sidepanel.jelly uses relative URLs instead of ${rootURL}/${it.url}, as was said here.

      Attachments

        Issue Links

          links to

          Web Link PR 1378

          Activity

            Ascending order - Click to sort in descending order
            evernat evernat created issue -
            danielbeck Daniel Beck made changes -
            Field Original Value New Value
            Assignee Daniel Beck [ danielbeck ]
            danielbeck Daniel Beck added a comment -

            Not sure when I have the time, so anyone feel free to take over.

            danielbeck Daniel Beck added a comment - Not sure when I have the time, so anyone feel free to take over.
            danielbeck Daniel Beck made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            danielbeck Daniel Beck made changes -
            Remote Link This issue links to "PR 1378 (Web Link)" [ 11305 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/resources/hudson/model/Computer/sidepanel.jelly
            core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
            http://jenkins-ci.org/commit/jenkins/c45d6be237de4b588c59395b6bcd9a8dc63a7383
            Log:
            [FIXED JENKINS-23963] Use absolute sidepanel links for computers

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/model/Computer/sidepanel.jelly core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly http://jenkins-ci.org/commit/jenkins/c45d6be237de4b588c59395b6bcd9a8dc63a7383 Log: [FIXED JENKINS-23963] Use absolute sidepanel links for computers
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/resources/hudson/model/Computer/sidepanel.jelly
            core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
            http://jenkins-ci.org/commit/jenkins/e2d9fdc9894bed799893f85f2e884c3567805730
            Log:
            Merge pull request #1378 from daniel-beck/JENKINS-23963

            [FIXED JENKINS-23963] Use absolute sidepanel links for computers

            Compare: https://github.com/jenkinsci/jenkins/compare/1b9cc8aa1f5e...e2d9fdc9894b

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/model/Computer/sidepanel.jelly core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly http://jenkins-ci.org/commit/jenkins/e2d9fdc9894bed799893f85f2e884c3567805730 Log: Merge pull request #1378 from daniel-beck/ JENKINS-23963 [FIXED JENKINS-23963] Use absolute sidepanel links for computers Compare: https://github.com/jenkinsci/jenkins/compare/1b9cc8aa1f5e...e2d9fdc9894b
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3644
            [FIXED JENKINS-23963] Use absolute sidepanel links for computers (Revision c45d6be237de4b588c59395b6bcd9a8dc63a7383)

            Result = SUCCESS
            daniel-beck : c45d6be237de4b588c59395b6bcd9a8dc63a7383
            Files :

            • core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
            • core/src/main/resources/hudson/model/Computer/sidepanel.jelly
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3644 [FIXED JENKINS-23963] Use absolute sidepanel links for computers (Revision c45d6be237de4b588c59395b6bcd9a8dc63a7383) Result = SUCCESS daniel-beck : c45d6be237de4b588c59395b6bcd9a8dc63a7383 Files : core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly core/src/main/resources/hudson/model/Computer/sidepanel.jelly
            evernat evernat added a comment -

            thanks

            evernat evernat added a comment - thanks
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 156833 ] JNJira + In-Review [ 195516 ]

            People

              danielbeck Daniel Beck
              evernat evernat
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: