Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23986

Permissions check in ExtendedEmailPublisher.getProjectActions does not work

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Major Major
    • email-ext-plugin
    • Email-ext 2.37.2.2 on Jenkins 1.554.3

      The permissions check is run in a system context (or not re-run for every page view), so it's ineffective.

      The permission needs to be checked:

      • in the action itself (e.g. the index.jelly) to fail when configure permission is missing (for those clever users navigating to known URLs directly)
      • as well as the action.jelly that needs to be added for this

          [JENKINS-23986] Permissions check in ExtendedEmailPublisher.getProjectActions does not work

          Daniel Beck created issue -
          Daniel Beck made changes -
          Description Original: The permissions check is run in a system context (or not re-run for every page view), so it's ineffective.

          The permission needs to be checked:

          * in the action itself (e.g. the index.jelly) to fail when configure permission is missing
          * as well as the action.jelly that needs to be added for this           		New: The permissions check is run in a system context (or not re-run for every page view), so it's ineffective.

          The permission needs to be checked:

          * in the action itself (e.g. the index.jelly) to fail when configure permission is missing (for those clever users navigating to known URLs directly)
          * as well as the action.jelly that needs to be added for this

          Alex Earl added a comment -

          Yeah, I already have a fix for this. I noticed it the other day.

          Alex Earl added a comment - Yeah, I already have a fix for this. I noticed it the other day.
          Daniel Beck made changes -
          Assignee Original: Alex Earl [ slide_o_mix ] New: Daniel Beck [ danielbeck ]

          Daniel Beck added a comment -

          Oh, alright. Could have provided that as well

          Daniel Beck added a comment - Oh, alright. Could have provided that as well
          Daniel Beck made changes -
          Assignee Original: Daniel Beck [ danielbeck ] New: Alex Earl [ slide_o_mix ]
          Alex Earl made changes -
          Link New: This issue duplicates JENKINS-23834 [ JENKINS-23834 ]
          Alex Earl made changes -
          Resolution New: Duplicate [ 3 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 156856 ] New: JNJira + In-Review [ 207900 ]

            slide_o_mix Alex Earl
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: