Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24006

Customize number of Junit test failures that affect weather

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • junit-plugin
    • None

      Currently if 20% or more of tests fail, the weather for a project will be downgraded (cloudy).

      Some users have a large number of tests and one test failure is a major issue.

      The request is to allow customization of the % of Junit test failures that will cause a weather downgrade. Users that specify 100% pass require all tests to pass to maintain sunny weather.

          [JENKINS-24006] Customize number of Junit test failures that affect weather

          Mark Sinclair created issue -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/02b46fc5ddb32548019591c63d5700f8d3228b8e
          Log:
          Noting JENKINS-23872, JENKINS-24006, 19d8b80

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: changelog.html http://jenkins-ci.org/commit/jenkins/02b46fc5ddb32548019591c63d5700f8d3228b8e Log: Noting JENKINS-23872 , JENKINS-24006 , 19d8b80

          Daniel Beck added a comment -

          Daniel Beck added a comment - Fixed in https://github.com/jenkinsci/jenkins/commit/17fdfab3cd43b03732f322162fac16df87c604f1 by Stephen Connolly. Scheduled for 1.576.
          Daniel Beck made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Mark Sinclair added a comment -

          Thanks for implementing this.

          I tried it out and have an issue. After saving a job with a new amplification factor, going back to the config screen always loads the default 1.0 amplification factor, rather than the saved value.

          It may be due to the code below:

          core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java:163

          public double getHealthScaleFactor() {
          return 1.0;

          Mark Sinclair added a comment - Thanks for implementing this. I tried it out and have an issue. After saving a job with a new amplification factor, going back to the config screen always loads the default 1.0 amplification factor, rather than the saved value. It may be due to the code below: core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java:163 public double getHealthScaleFactor() { return 1.0;
          Mark Sinclair made changes -
          Assignee New: Daniel Beck [ danielbeck ]
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

          Daniel Beck added a comment -

          Why did you assign this to me? I even wrote that Stephen implemented this...

          Daniel Beck added a comment - Why did you assign this to me? I even wrote that Stephen implemented this...
          Daniel Beck made changes -
          Assignee Original: Daniel Beck [ danielbeck ]

          Mark Sinclair added a comment -

          My mistake - will reassign

          Mark Sinclair added a comment - My mistake - will reassign

          Scott Busche added a comment -

          I've created a PR that fixes the issue Mark is seeing - https://github.com/jenkinsci/junit-plugin/pull/4

          Scott Busche added a comment - I've created a PR that fixes the issue Mark is seeing - https://github.com/jenkinsci/junit-plugin/pull/4

            jglick Jesse Glick
            msinclair Mark Sinclair
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: