[JENKINS-24071] Docker build step tries to build on master and not slave - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: docker-build-step-plugin
Labels:
- docker
- docker-build-step
- master
- slave
Environment:
Jenkins master is set to 0 executors and 'leave this node for tied jobs only'

Similar Issues:

Show

Description

When running a Docker build step create image command on a slave it tries to run it on the master

21:15:04 Building remotely on pollux (twins) in workspace /var/lib/jenkins/workspace/oracle-java7/jenkins-slave-docker
...
21:15:11 FATAL: configured dockerFolder '/var/lib/jenkins/workspace/oracle-java7/jenkins-slave-docker/' does no exist.
21:15:11 java.lang.IllegalArgumentException: configured dockerFolder '/var/lib/jenkins/workspace/oracle-java7/jenkins-slave-docker/' does no exist.
21:15:11 	at org.jenkinsci.plugins.dockerbuildstep.cmd.CreateImageCommand.execute(CreateImageCommand.java:85)
21:15:11 	at org.jenkinsci.plugins.dockerbuildstep.DockerBuilder.perform(DockerBuilder.java:65)

Manually creating the workspace on master, and it goes one step further

22:52:40 FATAL: configured dockerFolder '/var/lib/jenkins/workspace/oracle-java7/jenkins-slave-docker' does not contain a Dockerfile.
22:52:40 java.lang.IllegalArgumentException: configured dockerFolder '/var/lib/jenkins/workspace/oracle-java7/jenkins-slave-docker' does not contain a Dockerfile.
22:52:40 	at org.jenkinsci.plugins.dockerbuildstep.cmd.CreateImageCommand.execute(CreateImageCommand.java:91)
22:52:40 	at org.jenkinsci.plugins.dockerbuildstep.DockerBuilder.perform(DockerBuilder.java:65)

And creating an empty Dockerfile goes one more step but it keeps trying to build on master and not slave

22:55:56 FATAL: com.kpelykh.docker.client.DockerException: Dockerfile /var/lib/jenkins/workspace/oracle-java7/jenkins-slave-docker/Dockerfile is empty
22:55:56 java.lang.RuntimeException: com.kpelykh.docker.client.DockerException: Dockerfile /var/lib/jenkins/workspace/oracle-java7/jenkins-slave-docker/Dockerfile is empty
22:55:56 	at org.jenkinsci.plugins.dockerbuildstep.cmd.CreateImageCommand.execute(CreateImageCommand.java:142)
22:55:56 	at org.jenkinsci.plugins.dockerbuildstep.DockerBuilder.perform(DockerBuilder.java:65)

Attachments

Issue Links

is related to

JENKINS-24465 docker-build-step 1.9 non-functional in Free-style build job

Resolved

Activity

Ascending order - Click to sort in descending order

SCM/JIRA link daemon added a comment - 2014-08-20 19:22

Code changed in jenkins
User: Vojtech Juranek
Path:
src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerBuilder.java
http://jenkins-ci.org/commit/docker-build-step-plugin/9f6f42df0a667c6b7bc28793b04955991dd29864
Log:
[FIXED JENKINS-24071] Execute command remotely on slaves, not on master (+formating)

Compare: https://github.com/jenkinsci/docker-build-step-plugin/compare/39bd5e919d57...9f6f42df0a66

SCM/JIRA link daemon added a comment - 2014-08-20 19:22 Code changed in jenkins User: Vojtech Juranek Path: src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerBuilder.java http://jenkins-ci.org/commit/docker-build-step-plugin/9f6f42df0a667c6b7bc28793b04955991dd29864 Log: [FIXED JENKINS-24071] Execute command remotely on slaves, not on master (+formating) Compare: https://github.com/jenkinsci/docker-build-step-plugin/compare/39bd5e919d57...9f6f42df0a66

Hack Kampbjørn added a comment - 2014-08-22 19:10

After updating to version 1.9 it now fails with a java.io.NotSerializableException

16:02:43 FATAL: Unable to serialize org.jenkinsci.plugins.dockerbuildstep.DockerBuilder$DockerCmdCallable@3235025a
16:02:43 java.io.IOException: Unable to serialize org.jenkinsci.plugins.dockerbuildstep.DockerBuilder$DockerCmdCallable@3235025a
16:02:43 	at hudson.remoting.UserRequest.serialize(UserRequest.java:166)
16:02:43 	at hudson.remoting.UserRequest.<init>(UserRequest.java:62)
16:02:43 	at hudson.remoting.Channel.call(Channel.java:738)
16:02:43 	at org.jenkinsci.plugins.dockerbuildstep.DockerBuilder.perform(DockerBuilder.java:67)
16:02:43 	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
16:02:43 	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:772)
16:02:43 	at hudson.model.Build$BuildExecution.build(Build.java:199)
16:02:43 	at hudson.model.Build$BuildExecution.doRun(Build.java:160)
16:02:43 	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:535)
16:02:43 	at hudson.model.Run.execute(Run.java:1732)
16:02:43 	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
16:02:43 	at hudson.model.ResourceController.execute(ResourceController.java:88)
16:02:43 	at hudson.model.Executor.run(Executor.java:234)
16:02:43 Caused by: java.io.NotSerializableException: hudson.model.FreeStyleBuild
16:02:43 	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164)
16:02:43 	at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1518)
16:02:43 	at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1483)
16:02:43 	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1400)
16:02:43 	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1158)
16:02:43 	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330)
16:02:43 	at hudson.remoting.UserRequest._serialize(UserRequest.java:155)
16:02:43 	at hudson.remoting.UserRequest.serialize(UserRequest.java:164)
16:02:43 	... 12 more

Hack Kampbjørn added a comment - 2014-08-22 19:10 After updating to version 1.9 it now fails with a java.io.NotSerializableException 16:02:43 FATAL: Unable to serialize org.jenkinsci.plugins.dockerbuildstep.DockerBuilder$DockerCmdCallable@3235025a 16:02:43 java.io.IOException: Unable to serialize org.jenkinsci.plugins.dockerbuildstep.DockerBuilder$DockerCmdCallable@3235025a 16:02:43 at hudson.remoting.UserRequest.serialize(UserRequest.java:166) 16:02:43 at hudson.remoting.UserRequest.<init>(UserRequest.java:62) 16:02:43 at hudson.remoting.Channel.call(Channel.java:738) 16:02:43 at org.jenkinsci.plugins.dockerbuildstep.DockerBuilder.perform(DockerBuilder.java:67) 16:02:43 at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20) 16:02:43 at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:772) 16:02:43 at hudson.model.Build$BuildExecution.build(Build.java:199) 16:02:43 at hudson.model.Build$BuildExecution.doRun(Build.java:160) 16:02:43 at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:535) 16:02:43 at hudson.model.Run.execute(Run.java:1732) 16:02:43 at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) 16:02:43 at hudson.model.ResourceController.execute(ResourceController.java:88) 16:02:43 at hudson.model.Executor.run(Executor.java:234) 16:02:43 Caused by: java.io.NotSerializableException: hudson.model.FreeStyleBuild 16:02:43 at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164) 16:02:43 at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1518) 16:02:43 at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1483) 16:02:43 at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1400) 16:02:43 at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1158) 16:02:43 at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330) 16:02:43 at hudson.remoting.UserRequest._serialize(UserRequest.java:155) 16:02:43 at hudson.remoting.UserRequest.serialize(UserRequest.java:164) 16:02:43 ... 12 more

SCM/JIRA link daemon added a comment - 2014-09-11 19:41

Code changed in jenkins
User: Vojtech Juranek
Path:
src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerBuilder.java
http://jenkins-ci.org/commit/docker-build-step-plugin/471393e7c36faf40d34a1a8744fe66222769fcee
Log:
Revert "[FIXED JENKINS-24071] Execute command remotely on slaves, not on master (+formating)"

This reverts commit 9f6f42df0a667c6b7bc28793b04955991dd29864.
Actually didn't fix the issue (see ~~JENKINS-24071~~) and potentially makes it even worse.

SCM/JIRA link daemon added a comment - 2014-09-11 19:41 Code changed in jenkins User: Vojtech Juranek Path: src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerBuilder.java http://jenkins-ci.org/commit/docker-build-step-plugin/471393e7c36faf40d34a1a8744fe66222769fcee Log: Revert " [FIXED JENKINS-24071] Execute command remotely on slaves, not on master (+formating)" This reverts commit 9f6f42df0a667c6b7bc28793b04955991dd29864. Actually didn't fix the issue (see JENKINS-24071 ) and potentially makes it even worse.

vjuranek added a comment - 2014-09-11 20:02

Sorry, it wasn't intended to resolve this issue (I just reverted previous commit which makes it potentially even worse)

vjuranek added a comment - 2014-09-11 20:02 Sorry, it wasn't intended to resolve this issue (I just reverted previous commit which makes it potentially even worse)

Vince Webb added a comment - 2015-06-11 15:22 - edited

Is there a workaround for this issue ?

I bumped into the same problem with docker-build-step version 1.25

It was giving me an error about the "docker" directory not existing in my workspace.
FATAL: configured dockerFolder '/srv/app/workspace/workspace/my_project_name/docker' does not exist.

This is frustrating when you know it does exist (in the slave). After copying the directory structure from slave to master, hey presto the error went away and my docker image got built.

From day one I was curious about why the config for this plugin requires that "Docker service is running on slaves where you run the build" AND "you need to specify Docker REST API URL."

I understand that both make good sense but don't understand why both are needed. I rather thought access to the API would be enough.

Vince Webb added a comment - 2015-06-11 15:22 - edited Is there a workaround for this issue ? I bumped into the same problem with docker-build-step version 1.25 It was giving me an error about the "docker" directory not existing in my workspace. FATAL: configured dockerFolder '/srv/app/workspace/workspace/my_project_name/docker' does not exist. This is frustrating when you know it does exist (in the slave). After copying the directory structure from slave to master, hey presto the error went away and my docker image got built. From day one I was curious about why the config for this plugin requires that "Docker service is running on slaves where you run the build" AND "you need to specify Docker REST API URL." I understand that both make good sense but don't understand why both are needed. I rather thought access to the API would be enough.

Vince Webb added a comment - 2015-06-11 15:36

FATAL: configured dockerFolder '/srv/app/workspace/workspace/vw_test2/docker' does not exist.
java.lang.IllegalArgumentException: configured dockerFolder '/srv/app/workspace/workspace/vw_test2/docker' does not exist.
at org.jenkinsci.plugins.dockerbuildstep.cmd.CreateImageCommand.execute(CreateImageCommand.java:87)
at org.jenkinsci.plugins.dockerbuildstep.DockerBuilder.perform(DockerBuilder.java:74)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:770)
at hudson.model.Build$BuildExecution.build(Build.java:199)
at hudson.model.Build$BuildExecution.doRun(Build.java:160)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:533)
at hudson.model.Run.execute(Run.java:1745)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:89)
at hudson.model.Executor.run(Executor.java:240)

Vince Webb added a comment - 2015-06-11 15:36 FATAL: configured dockerFolder '/srv/app/workspace/workspace/vw_test2/docker' does not exist. java.lang.IllegalArgumentException: configured dockerFolder '/srv/app/workspace/workspace/vw_test2/docker' does not exist. at org.jenkinsci.plugins.dockerbuildstep.cmd.CreateImageCommand.execute(CreateImageCommand.java:87) at org.jenkinsci.plugins.dockerbuildstep.DockerBuilder.perform(DockerBuilder.java:74) at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:770) at hudson.model.Build$BuildExecution.build(Build.java:199) at hudson.model.Build$BuildExecution.doRun(Build.java:160) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:533) at hudson.model.Run.execute(Run.java:1745) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:89) at hudson.model.Executor.run(Executor.java:240)

Deryk Sinotte added a comment - 2015-12-10 17:19

Just went through the whole dance before I found this ticket. Is there any work/movement on this issue? It would be nice to be able work with Docker on a slave without having to recreate the infrastructure on the master.

Deryk Sinotte added a comment - 2015-12-10 17:19 Just went through the whole dance before I found this ticket. Is there any work/movement on this issue? It would be nice to be able work with Docker on a slave without having to recreate the infrastructure on the master.

Giovanni Tirloni added a comment - 2016-01-04 13:40

Also hit this bug with Jenkins 1.6.42 and plugin version 1.33. I'm trying to build a Docker image on a slave.

Giovanni Tirloni added a comment - 2016-01-04 13:40 Also hit this bug with Jenkins 1.6.42 and plugin version 1.33. I'm trying to build a Docker image on a slave.

Vince Webb added a comment - 2016-01-04 17:19

To get around this bug I used a different plugin to do the Docker build. There is a Cloudbees plugin called Build and Publish (or something like that). It works OK provided you want to not only build but push as well.

Vince Webb added a comment - 2016-01-04 17:19 To get around this bug I used a different plugin to do the Docker build. There is a Cloudbees plugin called Build and Publish (or something like that). It works OK provided you want to not only build but push as well.

Mark R added a comment - 2016-01-15 19:54 - edited

This really needs to get fixed. This plugin is of no use to us if it can't build docker images on remote machines.

Mark R added a comment - 2016-01-15 19:54 - edited This really needs to get fixed. This plugin is of no use to us if it can't build docker images on remote machines.

Radka Nepejchalova added a comment - 2016-01-21 14:40

This ticket really makes this plugin almost useless. Did someone find any workaround?

Radka Nepejchalova added a comment - 2016-01-21 14:40 This ticket really makes this plugin almost useless. Did someone find any workaround?

Ebrahim Moshaya added a comment - 2016-02-07 11:59

any update on this? We need to be able to execute docker commands on slaves...

Ebrahim Moshaya added a comment - 2016-02-07 11:59 any update on this? We need to be able to execute docker commands on slaves...

vjuranek added a comment - 2016-02-08 09:49

Hi,
I looked on this issue quite a long time ago - IIRC there is an issue with serialization which is not very easy to solve. If I find some time, I'd like to look on it again soon, but not promises
Thanks for understanding

vjuranek added a comment - 2016-02-08 09:49 Hi, I looked on this issue quite a long time ago - IIRC there is an issue with serialization which is not very easy to solve. If I find some time, I'd like to look on it again soon, but not promises Thanks for understanding

Eric Lemanissier added a comment - 2016-02-08 10:16

It should be possible to workaround this by using https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Plugin

Eric Lemanissier added a comment - 2016-02-08 10:16 It should be possible to workaround this by using https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Plugin

Barry Laffoy added a comment - 2017-06-19 06:42

Has there been any further work done on this? With this bug, this plugin is basically unusable on any Jenkins setup that makes use of agents not on the master.

If this bug hasn't been addressed in three years, then it seems like all the other work put into this plugin has been a waste of time.

Barry Laffoy added a comment - 2017-06-19 06:42 Has there been any further work done on this? With this bug, this plugin is basically unusable on any Jenkins setup that makes use of agents not on the master. If this bug hasn't been addressed in three years, then it seems like all the other work put into this plugin has been a waste of time.

Petri Sirkkala added a comment - 2017-06-29 16:00

This is very serious limitation. Running all the databases and test environments on Jenkins master will certainly make the Jenkins very unresponsive. Slaves are a must for any serious heavy use CI/CD. The load must be shared and some priority operations separated to ensure thorough operation. We can not risk deployment operations because a wild running test is breaking the master.

Petri Sirkkala added a comment - 2017-06-29 16:00 This is very serious limitation. Running all the databases and test environments on Jenkins master will certainly make the Jenkins very unresponsive. Slaves are a must for any serious heavy use CI/CD. The load must be shared and some priority operations separated to ensure thorough operation. We can not risk deployment operations because a wild running test is breaking the master.

David Csakvari added a comment - 2017-09-06 15:41 - edited

Hi!

I've created a Pull Request to overcome this limitation:

https://github.com/jenkinsci/docker-build-step-plugin/pull/51

It's not feature-complete, but it makes the CreateImageCommand play nicely with slaves. If this solution is acceptable, I'll gladly modify the other Commands as well to work with slaves.

Thanks,

David

David Csakvari added a comment - 2017-09-06 15:41 - edited Hi! I've created a Pull Request to overcome this limitation: https://github.com/jenkinsci/docker-build-step-plugin/pull/51 It's not feature-complete, but it makes the CreateImageCommand play nicely with slaves. If this solution is acceptable, I'll gladly modify the other Commands as well to work with slaves. Thanks, David

SCM/JIRA link daemon added a comment - 2018-01-11 13:26

Code changed in jenkins
User: David Csakvari
Path:
src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerBuilder.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerPostBuilder.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CommitCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CreateContainerCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CreateImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/DockerCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecCreateAndStartCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecCreateCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecStartCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/KillCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/PullImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/PushImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveAllCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RestartCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/SaveImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StartByImageIdCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StartCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopAllCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopByImageIdCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/TagImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/util/Resolver.java
http://jenkins-ci.org/commit/docker-build-step-plugin/30ab1b41697a8509d27469296c61d57110c24f2f
Log:
Fix for ~~JENKINS-24071~~

Fix for issue that prevents Docker build step to build images on Jenkins
slaves.

SCM/JIRA link daemon added a comment - 2018-01-11 13:26 Code changed in jenkins User: David Csakvari Path: src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerBuilder.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerPostBuilder.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CommitCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CreateContainerCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CreateImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/DockerCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecCreateAndStartCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecCreateCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecStartCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/KillCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/PullImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/PushImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveAllCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RestartCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/SaveImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StartByImageIdCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StartCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopAllCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopByImageIdCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/TagImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/util/Resolver.java http://jenkins-ci.org/commit/docker-build-step-plugin/30ab1b41697a8509d27469296c61d57110c24f2f Log: Fix for JENKINS-24071 Fix for issue that prevents Docker build step to build images on Jenkins slaves.

SCM/JIRA link daemon added a comment - 2018-01-21 21:31

Code changed in jenkins
User: David Csakvari
Path:
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CommitCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CreateContainerCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CreateImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/DockerCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecCreateAndStartCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecCreateCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecStartCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/KillCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/PullImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/PushImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveAllCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RestartCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/SaveImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StartByImageIdCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StartCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopAllCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopByImageIdCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/TagImageCommand.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/CommitRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/CreateContainerRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/CreateImageRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/ExecCreateRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/ExecStartRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/InspectContainerRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/KillContainerRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/ListContainersRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/PullImageRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/PushImageRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/RemoveContainerRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/RemoveImageRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/RestartContainerRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/SaveImageRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/StartContainerRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/StopContainerRemoteCallable.java
src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/TagImageRemoteCallable.java
http://jenkins-ci.org/commit/docker-build-step-plugin/11a0346f0efa34feb09b408be9fa27d7186a3ec7
Log:
Fix for ~~JENKINS-24071~~

Refactor remaining commands to use Channel so they can work on Jenkins
slaves.

SCM/JIRA link daemon added a comment - 2018-01-21 21:31 Code changed in jenkins User: David Csakvari Path: src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CommitCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CreateContainerCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/CreateImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/DockerCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecCreateAndStartCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecCreateCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/ExecStartCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/KillCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/PullImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/PushImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveAllCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RemoveImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/RestartCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/SaveImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StartByImageIdCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StartCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopAllCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopByImageIdCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/StopCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/TagImageCommand.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/CommitRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/CreateContainerRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/CreateImageRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/ExecCreateRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/ExecStartRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/InspectContainerRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/KillContainerRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/ListContainersRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/PullImageRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/PushImageRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/RemoveContainerRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/RemoveImageRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/RestartContainerRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/SaveImageRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/StartContainerRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/StopContainerRemoteCallable.java src/main/java/org/jenkinsci/plugins/dockerbuildstep/cmd/remote/TagImageRemoteCallable.java http://jenkins-ci.org/commit/docker-build-step-plugin/11a0346f0efa34feb09b408be9fa27d7186a3ec7 Log: Fix for JENKINS-24071 Refactor remaining commands to use Channel so they can work on Jenkins slaves.

vjuranek added a comment - 2018-01-21 21:48

Done, thanks to dodiehun!

vjuranek added a comment - 2018-01-21 21:48 Done, thanks to dodiehun !

People

Assignee:: vjuranek

Reporter:: Hack Kampbjørn

Votes:: 19 Vote for this issue

Watchers:: 28 Start watching this issue

Dates

Created:: 2014-07-31 21:05

Updated:: 2018-01-21 21:48

Resolved:: 2018-01-21 21:48