Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24076

Incorrect builds used to generate deltas (No deltas for builds fixed after failure where errors were introduced)

    • Icon: New Feature New Feature
    • Resolution: Unresolved
    • Icon: Major Major
    • cppcheck-plugin
    • None

      As an example, consider the following:

      Build 1 - Stable (within CPPCheck threshold)
      Build 2 - Unstable (exceeds CPPCheck threshold)
      Build 3 - Unstable (no change)
      Build 4 - Unstable (no change)

      If you view the CPPCheck results for build 4, it shows the resolved issues since the dawn of time, which is arguably incorrect (see attached image for an example of solved errors showing when the delta is 0), but more crucially, generates its delta for new errors against the previous build, regardless of the build status.

      This creates the problem that, once build 2 drops off the history, you lose the deltas that help you identify the new errors that were introduced, because the deltas don't exist for build 3 or build 4 (they are zero).

      There are one of two solutions I can think of:

      1. Allow the previous build status for delta generation to be specified in the configuration: lastStableBuild, lastSuccessfulBuild

      2. Hard code it to use the lastStableBuild only.

          [JENKINS-24076] Incorrect builds used to generate deltas (No deltas for builds fixed after failure where errors were introduced)

          Craig Phillips created issue -
          Craig Phillips made changes -
          Attachment New: cppcheck-delta-incorrect.png [ 26475 ]
          Craig Phillips made changes -
          Attachment New: cppcheck2.png [ 26529 ]
          Craig Phillips made changes -
          Priority Original: Major [ 3 ] New: Critical [ 2 ]
          Summary Original: Incorrect builds used to generate deltas New: Incorrect builds used to generate deltas (No deltas for builds fixed after failure where errors were introduced)
          Craig Phillips made changes -
          Assignee Original: Gregory Boissinot [ gbois ] New: Michal Turek [ mixalturek ]
          Michal Turek made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Michal Turek made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]
          Michal Turek made changes -
          Assignee Original: Michal Turek [ mixalturek ] New: Craig Phillips [ iwonbigbro ]
          Michal Turek made changes -
          Issue Type Original: Bug [ 1 ] New: New Feature [ 2 ]
          Priority Original: Critical [ 2 ] New: Major [ 3 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 156949 ] New: JNJira + In-Review [ 179454 ]

            iwonbigbro Craig Phillips
            iwonbigbro Craig Phillips
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: