Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24141

SCM with non-AbstractProject, revisited

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      JENKINS-23365 made it possible to use SCM from other contexts. But there are still some SCM-oriented things stuck in AbstractProject/AbstractBuild which ought to be generalized.

      • AbstractBuild.getChangeSets (as used by project-changes.jelly) does not implement any method. Either this should be pushed up into Run so that it can be used more generally (simple though an awkward introduction of SCM specifics into Run); or SCMTriggerItem should add getChangeSets(Run) (more sensible architecturally, though awkward since it could not have a generic type for the build).
      • getCulprits and hasParticipant would seem to apply to any build with changes.
      • AbstractProject.doRssChangelog could be moved elsewhere and use getChangeSets.
      • View.AsynchPeople could use getChangeSets.

      Possibly there needs to be an interface for a Run with changes, tied somehow to SCMTriggerItem and with some default methods?

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is blocking JENKINS-23365 [ JENKINS-23365 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-26100 [ JENKINS-26100 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-30252 [ JENKINS-30252 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-28946 [ JENKINS-28946 ]
            valones Flávio Augusto Valones made changes -
            Link This issue is related to JENKINS-33016 [ JENKINS-33016 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-30412 [ JENKINS-30412 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 157015 ] JNJira + In-Review [ 179480 ]
            abayer Andrew Bayer made changes -
            Labels api scm workflow api pipeline scm workflow
            abayer Andrew Bayer made changes -
            Labels api pipeline scm workflow api pipeline scm
            jglick Jesse Glick made changes -
            Link This issue is duplicated by JENKINS-37872 [ JENKINS-37872 ]
            abayer Andrew Bayer made changes -
            Assignee Andrew Bayer [ abayer ]
            abayer Andrew Bayer made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            abayer Andrew Bayer made changes -
            Remote Link This issue links to "PR #2730 (Web Link)" [ 15367 ]
            jglick Jesse Glick made changes -
            Link This issue is duplicated by JENKINS-35462 [ JENKINS-35462 ]
            abayer Andrew Bayer made changes -
            Remote Link This issue links to "workflow-job-plugin PR #35 (Web Link)" [ 15370 ]
            jglick Jesse Glick made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            davidvanlaatum David van Laatum made changes -
            Remote Link This issue links to "Page (Jenkins Wiki)" [ 17937 ]
            davidvanlaatum David van Laatum made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              Assignee:
              abayer Andrew Bayer
              Reporter:
              jglick Jesse Glick
              Votes:
              23 Vote for this issue
              Watchers:
              34 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: