Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24441

in jenkins (1.577 ) Config File Management plugin in main-panel-content are has ivalid icon path ( double slash before plugin path )

XMLWordPrintable

      main panel content rendered in such way.
      may instance is running 1.577 and does not have suffix

      <div id="main-panel-content">
      <a name="skip2content"></a>
      <h1><img alt="" src="//plugin/config-file-provider/images/cfg_logo.png" />
      Config File Management
      </h1>You can edit or remove your configuration files<div class="excerpt"><p></p><p></p>

      i think it is related to changes caused JENKINS-24316

          [JENKINS-24441] in jenkins (1.577 ) Config File Management plugin in main-panel-content are has ivalid icon path ( double slash before plugin path )

          Daniel Beck added a comment -

          Did this issue not occur in older Jenkins versions?

          I'm asking because it looks like an issue with https://github.com/jenkinsci/config-file-provider-plugin/blob/master/src/main/resources/org/jenkinsci/plugins/configfiles/ConfigFilesManagement/index.jelly

          It concatenates / and /plugin/config-file-provider/images/cfg_logo.png.

          Daniel Beck added a comment - Did this issue not occur in older Jenkins versions? I'm asking because it looks like an issue with https://github.com/jenkinsci/config-file-provider-plugin/blob/master/src/main/resources/org/jenkinsci/plugins/configfiles/ConfigFilesManagement/index.jelly It concatenates / and /plugin/config-file-provider/images/cfg_logo.png .

          Dominik Bartholdi added a comment -

          danielbeck I think you'r right - but as you say, how come it was never an issue with older versions? ...this has not changed

          anyway, is the issue also to see with any other images related to this plugin?

          Dominik Bartholdi added a comment - danielbeck I think you'r right - but as you say, how come it was never an issue with older versions? ...this has not changed anyway, is the issue also to see with any other images related to this plugin?

          Denis Shvedchenko added a comment -

          no, in Manage Jenkins icons displayed correclty
          as for previous version, i do not remeber

          Denis Shvedchenko added a comment - no, in Manage Jenkins icons displayed correclty as for previous version, i do not remeber

          Daniel Beck added a comment -

          domi: I don't use this plugin but if users have a non-empty context path (e.g. /jenkins as used by hpi:run), this doesn't matter – only when at the beginning, the double-slash has special meaning. And then you'll actually need to notice the issue, as many browsers will just not display anything instead of the image. If you've never seen it, you won't miss it.

          Daniel Beck added a comment - domi : I don't use this plugin but if users have a non-empty context path (e.g. /jenkins as used by hpi:run), this doesn't matter – only when at the beginning, the double-slash has special meaning. And then you'll actually need to notice the issue, as many browsers will just not display anything instead of the image. If you've never seen it, you won't miss it.

          Dominik Bartholdi added a comment -

          fixed with https://github.com/jenkinsci/config-file-provider-plugin/commit/a0ac2f33663f9b9d8e36c936d0ab1df8ba489c86

          Dominik Bartholdi added a comment - fixed with https://github.com/jenkinsci/config-file-provider-plugin/commit/a0ac2f33663f9b9d8e36c936d0ab1df8ba489c86

            domi Dominik Bartholdi
            dshvedchenko Denis Shvedchenko
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: