Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24483

RepositoryBrowser.getChangeSetLink exceptions from Jelly pollute log

      Your Jenkins log can fill up with long stack traces like

      h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: browser.getChangeSetLink(cs) in /jenkins/job/.../1234/. Reason: java.net.MalformedURLException: no protocol: 
      java.net.MalformedURLException: no protocol: 
      	at java.net.URL.<init>(URL.java:585)
      	at java.net.URL.<init>(URL.java:482)
      	at java.net.URL.<init>(URL.java:431)
      	at hudson.plugins.git.browser.GitRepositoryBrowser.getUrl(GitRepositoryBrowser.java:47)
      	at hudson.plugins.git.browser.GithubWeb.getChangeSetLink(GithubWeb.java:40)
      	at ...
      

      when this is a harmless condition: just an unconfigured git repository browser base URL.

      Probably RepositoryBrowser should get a new method that calls getChangeSetLink but logs exceptions at FINE and returns null, and then Jelly views (both in core and plugins) should be updated to use it. (Falling back to displaying an unlinked changeset, just as if getChangeSetLink returned null.)

          [JENKINS-24483] RepositoryBrowser.getChangeSetLink exceptions from Jelly pollute log

          Jesse Glick created issue -
          Oleg Zoo made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Oleg Zoo made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 157464 ] New: JNJira + In-Review [ 179589 ]
          Mark Waite made changes -
          Description Original: Your Jenkins log can fill up with long stack traces like

          {code:none}
          h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: browser.getChangeSetLink(cs) in /jenkins/job/.../1234/. Reason: java.net.MalformedURLException: no protocol:
          java.net.MalformedURLException: no protocol:
          at java.net.URL.<init>(URL.java:585)
          at java.net.URL.<init>(URL.java:482)
          at java.net.URL.<init>(URL.java:431)
          at hudson.plugins.git.browser.GitRepositoryBrowser.getUrl(GitRepositoryBrowser.java:47)
          at hudson.plugins.git.browser.GithubWeb.getChangeSetLink(GithubWeb.java:40)
          at ...
          {code}

          when this is a harmless condition: just an unconfigured base URL.

          Probably {{RepositoryBrowser}} should get a new method that calls {{getChangeSetLink}} but logs exceptions at {{FINE}} and returns null, and then Jelly views (both in core and plugins) should be updated to use it. (Falling back to displaying an unlinked changeset, just as if {{getChangeSetLink}} returned null.)
          New: Your Jenkins log can fill up with long stack traces like

          {code:none}
          h.ExpressionFactory2$JexlExpression#evaluate: Caught exception evaluating: browser.getChangeSetLink(cs) in /jenkins/job/.../1234/. Reason: java.net.MalformedURLException: no protocol:
          java.net.MalformedURLException: no protocol:
          at java.net.URL.<init>(URL.java:585)
          at java.net.URL.<init>(URL.java:482)
          at java.net.URL.<init>(URL.java:431)
          at hudson.plugins.git.browser.GitRepositoryBrowser.getUrl(GitRepositoryBrowser.java:47)
          at hudson.plugins.git.browser.GithubWeb.getChangeSetLink(GithubWeb.java:40)
          at ...
          {code}

          when this is a harmless condition: just an unconfigured git repository browser base URL.

          Probably {{RepositoryBrowser}} should get a new method that calls {{getChangeSetLink}} but logs exceptions at {{FINE}} and returns null, and then Jelly views (both in core and plugins) should be updated to use it. (Falling back to displaying an unlinked changeset, just as if {{getChangeSetLink}} returned null.)
          Nicolas De Loof made changes -
          Assignee Original: Nicolas De Loof [ ndeloof ]

            Unassigned Unassigned
            jglick Jesse Glick
            Votes:
            11 Vote for this issue
            Watchers:
            14 Start watching this issue

              Created:
              Updated: