Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24575

The instance of extension class should not be kept

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • gerrit-trigger-plugin
    • None
    • Jenkins 1.565.1
      Gerrit Trigger 2.11.0-beta-4

    Description

      Some classes which is extended from Extension keeps one's instance into one's member.

      It might cause memory leak after restart.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          rin_ne rin_ne created issue -
          rin_ne rin_ne made changes -
          Field Original Value New Value
          URL https://github.com/jenkinsci/gerrit-trigger-plugin/pull/174
          rin_ne rin_ne made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: rinrinne
          Path:
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/dependency/DependencyQueueTaskDispatcher.java
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/RetriggerAction.java
          src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/RetriggerAllAction.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/500bd4dc496a027bc1feac169fd71c304b4ebe32
          Log:
          Don't keep Extension instances

          All instance of Extension extended class must be fully managed by
          Jenkins instance. So those must not be reused by other instances.

          This patch fixes such issue. Targets are:

          • ToGerritRunListener
          • DependencyQueueTaskDispatcher

          Fix for JENKINS-24575

          Task-Url: https://issues.jenkins-ci.org/browse/JENKINS-24575

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: rinrinne Path: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/dependency/DependencyQueueTaskDispatcher.java src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/RetriggerAction.java src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/RetriggerAllAction.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/500bd4dc496a027bc1feac169fd71c304b4ebe32 Log: Don't keep Extension instances All instance of Extension extended class must be fully managed by Jenkins instance. So those must not be reused by other instances. This patch fixes such issue. Targets are: ToGerritRunListener DependencyQueueTaskDispatcher Fix for JENKINS-24575 Task-Url: https://issues.jenkins-ci.org/browse/JENKINS-24575
          rin_ne rin_ne made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 157566 ] JNJira + In-Review [ 208024 ]

          People

            rsandell rsandell
            rin_ne rin_ne
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: