Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24581

tasks status icon not visible at overview of single task

      The batch tasks status icon is not visible at overview of single task.
      I think before the big design updates they where visible.

      Affected URL is e.g. /job/foo/batchTasks/task/bar/

          [JENKINS-24581] tasks status icon not visible at overview of single task

          Daniel Beck added a comment -

          Please specify the correct Jenkins version.

          Daniel Beck added a comment - Please specify the correct Jenkins version.

          podskalsky added a comment -

          jenkins 1.578

          podskalsky added a comment - jenkins 1.578

          Daniel Beck added a comment -

          Is this the tasks you're referring to: https://wiki.jenkins-ci.org/display/JENKINS/Task+Scanner+Plugin ?

          Does it also affect tasks run/created after the update?

          Daniel Beck added a comment - Is this the tasks you're referring to: https://wiki.jenkins-ci.org/display/JENKINS/Task+Scanner+Plugin ? Does it also affect tasks run/created after the update?

          podskalsky added a comment -

          podskalsky added a comment - This is the plugin: http://wiki.jenkins-ci.org/display/JENKINS/Batch+Task+Plugin

          Daniel Beck added a comment -

          Caused by the redesign changes: Jenkins core assumes that everything displayed in a HistoryWidget has buildStatusIconClassName (new core API only used from Jelly).

          Should probably consider a compatibility fallback to getIconColor (why wasn't this just used instead of extending the API for this!?) or getBuildStatusUrl if the new method doesn't exist.

          Assigning to Tom.

          Daniel Beck added a comment - Caused by the redesign changes: Jenkins core assumes that everything displayed in a HistoryWidget has buildStatusIconClassName (new core API only used from Jelly). Should probably consider a compatibility fallback to getIconColor (why wasn't this just used instead of extending the API for this!?) or getBuildStatusUrl if the new method doesn't exist. Assigning to Tom.

          Daniel Beck added a comment -

          tfennelly Ping!

          Daniel Beck added a comment - tfennelly Ping!

          acollins added a comment -

          I'm interested helping to fix this bug. I've checked out batch-task-plugin-master from GitHub. Can anyone point me to the right docs to get started? BatchTask implements Queue.Task, does that need to change for newer versions of Jenkins?

          acollins added a comment - I'm interested helping to fix this bug. I've checked out batch-task-plugin-master from GitHub. Can anyone point me to the right docs to get started? BatchTask implements Queue.Task, does that need to change for newer versions of Jenkins?

          Tom FENNELLY added a comment -

          Can someone attach another screenshot to show what's been lost i.e. a before and after. Thanks.

          Tom FENNELLY added a comment - Can someone attach another screenshot to show what's been lost i.e. a before and after. Thanks.

          podskalsky added a comment -

          A old screen shot - OK

          podskalsky added a comment - A old screen shot - OK

          podskalsky added a comment -

          Added screenshots ... from FIREFOX !!!

          OLD OK (taken from a internal manual)

          LATEST NOT OK

          podskalsky added a comment - Added screenshots ... from FIREFOX !!! OLD OK (taken from a internal manual) LATEST NOT OK

          Tom FENNELLY added a comment - - edited

          @poskalsky Thanks Andreas.

          @acollins Ashley, I have not look at this issue myself but Daniel (Beck) has indicated that the issue is in Jenkins Core. See his comment from Sept 5th last year. It would be awesome if you could come up with a fix proposal.

          Tom FENNELLY added a comment - - edited @poskalsky Thanks Andreas. @acollins Ashley, I have not look at this issue myself but Daniel (Beck) has indicated that the issue is in Jenkins Core. See his comment from Sept 5th last year. It would be awesome if you could come up with a fix proposal.

          Hi, I've submitted a pull request that will hopefully fix this issue: https://github.com/jenkinsci/batch-task-plugin/pull/1

          Petur Thorsteinsson added a comment - Hi, I've submitted a pull request that will hopefully fix this issue: https://github.com/jenkinsci/batch-task-plugin/pull/1

          I've updated the pull request - it would be great if somebody could take a look at it and hopefully close this issue.

          Petur Thorsteinsson added a comment - I've updated the pull request - it would be great if somebody could take a look at it and hopefully close this issue.

          I would like to get the fix merged. I am willing to update the merge request. Anyone of the original participants still interested in this plugin?

          Michael Paesold added a comment - I would like to get the fix merged. I am willing to update the merge request. Anyone of the original participants still interested in this plugin?

          podskalsky added a comment -

          At the moment we don't use that feature.
          But If you will merge it, I can check if the new version of the plugin is working for me.

          podskalsky added a comment - At the moment we don't use that feature. But If you will merge it, I can check if the new version of the plugin is working for me.

          I have added an updated (rebased) PR at https://github.com/jenkinsci/batch-task-plugin/pull/7.

          See additional comments there.

          Michael Paesold added a comment - I have added an updated (rebased) PR at https://github.com/jenkinsci/batch-task-plugin/pull/7 . See additional comments there.

          If you want to test the snapshot build locally, you can download the .hpi file from https://jenkins.ci.cloudbees.com/job/plugins/job/batch-task-plugin/42/org.jenkins-ci.plugins$batch-task/.

          Michael Paesold added a comment - If you want to test the snapshot build locally, you can download the .hpi file from https://jenkins.ci.cloudbees.com/job/plugins/job/batch-task-plugin/42/org.jenkins-ci.plugins$batch-task/ .

          podskalsky added a comment -

          My Server is now running latest Jenkins ver. 2.33 .
          In that version I've loaded your 1.20-SNAPSHOT Plugin.

          Here the build history for tasks is empty!
          But that's the situation you have commented at https://github.com/jenkinsci/batch-task-plugin/pull/7

          Also fix on the latest Jenkins version 2.xx including the working build history for Tasks is required !
          This snapshot version is at the moment not usable for Jenkins version 2.xx .
          We need a working build history for Tasks.

          podskalsky added a comment - My Server is now running latest Jenkins ver. 2.33 . In that version I've loaded your 1.20-SNAPSHOT Plugin. Here the build history for tasks is empty! But that's the situation you have commented at https://github.com/jenkinsci/batch-task-plugin/pull/7 Also fix on the latest Jenkins version 2.xx including the working build history for Tasks is required ! This snapshot version is at the moment not usable for Jenkins version 2.xx . We need a working build history for Tasks.

          Michael Paesold added a comment - - edited

          You are right, I did not copy that information here:

          The patch fixes the display up until LTS 1.625.3. Patched version tested with LTS 1.596.3, 1.609.3, and 1.625.3.

          LTS 1.642.1 and later have a new build history pagination and search, which completely hides the batch tasks history items. To correctly support those versions, more work is required. I did not yet have the time to look at the required changes.

          I would still think the PR is useful as it is and actually fixes the originally reported issue. So I would ask the maintainers to merge this on Github.

          I would create a new issue to fix the batch task history display for Jenkins LTS 1.642.1 and later. Of course leaving the issue open until a complete fix is available is okay with me.

          Michael Paesold added a comment - - edited You are right, I did not copy that information here: The patch fixes the display up until LTS 1.625.3. Patched version tested with LTS 1.596.3, 1.609.3, and 1.625.3. LTS 1.642.1 and later have a new build history pagination and search, which completely hides the batch tasks history items. To correctly support those versions, more work is required. I did not yet have the time to look at the required changes. I would still think the PR is useful as it is and actually fixes the originally reported issue. So I would ask the maintainers to merge this on Github. I would create a new issue to fix the batch task history display for Jenkins LTS 1.642.1 and later. Of course leaving the issue open until a complete fix is available is okay with me.

          A JIRA task for supporting Jenkins Versions starting with 1.634 (or LTS 1.642.1) already exists, it is JENKINS-33833.

          Michael Paesold added a comment - A JIRA task for supporting Jenkins Versions starting with 1.634 (or LTS 1.642.1) already exists, it is JENKINS-33833 .

          Michael Paesold added a comment - - edited

          tfennelly, fbelzunc, mindless - is anyone of you currently available for maintaining this plugin, i.e. review and merge pull requests?

          Michael Paesold added a comment - - edited tfennelly , fbelzunc , mindless - is anyone of you currently available for maintaining this plugin, i.e. review and merge pull requests?

            tfennelly Tom FENNELLY
            podskalsky podskalsky
            Votes:
            6 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated: