This line is bogus, needs to be getAllItems(...):
https://github.com/jenkinsci/github-plugin/blob/49bc59d79707808d73eb0f9d5c97996fd5525d08/src/main/java/com/cloudbees/jenkins/Cleaner.java#L55

I don't have a Java development environment, but I would be very much interested in testing a fix if someone can provide it

I sent a pull request with the above fix. It fixed the issue for me.

https://github.com/jenkinsci/github-plugin/pull/51#issuecomment-84089491

Code changed in jenkins
User: Ryan Gardner
Path:
src/main/java/com/cloudbees/jenkins/Cleaner.java
http://jenkins-ci.org/commit/github-plugin/2a49bac65fb7e05cd083e8b445ad2fcfb689ae0a
Log:
Address JENKINS-25127 by using getAllIItems instead of getItems

Nice! ETA for a release with this fix?

Oh, I see 1.11.1 is out, thanks!

Is there any way to tell all the jobs to re-register in GitHub? Right now the only way I could find to do this is to go to each jobs's config and save it again, which is a bit impractical when you have many jobs.

Thanks!

Hi, please try restart jenkins.

It doesn't help.

Sorry have no idea.

Closing because issue should be fixed.

integer Did you confirm the fix is complete?

Feel free to check.

integer You resolved this despite a report it's not actually fixed, not me.

I tired from your spam comments. Commit was done with fix but has no FIXED prefix to automatically close issue. If issue persist, then requester will reopen. If you want handle this issue and plugin maintaining then go!

lucasocio: Just a quick comment; I haven't tested this code, but you should be able to use the Jenkins Script Console to re-save all affected jobs. Saving the job config should cause the hook to be created on GitHub:

for (job in Jenkins.instance.getAllItems(AbstractProject.class)) {
  if (job.getTrigger(GitHubPushTrigger.class) != null) {
    println("Saving " + job);
    job.save();
  }
}

You'll probably have to add some "import" statements at the top for the relevant classes.

Or if you want test it first on individual jobs, you can get a single job like this: Jenkins.instance.getItem('job-name-goes-here')

integer cleared up my confusion on IRC: The hooks that have been removed are gone. You need to reconfigure them in Jenkins to have them re-register. At least with the fix, they should not be getting removed again.

Plugin may provide some helper method that should re-calculated hooks, but i have no time for checking. Such method may be triggered from script console or even from button in global page.

I tried the script but I get this error:
groovy.lang.MissingPropertyException: No such property: GitHubPushTrigger for class: Script1

I don't know anything about groovy or java, that means I need an import?

Hi, you need

 import com.cloudbees.jenkins.GitHubPushTrigger 

Thanks a lot! The script have worked (I got the expected println() output) but no re-registration of hooks to GitHub happened :-/

Yes, at least I tried with one job to manually save it and the hook was installed and not removed afterward. I'll try again, saving a couple more jobs manually, and report back, just in case.

I tried with a couple more jobs to save them manually and the hooks were properly registered and never removed again. Is only the script to save all the jobs in a batch that doesn't work for me.

According to code hooks registered during trigger start, all triggers will start during jenkins start-up. So jenkins restart should help.
Please add in your Jenkins -> manage -> system log, new logger for package "com.cloudbees.jenkins" with level ALL. Restart jenkins and check this log.

What am I looking for in this log?

That all hooks where registered for projects that you expect

 LOGGER.log(Level.INFO, "Adding GitHub webhooks for {0}", names); 

Hi, restart wouldn't help. As orrc mentioned hook is registered only when newInstance argument for .start() is true.
I split this functionality to separate method to have ability to call it from groovy and added button in global page.
Proposed PR https://github.com/jenkinsci/github-plugin/pull/52/files

Please test this PR https://github.com/jenkinsci/github-plugin/pull/52 , you can pick built hpi from commit status link.

I tested the PR and the re-register button seems to work fine, thanks!

Code changed in jenkins
User: Kanstantsin Shautsou
Path:
src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java
src/main/resources/com/cloudbees/jenkins/GitHubPushTrigger/global.jelly
http://jenkins-ci.org/commit/github-plugin/6154cedfe18f265aea25756284a3472696eceaff
Log:
JENKINS-25127 Add Button for registering all hooks