Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25224

Use VirtualFile for workspace browser

    XMLWordPrintable

Details

    Description

      WorkspaceBrowser should be extended (or replaced) to accept VirtualFile instead of FilePath. This way, we can provide more flexibility for deployments and systems that manage workspaces.

      Attachments

        Issue Links

          Activity

            kohsuke Kohsuke Kawaguchi created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Labels api cloud workspace
            jglick Jesse Glick added a comment -

            Taking VirtualFile would certainly help, though this means AbstractProject.getWorkspace cannot work—you would also need to introduce a new set of methods for finding the VirtualFile root to browse.

            Also VirtualFile as written is not quite flexible enough, because it assumes that the master should be in charge of retrieving file contents (as bytestreams) and serving them to the client. What we found was necessary also for making an ArtifactManager based on, say, S3 was to allow VirtualFile to optionally designate a replacement URL that would be served directly to clients. (DirectoryBrowserSupport would need to call the new method.) In the context of workspace browsing, this would mean that the master could redirect workspace browse requests (from the root, from individual files, or just from certain subtrees) to other servers that could process the request more directly and efficiently.

            jglick Jesse Glick added a comment - Taking VirtualFile would certainly help, though this means AbstractProject.getWorkspace cannot work—you would also need to introduce a new set of methods for finding the VirtualFile root to browse. Also VirtualFile as written is not quite flexible enough, because it assumes that the master should be in charge of retrieving file contents (as bytestreams) and serving them to the client. What we found was necessary also for making an ArtifactManager based on, say, S3 was to allow VirtualFile to optionally designate a replacement URL that would be served directly to clients. ( DirectoryBrowserSupport would need to call the new method.) In the context of workspace browsing, this would mean that the master could redirect workspace browse requests (from the root, from individual files, or just from certain subtrees) to other servers that could process the request more directly and efficiently.
            jglick Jesse Glick added a comment -

            Discussion on dev list suggests extending this to allow ComputerLauncher (perhaps) to honor requests to attach a given workspace to a new slave somehow.

            jglick Jesse Glick added a comment - Discussion on dev list suggests extending this to allow ComputerLauncher (perhaps) to honor requests to attach a given workspace to a new slave somehow.
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-16454 [ JENKINS-16454 ]
            danielbeck Daniel Beck added a comment -

            Would be good if this were designed with extensibility of the file browser in mind. There are several issues around that are about adding features to the workspace browser (e.g. file permissions on Unix nodes, file modification times, and/or allowing to edit or delete files specific).

            danielbeck Daniel Beck added a comment - Would be good if this were designed with extensibility of the file browser in mind. There are several issues around that are about adding features to the workspace browser (e.g. file permissions on Unix nodes, file modification times, and/or allowing to edit or delete files specific).
            jglick Jesse Glick added a comment -

            If you know of particular issues, please link them.

            jglick Jesse Glick added a comment - If you know of particular issues, please link them.
            danielbeck Daniel Beck made changes -
            Link This issue is related to JENKINS-20998 [ JENKINS-20998 ]
            danielbeck Daniel Beck made changes -
            Link This issue is related to JENKINS-24677 [ JENKINS-24677 ]
            danielbeck Daniel Beck added a comment -

            Linked a few issues that are about extending the workspace (or possibly artifacts) browser, and one bug. I'm fairly sure there's also one for showing file ownership/permissions, but I cannot find it right now.

            danielbeck Daniel Beck added a comment - Linked a few issues that are about extending the workspace (or possibly artifacts) browser, and one bug. I'm fairly sure there's also one for showing file ownership/permissions, but I cannot find it right now.
            danielbeck Daniel Beck made changes -
            Link This issue is related to JENKINS-21819 [ JENKINS-21819 ]
            danielbeck Daniel Beck made changes -
            Link This issue is related to JENKINS-20102 [ JENKINS-20102 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 159136 ] JNJira + In-Review [ 179885 ]
            jamesdumay James Dumay made changes -
            Remote Link This issue links to "CloudBees Internal OSS-2513 (Web Link)" [ 18266 ]
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-49635 [ JENKINS-49635 ]

            People

              Unassigned Unassigned
              kohsuke Kohsuke Kawaguchi
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: