I'm still seeing jobs disappear from a ListView after renaming. JENKINS-23893 says this was fixed, but was the fix in 1.565.3 or in the next release?

      I'm also using the NestedViews plugin. Would that make a difference?

          [JENKINS-25276] Job Disappears from ListView after rename

          David Ishee created issue -

          Daniel Beck added a comment -

          Could also be JENKINS-22769 fixed in 1.584.

          Daniel Beck added a comment - Could also be JENKINS-22769 fixed in 1.584.

          David Ishee added a comment -

          I'm an admin user, so hopefully it isn't a permission issue.

          David Ishee added a comment - I'm an admin user, so hopefully it isn't a permission issue.

          Daniel Beck added a comment -

          Are all the affected List Views within Nested Views? Are any List Views within Nested Views not affected?

          It's only relevant if a project is included explicitly by name, regexp and filters don't count.

          Daniel Beck added a comment - Are all the affected List Views within Nested Views? Are any List Views within Nested Views not affected? It's only relevant if a project is included explicitly by name, regexp and filters don't count.
          Daniel Beck made changes -
          Component/s New: nested-view [ 15701 ]

          David Ishee added a comment -

          We use Nested Views heavily so I've only noticed it there. When it disappears, it was because it was included using the checkboxes. (not regexps)

          David Ishee added a comment - We use Nested Views heavily so I've only noticed it there. When it disappears, it was because it was included using the checkboxes. (not regexps)

          This issue is caused by changes in core. Now onRenameJob method is not used. I am looking on this issue because it has big impact on our Jenkins instance, almost all our root views (views owned by Jenkins instance) are NestedView, so almost all our views are affected by this issue. I will comment when I am sure exactly where is the problem in code.

          Lucie Votypkova added a comment - This issue is caused by changes in core. Now onRenameJob method is not used. I am looking on this issue because it has big impact on our Jenkins instance, almost all our root views (views owned by Jenkins instance) are NestedView, so almost all our views are affected by this issue. I will comment when I am sure exactly where is the problem in code.

          Hi,
          I checked a code and the problem is that NestedView is not item but only ViewGroup (in comparing with Folder plugin which does the similar).
          Now renamed job procedure is delegated on ItemListener of ListView for all instances of ListView and method onJobRename is deprecated and do nothing.
          https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/View.java#L588
          https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/ListView.java#L434
          https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/ListView.java#L449

          So unfortunately the old one way stopped work due to empty onJobRename method and new one does not work because NestedView is not Item.

          I am not sure what I should change - the NestedView to meet requirements for working of new way, or the listener of ListView to included even GroupView which is not Item. Someone any suggestion?

          Lucie Votypkova added a comment - Hi, I checked a code and the problem is that NestedView is not item but only ViewGroup (in comparing with Folder plugin which does the similar). Now renamed job procedure is delegated on ItemListener of ListView for all instances of ListView and method onJobRename is deprecated and do nothing. https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/View.java#L588 https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/ListView.java#L434 https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/ListView.java#L449 So unfortunately the old one way stopped work due to empty onJobRename method and new one does not work because NestedView is not Item. I am not sure what I should change - the NestedView to meet requirements for working of new way, or the listener of ListView to included even GroupView which is not Item. Someone any suggestion?

          Jesse Glick added a comment -

          Jenkins.onRenamed still calls View.onJobRenamed for compatibility, so NestedView could still implement it. But this will only work for simple renames at top level. It would be better for the nested view to be included in the ListView listener (both for location change and delete).

          Jesse Glick added a comment - Jenkins.onRenamed still calls View.onJobRenamed for compatibility, so NestedView could still implement it. But this will only work for simple renames at top level. It would be better for the nested view to be included in the ListView listener (both for location change and delete).
          Jesse Glick made changes -
          Link New: This issue is blocking JENKINS-18680 [ JENKINS-18680 ]

            jglick Jesse Glick
            idapperdanman David Ishee
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: