Code changed in jenkins
User: Andrew Bayer
Path:
changelog.html
core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java
core/src/main/java/hudson/node_monitors/AbstractNodeMonitorDescriptor.java
core/src/main/resources/hudson/node_monitors/Messages.properties
http://jenkins-ci.org/commit/jenkins/e38e687d5b66238f406d1e3642a3d5f6a02aaeb2
Log:
[FIXED JENKINS-2548] Slaves taken offline for low disk space will now
come back online when disk space becomes available.

Integrated in jenkins_main_trunk #1334
[FIXED JENKINS-2548] Slaves taken offline for low disk space will now

Andrew Bayer : e38e687d5b66238f406d1e3642a3d5f6a02aaeb2
Files :

• core/src/main/java/hudson/node_monitors/AbstractNodeMonitorDescriptor.java
• core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java
• changelog.html
• core/src/main/resources/hudson/node_monitors/Messages.properties

Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
changelog.html
core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java
core/src/main/java/hudson/node_monitors/AbstractNodeMonitorDescriptor.java
core/src/main/resources/hudson/node_monitors/Messages.properties
http://jenkins-ci.org/commit/jenkins/706b2dfd71904224399e52843233c12e219803e4
Log:
Revert "[FIXED JENKINS-2548] Slaves taken offline for low disk space will now"

This reverts commit e38e687d5b66238f406d1e3642a3d5f6a02aaeb2.

Compare: https://github.com/jenkinsci/jenkins/compare/e38e687...706b2df

Integrated in jenkins_main_trunk #1335
Revert "[FIXED JENKINS-2548] Slaves taken offline for low disk space will now"

Kohsuke Kawaguchi : 706b2dfd71904224399e52843233c12e219803e4
Files :

• core/src/main/java/hudson/node_monitors/AbstractNodeMonitorDescriptor.java
• changelog.html
• core/src/main/resources/hudson/node_monitors/Messages.properties
• core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java

I think we need Computers to treat NodeMonitors as something special. We can have Computers remember the set of NodeMonitors that raising a red flag, and isOffline() would check if this set is empty. This leaves "temporarily offline" concept for administrator's use alone.

This also means NodeMonitors should have a backdoor to raise/drop this red flag, and existing NodeMonitors should be modified to use this mechanism so that automatic on/off and administrative manual on/off will not collide with each other.

I think such a distinction is the only way to make it work correctly in the presence of multiple node monitors reporting problems.

Hello,

I do not mean to moan, but I've been trying to get my Jenkins nodes to come back online in the last 30-40 mins and it doesn't matter if I click the button 'back online' or restart Jenkins itself, it doesn't make a difference.

One node just on its own managed to come back online, not sure how/why.

I'm a bit surprised that this isn't biting many more people.

May I suggest increasing the priority of this issue?

Kolos

Ah, ok, it looks like I need to do these to bring a node back online:

In order:

1. clean up disk space
2. restart Jenkins itself
3. mark the offline node as being back online

Kolos

@kolos: we are using swarm clients, and all I need to do is press the "bring this node back online" button. I have to do this all the time, and I never had to restart Jenkins.

another way to make slave online by running cli
java -jar $CLIJAR -s $URL -i $sshkey online-node $SLAVE

but at my jenkins environment (1.447.2 LTS jenkins) (Ubuntu 10.04.3 LTS ) ,
after running above cli, it make slave online but again in few second, jenkins make it offline...
after running cli for few times(ore than 2 and 3), slave appears online.

seems need change in jenkins core to make it stable.

please share your comments if any.

Hit this today, too.

Master has many slaves on many hosts, all running Windows, and Jenkins 1.458, and this is so far happening on two slave hosts. Both affected slave hosts had total 2 slaves. One slave node on each host works ok, showing plenty of free disk space on Build Executor Status page. But the other slave node on both hosts refuses to come online and shows free disk space under 1 gigabyte. Other data on Build Executor Status seems to valid. Both nodes go offline even it is brought back online, due to perceived lack of disk space.

Cloned a third slave on one of the hosts, and run a test job there. The job run and the node seems to work normally. However, in the Build Executor Status, this node reports N/A for all the status items, including Free Disk Space.

Also, as far as is known, the disk space has not really been low on these hosts, ie. the low disk space warning itself is bogus.

Have not yet tried to restart Jenkins, or update to the latest release, so don't know if that will fix the issue, will comment further once that is done.

Update: situation fixed itself without reboot. Or so it seems, at least.

Fixed by pull request 514:
https://github.com/jenkinsci/jenkins/pull/514

Hi,
This issue is fixed or not , if it is fixed please share a fixed version of Jenkins.