[JENKINS-25719] bad html content after upgrading to Email Extension Plugin v2.39

Type: Bug
Resolution: Fixed
Priority: Major
Component/s: email-ext-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

after upgrading from 2.38.2 to 2.39, html content in html email is not correct.

v2.38.2:

</head><body><h1>Compte rendu d'installation sur WMS11DEV</h1>

<p>
Veuillez trouver la liste des patchs installés sur l'environnement WMS11DEV :
</p>

v 2.39:

</head><body><h1>Compte rendu d&amp;apos;installation sur WMS11DEV</h1>

<p>
Veuillez trouver la liste des patchs installés sur l&amp;apos;environnement WMS11DEV :
</p>

the correct content is with

Compte rendu d'installation sur WMS11DEV

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

v2.39.jpg
23 kB
2014-11-20 21:40
v2.38.2.jpg
20 kB
2014-11-20 21:39

is duplicated by

JENKINS-26711 email-ext plugin converting html tags

Resolved

JENKINS-26648 Jelly script needs escapeHtml option

Resolved

JENKINS-30140 quotes become &apos in html content

Resolved

is related to

JENKINS-35669 email-ext-plugin shows HTML entities as plaintext in HTML email output

Closed

Raphaël UNIQUE created issue - 2014-11-20 21:35

Raphaël UNIQUE made changes - 2014-11-20 21:38

Description

Original: after upgrading from 2.38.2 to 2.39, html content in html email is not correct.

v2.38.2:
{noformat}
</head><body><h1>Compte rendu d'installation sur WMS11DEV</h1>

<p>
Veuillez trouver la liste des patchs installés sur l'environnement WMS11DEV :
</p>
{noformat}
v 2.39:
{noformat}
</head><body><h1>Compte rendu d&apos;installation sur WMS11DEV</h1>

<p>
Veuillez trouver la liste des patchs installés sur l&apos;environnement WMS11DEV :
</p>
{noformat}

New: after upgrading from 2.38.2 to 2.39, html content in html email is not correct.

v2.38.2:
{noformat}
</head><body><h1>Compte rendu d'installation sur WMS11DEV</h1>

<p>
Veuillez trouver la liste des patchs installés sur l'environnement WMS11DEV :
</p>
{noformat}
v 2.39:
{noformat}
</head><body><h1>Compte rendu d&apos;installation sur WMS11DEV</h1>

<p>
Veuillez trouver la liste des patchs installés sur l&apos;environnement WMS11DEV :
</p>
{noformat}

the correct content is with
{noformat}
Compte rendu d'installation sur WMS11DEV
{noformat}

Raphaël UNIQUE made changes - 2014-11-20 21:39

Attachment

New: v2.38.2.jpg [ 28050 ]

Raphaël UNIQUE made changes - 2014-11-20 21:40

Attachment

New: v2.39.jpg [ 28051 ]

Alex Earl added a comment - 2014-11-20 21:42 - edited

My guess is that it is this line:

doc.outputSettings(doc.outputSettings().prettyPrint(false).escapeMode(Entities.EscapeMode.xhtml));

The escapeMode was not there before. I have a different fix for this in that if no data-inline is present, then it won't process via Jsoup at all.

Alex Earl added a comment - 2014-11-20 21:42 - edited My guess is that it is this line: doc.outputSettings(doc.outputSettings().prettyPrint(false).escapeMode(Entities.EscapeMode.xhtml)); The escapeMode was not there before. I have a different fix for this in that if no data-inline is present, then it won't process via Jsoup at all.

Alex Earl made changes - 2014-11-28 17:34

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Alex Earl added a comment - 2014-11-29 22:10

Will be fixed in 2.40 which should come out in a few weeks.

Alex Earl added a comment - 2014-11-29 22:10 Will be fixed in 2.40 which should come out in a few weeks.

Alex Earl made changes - 2014-11-29 22:10

Resolution		New: Fixed [ 1 ]
Status	Original: In Progress [ 3 ]	New: Resolved [ 5 ]

SCM/JIRA link daemon added a comment - 2015-01-16 02:54

Code changed in jenkins
User: Alex Earl
Path:
pom.xml
src/main/java/hudson/plugins/emailext/AttachmentUtils.java
src/main/java/hudson/plugins/emailext/EmailExtTemplateAction.java
src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
src/main/java/hudson/plugins/emailext/plugins/CssInliner.java
src/main/java/hudson/plugins/emailext/plugins/EmailTrigger.java
src/main/java/hudson/plugins/emailext/plugins/EmailTriggerDescriptor.java
src/main/java/hudson/plugins/emailext/plugins/trigger/AbstractScriptTrigger.java
src/main/java/hudson/plugins/emailext/plugins/trigger/PreBuildScriptTrigger.java
src/main/java/hudson/plugins/emailext/plugins/trigger/ScriptTrigger.java
src/main/java/hudson/plugins/emailext/watching/EmailExtWatchAction.java
src/main/java/hudson/plugins/emailext/watching/EmailExtWatchJobProperty.java
src/main/resources/hudson/plugins/emailext/EmailExtTemplateAction/action.groovy
src/main/resources/hudson/plugins/emailext/EmailExtTemplateAction/action.jelly
src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy
src/main/resources/hudson/plugins/emailext/Messages.properties
src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/help-triggers.html
src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/help-triggers_ja.html
src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/help-triggers_zh_TW.html
src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/index.groovy
src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/index.properties
src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/jobMain.groovy
src/main/webapp/help/globalConfig/watching.html
src/test/java/hudson/plugins/emailext/EmailTypeTest.java
src/test/java/hudson/plugins/emailext/plugins/CssInlinerTest.java
src/test/java/hudson/plugins/emailext/plugins/content/JellyScriptContentTest.java
src/test/java/hudson/plugins/emailext/plugins/content/ScriptContentChangeLogSet.java
src/test/java/hudson/plugins/emailext/plugins/content/ScriptContentTest.java
src/test/java/hudson/plugins/emailext/plugins/recipients/MockUtilities.java
src/test/resources/recipient-provider-upgrade2.xml
http://jenkins-ci.org/commit/email-ext-plugin/bb0053d79fec59f34d3014117883282d6c2239dc
Log:
Fix ~~JENKINS-18567~~, ~~JENKINS-25926~~ and ~~JENKINS-25719~~

Added ability for users to watch a job.
Fixup the html content coming from CssInliner
Remove adminAddress field for global config

SCM/JIRA link daemon added a comment - 2015-01-16 02:54 Code changed in jenkins User: Alex Earl Path: pom.xml src/main/java/hudson/plugins/emailext/AttachmentUtils.java src/main/java/hudson/plugins/emailext/EmailExtTemplateAction.java src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java src/main/java/hudson/plugins/emailext/plugins/CssInliner.java src/main/java/hudson/plugins/emailext/plugins/EmailTrigger.java src/main/java/hudson/plugins/emailext/plugins/EmailTriggerDescriptor.java src/main/java/hudson/plugins/emailext/plugins/trigger/AbstractScriptTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/PreBuildScriptTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/ScriptTrigger.java src/main/java/hudson/plugins/emailext/watching/EmailExtWatchAction.java src/main/java/hudson/plugins/emailext/watching/EmailExtWatchJobProperty.java src/main/resources/hudson/plugins/emailext/EmailExtTemplateAction/action.groovy src/main/resources/hudson/plugins/emailext/EmailExtTemplateAction/action.jelly src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy src/main/resources/hudson/plugins/emailext/Messages.properties src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/help-triggers.html src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/help-triggers_ja.html src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/help-triggers_zh_TW.html src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/index.groovy src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/index.properties src/main/resources/hudson/plugins/emailext/watching/EmailExtWatchAction/jobMain.groovy src/main/webapp/help/globalConfig/watching.html src/test/java/hudson/plugins/emailext/EmailTypeTest.java src/test/java/hudson/plugins/emailext/plugins/CssInlinerTest.java src/test/java/hudson/plugins/emailext/plugins/content/JellyScriptContentTest.java src/test/java/hudson/plugins/emailext/plugins/content/ScriptContentChangeLogSet.java src/test/java/hudson/plugins/emailext/plugins/content/ScriptContentTest.java src/test/java/hudson/plugins/emailext/plugins/recipients/MockUtilities.java src/test/resources/recipient-provider-upgrade2.xml http://jenkins-ci.org/commit/email-ext-plugin/bb0053d79fec59f34d3014117883282d6c2239dc Log: Fix JENKINS-18567 , JENKINS-25926 and JENKINS-25719 Added ability for users to watch a job. Fixup the html content coming from CssInliner Remove adminAddress field for global config

Alex Earl made changes - 2015-01-28 12:43

Link

New: This issue is duplicated by ~~JENKINS-26648~~ [ ~~JENKINS-26648~~ ]

Assignee:: Alex Earl

Reporter:: Raphaël UNIQUE

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 2014-11-20 21:35

Updated:: 2016-06-14 09:50

Resolved:: 2014-11-29 22:10

Jenkins

Details

Description

Attachments

Attachments

Issue Links

Activity

Collapse comment: Alex Earl added a comment - 2014-11-20 21:42, Edited by Alex Earl - 2014-11-20 21:44

Expand comment: Alex Earl added a comment - 2014-11-20 21:42, Edited by Alex Earl - 2014-11-20 21:44

Collapse comment: Alex Earl added a comment - 2014-11-29 22:10

Expand comment: Alex Earl added a comment - 2014-11-29 22:10

Collapse comment: SCM/JIRA link daemon added a comment - 2015-01-16 02:54

Expand comment: SCM/JIRA link daemon added a comment - 2015-01-16 02:54

People

Dates