Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2580

"Email Notification" action does not work as a Promotion plugin action

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • mailer-plugin
    • None
    • Platform: All, OS: All

      If you configure "E-mail Notification" as an action for a promotion it does not
      actually occur when the promotion occurs.

      Cause: Mailer extends Publisher extends BuildStepCompatibilityLayer without
      overriding BuildStepCompatibilityLayer's version of perform(AbstractBuild...)
      therefore perform() does nothing except return true.

      Fix: Override the new perform signature in Mailer.

      Getting this to work involved removing a whole swag of pointless generics in
      MailSender which doesn't actually care about the specific type of AbstractBuild
      or AbstractProject so wildcards can be used, simplifying things quite a lot.

        1. promotion_action_mailer.patch
          9 kB

          [JENKINS-2580] "Email Notification" action does not work as a Promotion plugin action

          brucechapman created issue -
          brucechapman made changes -
          Link New: This issue is blocking JENKINS-2576 [ JENKINS-2576 ]
          brucechapman made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Andrew Bayer made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]
          Jenkins IRC Bot made changes -
          Component/s New: mailer [ 17522 ]
          Component/s Original: mail [ 15493 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 132653 ] New: JNJira + In-Review [ 201565 ]

            Unassigned Unassigned
            brucechapman brucechapman
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: