Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25938

Lock an Executor without creating a Thread

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Currently WorkflowRun.waitForCompletion spins on a thread just so it can hold a (flyweight) Executor open. Similarly, ExecutorStepExecution.PlaceholderTask spins just to hold a (heavyweight) Executor open. These are wasteful. There should be an optional Task or Executable interface that can run asynchronously, without literally consuming a native Thread for each one.

        Attachments

          Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-34450 Deadlock between Executor and AsynchronousExecution

          • Major - Major loss of function.
          • Open
          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-28182 Revisit use of $JENKINS_SERVER_COOKIE and Launcher.kill

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-26098 Asynch Queue.Executable

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is related to

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-22941 Way to mark an Executable that should not block isReadyToRestart

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-26900 Hide flyweight master executor when ≥1 heavyweight executors running as subtasks

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link PR 1610

            Activity

            Ascending order - Click to sort in descending order
            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is duplicated by JENKINS-26098 [ JENKINS-26098 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-26900 [ JENKINS-26900 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-22941 [ JENKINS-22941 ]
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "PR 1610 (Web Link)" [ 12169 ]
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/AbstractBuild.java
            core/src/main/java/hudson/model/Computer.java
            core/src/main/java/hudson/model/Executor.java
            core/src/main/java/hudson/model/OneOffExecutor.java
            core/src/main/java/hudson/model/Queue.java
            core/src/main/java/hudson/model/ResourceController.java
            core/src/main/java/hudson/model/queue/WorkUnitContext.java
            core/src/main/java/jenkins/model/queue/Executable2.java
            http://jenkins-ci.org/commit/jenkins/46a900f4cb468853c5dca844d258b5b862c3a8bf
            Log:
            JENKINS-25938 Introduced AsynchronousExecutable.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/model/Executor.java core/src/main/java/hudson/model/OneOffExecutor.java core/src/main/java/hudson/model/Queue.java core/src/main/java/hudson/model/ResourceController.java core/src/main/java/hudson/model/queue/WorkUnitContext.java core/src/main/java/jenkins/model/queue/Executable2.java http://jenkins-ci.org/commit/jenkins/46a900f4cb468853c5dca844d258b5b862c3a8bf Log: JENKINS-25938 Introduced AsynchronousExecutable.
            jglick Jesse Glick made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            Hide
            Permalink
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4029
            JENKINS-25938 Introduced AsynchronousExecutable. (Revision 46a900f4cb468853c5dca844d258b5b862c3a8bf)

            Result = SUCCESS
            jesse glick : 46a900f4cb468853c5dca844d258b5b862c3a8bf
            Files :

            • core/src/main/java/hudson/model/OneOffExecutor.java
            • core/src/main/java/hudson/model/Queue.java
            • core/src/main/java/hudson/model/Executor.java
            • core/src/main/java/hudson/model/AbstractBuild.java
            • core/src/main/java/hudson/model/Computer.java
            • core/src/main/java/jenkins/model/queue/Executable2.java
            • core/src/main/java/hudson/model/ResourceController.java
            • core/src/main/java/hudson/model/queue/WorkUnitContext.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4029 JENKINS-25938 Introduced AsynchronousExecutable. (Revision 46a900f4cb468853c5dca844d258b5b862c3a8bf) Result = SUCCESS jesse glick : 46a900f4cb468853c5dca844d258b5b862c3a8bf Files : core/src/main/java/hudson/model/OneOffExecutor.java core/src/main/java/hudson/model/Queue.java core/src/main/java/hudson/model/Executor.java core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/Computer.java core/src/main/java/jenkins/model/queue/Executable2.java core/src/main/java/hudson/model/ResourceController.java core/src/main/java/hudson/model/queue/WorkUnitContext.java
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/46dc6850edb1d7ef52592794b15e69db7dfbed1a
            Log:
            Noting merges

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: changelog.html http://jenkins-ci.org/commit/jenkins/46dc6850edb1d7ef52592794b15e69db7dfbed1a Log: Noting merges JENKINS-15355 JENKINS-21618 JENKINS-22941 JENKINS-25938 JENKINS-26391 JENKINS-26900 JENKINS-27476 JENKINS-27563 JENKINS-27564 JENKINS-27565 JENKINS-27566 Fixing link text for JENKINS-6167
            imakowski Ireneusz Makowski made changes -
            Labels api executor performance threads workflow api executor lts-candidate performance threads workflow
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
            job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java
            http://jenkins-ci.org/commit/workflow-plugin/ee2ca390e73004b411e133c1832b88e977b47f28
            Log:
            JENKINS-25938 Starting to use AsynchronousExecutable.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java http://jenkins-ci.org/commit/workflow-plugin/ee2ca390e73004b411e133c1832b88e977b47f28 Log: JENKINS-25938 Starting to use AsynchronousExecutable.
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-28182 [ JENKINS-28182 ]
            danielbeck Daniel Beck made changes -
            Labels api executor lts-candidate performance threads workflow api executor performance threads workflow
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/89032eb815863a7008a21ad6d545e33eb77160cc
            Log:
            JENKINS-25938 Starting to use AsynchronousExecutable.
            Originally-Committed-As: ee2ca390e73004b411e133c1832b88e977b47f28

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/89032eb815863a7008a21ad6d545e33eb77160cc Log: JENKINS-25938 Starting to use AsynchronousExecutable. Originally-Committed-As: ee2ca390e73004b411e133c1832b88e977b47f28
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            http://jenkins-ci.org/commit/workflow-job-plugin/149188bc42f2cab01ea9efc54774dfdfb213f068
            Log:
            JENKINS-25938 Starting to use AsynchronousExecutable.
            Originally-Committed-As: ee2ca390e73004b411e133c1832b88e977b47f28

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/149188bc42f2cab01ea9efc54774dfdfb213f068 Log: JENKINS-25938 Starting to use AsynchronousExecutable. Originally-Committed-As: ee2ca390e73004b411e133c1832b88e977b47f28
            jglick Jesse Glick made changes -
            Link This issue depends on JENKINS-34450 [ JENKINS-34450 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 159926 ] JNJira + In-Review [ 196248 ]
            abayer Andrew Bayer made changes -
            Labels api executor performance threads workflow api executor performance pipeline threads workflow
            abayer Andrew Bayer made changes -
            Labels api executor performance pipeline threads workflow api executor performance pipeline threads

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: