amuniz says:

The plugin codebase (on master) is not compiling with core baseline 1.480.1 (minimum required by Workflow). As a first step we have to make it compatible with the required core baseline.

Compilation issue related with public interface FileCallable<T> extends Serializable, RoleSensitive extending RoleSensitive which requires an implementation of void checkRoles(RoleChecker checker).

Resolving this compilation issues seems simple, just add the missing method, but I guess this could impact in the general runtime behavior of this plugin.

Documentation: http://documentation.cloudbees.com/docs/dev-at-cloud/CloudBees+Deployer+Plugin+for+Continuous+Deployment.html

Perhaps outdated.

Finally, it seems that we don't have to change anything in cloudbees-deployer but in deployer-framework.

tfennelly says:

Tasks:

1. (1d) AbstractProject to Job etc in deployer-framework-plugin
   • Current understanding is that we do not need to modify the cloudbees-deployer plugin
2. (1d) Fix tests
3. (1d) Automated tests specific to workflow
4. (1d) Resolve TODOs, if any
5. (1d) Backward Compatibility review (lots of method signatures have changed)
6. (4h) Create and manage PR
7. (4h) Release plugin
   • Release binaries
   • Docs (wiki etc)

Discussed with svanoort briefly about need to confirm acceptance criteria, here is a start:

1. Fix tests and add Pipeline tests 
2. Update plugin version to 2.0+, fix findbugs and any javadoc errors
3. Refactor to work with pipeline APIs
4. Create pipeline Step that is configurable from pipeline
5. Write unit tests that confirm new functionality
6. Manually test that .war deploys from pipeline (preferably both Tomcat and Glassfish)

I'm proposing the following syntax, I think this provides a reasonably straightforward use and config.

node { 
    def tc8 = tomcat8( 
        url:        'http://localhost:1234/app',
        password:   '******', 
        userName:   'admin'
    )
    deploy(container: tc8, war: '/target/app.war', contextPath: '/app')   
    deploy(containers: [tc8, gf3], war: '/target/app.war', contextPath: '/app')
}

I've already started addressing some of these in PR25 and PR26. 

alexbrjo Looks like a solid start – I'd add including a Dummy deploy implementation (at least) that verifies the step can run in pipeline, and at least a manual test that deployment runs cleanly in pipeline, preferably an automated one if it can be easily done (if not trivial, then manual would be okay).