Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26121

Input step should maintain audit record

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • pipeline

      Should save something to the build record saying who approved (or rejected) it, such as an Action which is an @ExportedBean.

          [JENKINS-26121] Input step should maintain audit record

          Jesse Glick created issue -
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 47 (Web Link)" [ 12115 ]
          Jesse Glick made changes -
          Assignee Original: Jesse Glick [ jglick ] New: valentina armenise [ varmenise ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Valentina Armenise
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.jelly
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.properties
          http://jenkins-ci.org/commit/workflow-plugin/36571033f4ec39bd107cd492875607b7f59e1237
          Log:
          JENKINS-26121 - Approver Logged

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Valentina Armenise Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.jelly support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.properties http://jenkins-ci.org/commit/workflow-plugin/36571033f4ec39bd107cd492875607b7f59e1237 Log: JENKINS-26121 - Approver Logged

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.jelly
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.properties
          http://jenkins-ci.org/commit/workflow-plugin/f88042c300e8639dc8e51fa38f989e94638c4ec1
          Log:
          Merge pull request #47 from varmenise/JENKINS-26121

          JENKINS-26121 Approver Logged

          Compare: https://github.com/jenkinsci/workflow-plugin/compare/a5c5bf6fee6a...f88042c300e8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.jelly support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.properties http://jenkins-ci.org/commit/workflow-plugin/f88042c300e8639dc8e51fa38f989e94638c4ec1 Log: Merge pull request #47 from varmenise/ JENKINS-26121 JENKINS-26121 Approver Logged Compare: https://github.com/jenkinsci/workflow-plugin/compare/a5c5bf6fee6a...f88042c300e8
          Jesse Glick made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          CHANGES.md
          http://jenkins-ci.org/commit/workflow-plugin/f2593795afcbf9908f52adca694f4c58b2387b5b
          Log:
          JENKINS-26121 Noting merge of #47.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md http://jenkins-ci.org/commit/workflow-plugin/f2593795afcbf9908f52adca694f4c58b2387b5b Log: JENKINS-26121 Noting merge of #47.
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-27228 [ JENKINS-27228 ]

          J Knurek added a comment -

          From the PR https://github.com/jenkinsci/workflow-plugin/pull/47/files
          it doesn't appear that this change logs the user who "rejected" the step

          J Knurek added a comment - From the PR https://github.com/jenkinsci/workflow-plugin/pull/47/files it doesn't appear that this change logs the user who "rejected" the step

            varmenise valentina armenise
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: