• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      This could be lifted up into ParameterizedJob. That would enable an AlternativeUiTextProvider to supply an alternate Build Now text for workflows.

      PRONOUN is already in AbstractItem so this is fine.

          [JENKINS-26147] Lift up AbstractProject.BUILD_NOW_TEXT

          Jesse Glick created issue -
          Jesse Glick made changes -
          Labels Original: workflow New: api workflow
          Oleg Nenashev made changes -
          Assignee New: Oleg Nenashev [ oleg_nenashev ]

          Oleg Nenashev added a comment -

          I've taken the issue

          Oleg Nenashev added a comment - I've taken the issue
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Oleg Nenashev added a comment -

          After digging into the code I'd disagree with the propagation to AbstractItem.
          Not all items are buildable, to this text belongs to BuildableItem instead of AbstractItem.

          BTW, my god-feeling is that something is misdesigned in AlternativeUiTextProvider extensions engine. AlternativeUiTextProvider.Message is tasty, but it's non-object context becomes a PITA for migrations of such kind

          Oleg Nenashev added a comment - After digging into the code I'd disagree with the propagation to AbstractItem. Not all items are buildable, to this text belongs to BuildableItem instead of AbstractItem. BTW, my god-feeling is that something is misdesigned in AlternativeUiTextProvider extensions engine. AlternativeUiTextProvider.Message is tasty, but it's non-object context becomes a PITA for migrations of such kind
          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-29396 [ JENKINS-29396 ]

          Jesse Glick added a comment -

          Should be in ParameterizedJobMixIn.

          Jesse Glick added a comment - Should be in ParameterizedJobMixIn .
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]

          Jesse Glick added a comment -

          Correct me if I am wrong, but I see no ongoing work to implement this RFE itself. Do you want me to take it? Needs to be done soon if it is going to get into the next LTS.

          Jesse Glick added a comment - Correct me if I am wrong, but I see no ongoing work to implement this RFE itself. Do you want me to take it? Needs to be done soon if it is going to get into the next LTS.

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: