Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26148

Incorrect implementation of RetryStepExecution.stop

XMLWordPrintable

      https://github.com/jenkinsci/workflow-plugin/commit/6be3d810597079905b6d19911bd40139ee4ec0eb purported to let stop kill its body. Yet this implementation can only work for the first round. For the second and subsequent rounds, the BodyExecution created by Callback.onFailure is thrown away, and body will still be the first one, which will presumably cause CpsBodyExecution.cancel to be a no-op since isDone().

      So somehow the Callback needs to get a handle back to its RetryStepExecution. But how? You could use StepExecution.applyAll to find all the candidates, but how would you select the right one if there are several? ExecutorStepExecution.Callback overloads cookie for this purpose, but that is used also for ProcessKiller; it seems like a hack here. ParallelStep uses ResultHandler, apparently assuming that identical objects are linked in the reference graph during serialization.

          [JENKINS-26148] Incorrect implementation of RetryStepExecution.stop

          Jesse Glick added a comment -

          waitForCond would have the same issue.

          Jesse Glick added a comment - waitForCond would have the same issue.

          Jesse Glick added a comment -

          Just realized that CpsFlowExecution.interrupt only calls stop on getCurrentExecutions, which by its Javadoc only includes innermost executions. And this makes sense to me: it is only necessary to interrupt the stuff that is actually running, and if that throws up a FlowInterruptedException, then BodyExecutionCallback.onFailure should be called and the outer step should fail too.

          If that is right, then the current stop method is totally wrong: it should not call cancel on anything, and in fact it should be a no-op because it should never be called. (Or if it is called, it would be as a race condition between retries, meaning all it needs to do is immediately getContext().onFailure(cause).) But then Callback.onFailure needs to check for t instanceof InterruptedException and throw that up without retrying. And other stop methods on block-scoped steps are probably incorrect too.

          The correct handling of interruption by steps remains very unclear to me. There needs to be a definitive document explaining how interruption works and what steps are supposed to do in order to participate properly. And we need tests that actually trying interrupting flows at various points.

          Jesse Glick added a comment - Just realized that CpsFlowExecution.interrupt only calls stop on getCurrentExecutions , which by its Javadoc only includes innermost executions. And this makes sense to me: it is only necessary to interrupt the stuff that is actually running, and if that throws up a FlowInterruptedException , then BodyExecutionCallback.onFailure should be called and the outer step should fail too. If that is right, then the current stop method is totally wrong: it should not call cancel on anything, and in fact it should be a no-op because it should never be called. (Or if it is called, it would be as a race condition between retries, meaning all it needs to do is immediately getContext().onFailure(cause) .) But then Callback.onFailure needs to check for t instanceof InterruptedException and throw that up without retrying. And other stop methods on block-scoped steps are probably incorrect too. The correct handling of interruption by steps remains very unclear to me. There needs to be a definitive document explaining how interruption works and what steps are supposed to do in order to participate properly. And we need tests that actually trying interrupting flows at various points.

          Jesse Glick added a comment -

          WaitForConditionStep seems to at least not be buggy, though the code style may be overly complicated. body is updated whenever the block is rerun. stop behaves properly when there is no active body; when there is an active body, it tries to interrupt it, even though stop would not be called in this case. Probably the body field could simply be removed without loss of functionality.

          It also does some tricks with a random id and StepExecution.applyAll which are probably unnecessary; Callback could simply keep a reference to the Execution that owns it. This would not be a compatible change for running build records, though.

          Jesse Glick added a comment - WaitForConditionStep seems to at least not be buggy, though the code style may be overly complicated. body is updated whenever the block is rerun. stop behaves properly when there is no active body; when there is an active body, it tries to interrupt it, even though stop would not be called in this case. Probably the body field could simply be removed without loss of functionality. It also does some tricks with a random id and StepExecution.applyAll which are probably unnecessary; Callback could simply keep a reference to the Execution that owns it. This would not be a compatible change for running build records, though.

          Jesse Glick added a comment -

          Seems that the bogus overrides of stop are useful as a workaround for JENKINS-34637: CpsBodyExecution.getCurrentExecutions disobeys its contract (it returns just the first step running, not the innermost steps), and cancel suffers from the same problem.

          When that is fixed, I think it would be best for StepExecution.stop to have a default implementation—getContext().onFailure(cause)—and for most of the overrides to be deleted, leaving only those which actually do something before, after, or between body invocations.

          Jesse Glick added a comment - Seems that the bogus overrides of stop are useful as a workaround for JENKINS-34637 : CpsBodyExecution.getCurrentExecutions disobeys its contract (it returns just the first step running, not the innermost steps), and cancel suffers from the same problem. When that is fixed, I think it would be best for StepExecution.stop to have a default implementation— getContext().onFailure(cause) —and for most of the overrides to be deleted, leaving only those which actually do something before, after, or between body invocations.

          Jesse Glick added a comment -

          Similarly, there is no apparent reason for ParallelStepExecution.bodies to exist except to pass on failures in stop.

          Jesse Glick added a comment - Similarly, there is no apparent reason for ParallelStepExecution.bodies to exist except to pass on failures in stop .

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/org/jenkinsci/plugins/workflow/cps/CpsStepContext.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/38e8206153b3497fec5c6f9a2880779ea2bd3cc9
          Log:
          JENKINS-26148 Be quiet in the case a block step is receiving a failure from its own body.
          Happens when stop() is implemented to call getContext().onFailure(cause), and something incorrectly calls stop on a non-innermost execution.
          Also providing much better diagnostics in other cases where a step seems to be completing twice.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/cps/CpsStepContext.java http://jenkins-ci.org/commit/workflow-cps-plugin/38e8206153b3497fec5c6f9a2880779ea2bd3cc9 Log: JENKINS-26148 Be quiet in the case a block step is receiving a failure from its own body. Happens when stop() is implemented to call getContext().onFailure(cause), and something incorrectly calls stop on a non-innermost execution. Also providing much better diagnostics in other cases where a step seems to be completing twice.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecution.java
          src/main/java/org/jenkinsci/plugins/workflow/cps/CpsStepContext.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecutionTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/6933a4925a47b07206eaf059484b37c069aebe62
          Log:
          [FIXED JENKINS-34637] CpsBodyExecution.cancel was failing to interrupt the innermost execution, and block-scoped StepExecution.stop does not generally kill its body (JENKINS-26148).
          getCurrentExecutions was also in direct violation of its Javadoc, though it does not appear to have ever been called, much less tested.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecution.java src/main/java/org/jenkinsci/plugins/workflow/cps/CpsStepContext.java src/test/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecutionTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/6933a4925a47b07206eaf059484b37c069aebe62 Log: [FIXED JENKINS-34637] CpsBodyExecution.cancel was failing to interrupt the innermost execution, and block-scoped StepExecution.stop does not generally kill its body ( JENKINS-26148 ). getCurrentExecutions was also in direct violation of its Javadoc, though it does not appear to have ever been called, much less tested.

          Andrew Bayer added a comment -

          Is this still relevant?

          Andrew Bayer added a comment - Is this still relevant?

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/cps/steps/LoadStepExecution.java
          src/main/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStepExecution.java
          src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java
          src/test/java/org/jenkinsci/plugins/workflow/SerializationTest.java
          src/test/java/org/jenkinsci/plugins/workflow/SubtypeInjectingStepExecution.java
          src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecutionTest.java
          src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/CurveMetaStep.java
          src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/eb266124429ec995799debf0b296683392d3c6b9
          Log:
          JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/steps/LoadStepExecution.java src/main/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStepExecution.java src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java src/test/java/org/jenkinsci/plugins/workflow/SerializationTest.java src/test/java/org/jenkinsci/plugins/workflow/SubtypeInjectingStepExecution.java src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java src/test/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecutionTest.java src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/CurveMetaStep.java src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java http://jenkins-ci.org/commit/workflow-cps-plugin/eb266124429ec995799debf0b296683392d3c6b9 Log: JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/cps/steps/LoadStepExecution.java
          src/main/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStepExecution.java
          src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java
          src/test/java/org/jenkinsci/plugins/workflow/SerializationTest.java
          src/test/java/org/jenkinsci/plugins/workflow/SubtypeInjectingStepExecution.java
          src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecutionTest.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStepTest.java
          src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/CurveMetaStep.java
          src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/aa4c4e78ecf7628b754ac34674c04caf88ae4b88
          Log:
          Merge pull request #171 from jglick/StepExecution.stop-JENKINS-26148

          JENKINS-26148 Using default implementation of StepExecution.stop

          Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/1988c8facacd...aa4c4e78ecf7

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/steps/LoadStepExecution.java src/main/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStepExecution.java src/test/java/org/jenkinsci/plugins/workflow/DynamicEnvironmentExpanderTest.java src/test/java/org/jenkinsci/plugins/workflow/SerializationTest.java src/test/java/org/jenkinsci/plugins/workflow/SubtypeInjectingStepExecution.java src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java src/test/java/org/jenkinsci/plugins/workflow/cps/CpsBodyExecutionTest.java src/test/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStepTest.java src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/CurveMetaStep.java src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java http://jenkins-ci.org/commit/workflow-cps-plugin/aa4c4e78ecf7628b754ac34674c04caf88ae4b88 Log: Merge pull request #171 from jglick/StepExecution.stop- JENKINS-26148 JENKINS-26148 Using default implementation of StepExecution.stop Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/1988c8facacd...aa4c4e78ecf7

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/ScriptStep.java
          pom.xml
          http://jenkins-ci.org/commit/pipeline-model-definition-plugin/4092168c603a0ec8530de8e8e40611eeda626ca5
          Log:
          JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/ScriptStep.java pom.xml http://jenkins-ci.org/commit/pipeline-model-definition-plugin/4092168c603a0ec8530de8e8e40611eeda626ca5 Log: JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/ScriptStep.java
          pom.xml
          http://jenkins-ci.org/commit/pipeline-model-definition-plugin/5c2b7d11bcd123e17e33fa5d275505bfad80a487
          Log:
          Merge pull request #191 from jglick/StepExecution.stop-JENKINS-26148

          JENKINS-26148 Using default implementation of StepExecution.stop

          Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/2a35f4597f08...5c2b7d11bcd1

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/ScriptStep.java pom.xml http://jenkins-ci.org/commit/pipeline-model-definition-plugin/5c2b7d11bcd123e17e33fa5d275505bfad80a487 Log: Merge pull request #191 from jglick/StepExecution.stop- JENKINS-26148 JENKINS-26148 Using default implementation of StepExecution.stop Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/2a35f4597f08...5c2b7d11bcd1

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/workflow/support/actions/LogActionImplTest.java
          src/test/java/org/jenkinsci/plugins/workflow/test/steps/BlockSemaphoreStep.java
          src/test/java/org/jenkinsci/plugins/workflow/test/steps/SemaphoreStep.java
          http://jenkins-ci.org/commit/workflow-support-plugin/139b1e9a0f03fc76c281c80915b16d695e56ff46
          Log:
          JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/support/actions/LogActionImplTest.java src/test/java/org/jenkinsci/plugins/workflow/test/steps/BlockSemaphoreStep.java src/test/java/org/jenkinsci/plugins/workflow/test/steps/SemaphoreStep.java http://jenkins-ci.org/commit/workflow-support-plugin/139b1e9a0f03fc76c281c80915b16d695e56ff46 Log: JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/workflow/support/actions/LogActionImplTest.java
          src/test/java/org/jenkinsci/plugins/workflow/test/steps/BlockSemaphoreStep.java
          src/test/java/org/jenkinsci/plugins/workflow/test/steps/SemaphoreStep.java
          http://jenkins-ci.org/commit/workflow-support-plugin/26d05449b5816f5f360221e3ca9ab871c8d3f912
          Log:
          Merge pull request #44 from jglick/StepExecution.stop-JENKINS-26148

          JENKINS-26148 Using default implementation of StepExecution.stop

          Compare: https://github.com/jenkinsci/workflow-support-plugin/compare/8637c4c8b12f...26d05449b581

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/support/actions/LogActionImplTest.java src/test/java/org/jenkinsci/plugins/workflow/test/steps/BlockSemaphoreStep.java src/test/java/org/jenkinsci/plugins/workflow/test/steps/SemaphoreStep.java http://jenkins-ci.org/commit/workflow-support-plugin/26d05449b5816f5f360221e3ca9ab871c8d3f912 Log: Merge pull request #44 from jglick/StepExecution.stop- JENKINS-26148 JENKINS-26148 Using default implementation of StepExecution.stop Compare: https://github.com/jenkinsci/workflow-support-plugin/compare/8637c4c8b12f...26d05449b581

          Jesse Glick added a comment -

          Still four open PRs by my count.

          Jesse Glick added a comment - Still four open PRs by my count.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/steps/CatchErrorStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/CoreWrapperStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/EnvStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/PushdStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/SleepStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepExecution.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/WaitForConditionStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/WithContextStep.java
          http://jenkins-ci.org/commit/workflow-basic-steps-plugin/906497e661b67c7a18a65c43ffd526f4dd7a5938
          Log:
          JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/steps/CatchErrorStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/CoreWrapperStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/EnvStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/PushdStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java src/main/java/org/jenkinsci/plugins/workflow/steps/SleepStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepExecution.java src/main/java/org/jenkinsci/plugins/workflow/steps/WaitForConditionStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/WithContextStep.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/906497e661b67c7a18a65c43ffd526f4dd7a5938 Log: JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/steps/CatchErrorStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/CoreWrapperStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/EnvStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/PushdStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/SleepStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepExecution.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/WaitForConditionStep.java
          src/main/java/org/jenkinsci/plugins/workflow/steps/WithContextStep.java
          http://jenkins-ci.org/commit/workflow-basic-steps-plugin/1b1342da938666b4070f83f20f10d79b6d90ba51
          Log:
          Merge pull request #50 from jglick/StepExecution.stop-JENKINS-26148

          JENKINS-26148 Using default implementation of StepExecution.stop

          Compare: https://github.com/jenkinsci/workflow-basic-steps-plugin/compare/2a031297c8bb...1b1342da9386

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/steps/CatchErrorStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/CoreWrapperStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/EnvStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/PushdStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java src/main/java/org/jenkinsci/plugins/workflow/steps/SleepStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepExecution.java src/main/java/org/jenkinsci/plugins/workflow/steps/WaitForConditionStep.java src/main/java/org/jenkinsci/plugins/workflow/steps/WithContextStep.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/1b1342da938666b4070f83f20f10d79b6d90ba51 Log: Merge pull request #50 from jglick/StepExecution.stop- JENKINS-26148 JENKINS-26148 Using default implementation of StepExecution.stop Compare: https://github.com/jenkinsci/workflow-basic-steps-plugin/compare/2a031297c8bb...1b1342da9386

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java
          http://jenkins-ci.org/commit/pipeline-build-step-plugin/a7248f0db9b281df4551c4521e529c6d2d5437a5
          Log:
          JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java http://jenkins-ci.org/commit/pipeline-build-step-plugin/a7248f0db9b281df4551c4521e529c6d2d5437a5 Log: JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java
          http://jenkins-ci.org/commit/pipeline-build-step-plugin/3ff14391fe27c8ee9ccea9ba1977131fe3b26dbe
          Log:
          Merge pull request #15 from jglick/StepExecution.stop-JENKINS-26148

          JENKINS-26148 Using default implementation of StepExecution.stop

          Compare: https://github.com/jenkinsci/pipeline-build-step-plugin/compare/269bccee2654...3ff14391fe27

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java http://jenkins-ci.org/commit/pipeline-build-step-plugin/3ff14391fe27c8ee9ccea9ba1977131fe3b26dbe Log: Merge pull request #15 from jglick/StepExecution.stop- JENKINS-26148 JENKINS-26148 Using default implementation of StepExecution.stop Compare: https://github.com/jenkinsci/pipeline-build-step-plugin/compare/269bccee2654...3ff14391fe27

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/support/steps/StageStepExecution.java
          http://jenkins-ci.org/commit/pipeline-stage-step-plugin/f2f9f7d6096af3c6b53971a549b214032bd833f0
          Log:
          JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/support/steps/StageStepExecution.java http://jenkins-ci.org/commit/pipeline-stage-step-plugin/f2f9f7d6096af3c6b53971a549b214032bd833f0 Log: JENKINS-26148 Using default implementation of StepExecution.stop.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/support/steps/StageStepExecution.java
          http://jenkins-ci.org/commit/pipeline-stage-step-plugin/addb287b9d5b81f3d4ab3b15fb6dd33e7370062a
          Log:
          Merge pull request #12 from jglick/StepExecution.stop-JENKINS-26148

          JENKINS-26148 Using default implementation of StepExecution.stop

          Compare: https://github.com/jenkinsci/pipeline-stage-step-plugin/compare/d19fefc1433e...addb287b9d5b

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/support/steps/StageStepExecution.java http://jenkins-ci.org/commit/pipeline-stage-step-plugin/addb287b9d5b81f3d4ab3b15fb6dd33e7370062a Log: Merge pull request #12 from jglick/StepExecution.stop- JENKINS-26148 JENKINS-26148 Using default implementation of StepExecution.stop Compare: https://github.com/jenkinsci/pipeline-stage-step-plugin/compare/d19fefc1433e...addb287b9d5b

          Sam Van Oort added a comment -

          jglick I think we got all the parts released here, right?

          Sam Van Oort added a comment - jglick I think we got all the parts released here, right?

          Jesse Glick added a comment -

          Looks that way. Thanks for noticing!

          Jesse Glick added a comment - Looks that way. Thanks for noticing!

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: