Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26186

Last Build Trigger Column does not print author name

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Last Build Trigger Column does not print author name in the trigger column as shown in the plugin webpage. Attached screenshot.

        Attachments

          Issue Links

            Activity

            Hide
            jijohn J John added a comment -

            Any update?

            Show
            jijohn J John added a comment - Any update?
            Hide
            batmat Baptiste Mathus added a comment -

            Hi, just had a look. If you put your mouse over the icon, the title is there.
            Indeed, the text seems to be not there anymore (I didn't see since I don't personally use that very feature).

            Could you tell us a plugin version where it was working, and one when it didn't work anymore? That'd help investigate.

            Even better, file a Pull Request, I promise I'll have look.

            HTH

            Show
            batmat Baptiste Mathus added a comment - Hi, just had a look. If you put your mouse over the icon, the title is there. Indeed, the text seems to be not there anymore (I didn't see since I don't personally use that very feature). Could you tell us a plugin version where it was working, and one when it didn't work anymore? That'd help investigate. Even better, file a Pull Request, I promise I'll have look. HTH
            Hide
            batmat Baptiste Mathus added a comment -

            Issue reproduced with current version & Jenkins 1.509.4.
            Wondering since when it doesn't work.

            Show
            batmat Baptiste Mathus added a comment - Issue reproduced with current version & Jenkins 1.509.4. Wondering since when it doesn't work.
            Hide
            jijohn J John added a comment -

            Can we have the name appear in the trend column as well. Personally, I like seeing the name vs user icon. For rest, icon looks good.

            Show
            jijohn J John added a comment - Can we have the name appear in the trend column as well. Personally, I like seeing the name vs user icon. For rest, icon looks good.
            Hide
            batmat Baptiste Mathus added a comment -

            Just did a git bisect, and indeed the UI was showing the text at some point :

            $ git bisect log
            git bisect start

            1. bad: [8d31cf754fa4cee0aa905bf9d76315dcd354cafe] [maven-release-plugin] prepare for next development iteration
              git bisect bad 8d31cf754fa4cee0aa905bf9d76315dcd354cafe
            2. good: [4c7adb587fd0d0393d9725844ba258ac7c52bed0] Add column showing icon for last build cause
              git bisect good 4c7adb587fd0d0393d9725844ba258ac7c52bed0
            3. good: [4c7adb587fd0d0393d9725844ba258ac7c52bed0] Add column showing icon for last build cause
              git bisect good 4c7adb587fd0d0393d9725844ba258ac7c52bed0
            4. bad: [4efe343c3a1ef22263022bfa117f6444daa6eb10] Merge pull request #9 from imod/githookcause
              git bisect bad 4efe343c3a1ef22263022bfa117f6444daa6eb10
            5. bad: [4efe343c3a1ef22263022bfa117f6444daa6eb10] Merge pull request #9 from imod/githookcause
              git bisect bad 4efe343c3a1ef22263022bfa117f6444daa6eb10
            6. good: [4f33890d86689641edcb02b4099bf3d04039cbfa] Merge pull request #5 from damienfinck/master
              git bisect good 4f33890d86689641edcb02b4099bf3d04039cbfa
            7. bad: [8b0424d0875c70537cdcf9ea5bd7143928a72faf] Fixing JENKINS-22557
              git bisect bad 8b0424d0875c70537cdcf9ea5bd7143928a72faf
            8. good: [7d35c0f4ab624da60100e8c8b831b019b57b2837] Create README.md
              git bisect good 7d35c0f4ab624da60100e8c8b831b019b57b2837
            9. good: [f46db8784a07efca2da971c5c14028d50a8def4c] Merge pull request #7 from bigcplus/master
              git bisect good f46db8784a07efca2da971c5c14028d50a8def4c
            10. first bad commit: [8b0424d0875c70537cdcf9ea5bd7143928a72faf] Fixing JENKINS-22557
            Show
            batmat Baptiste Mathus added a comment - Just did a git bisect, and indeed the UI was showing the text at some point : $ git bisect log git bisect start bad: [8d31cf754fa4cee0aa905bf9d76315dcd354cafe] [maven-release-plugin] prepare for next development iteration git bisect bad 8d31cf754fa4cee0aa905bf9d76315dcd354cafe good: [4c7adb587fd0d0393d9725844ba258ac7c52bed0] Add column showing icon for last build cause git bisect good 4c7adb587fd0d0393d9725844ba258ac7c52bed0 good: [4c7adb587fd0d0393d9725844ba258ac7c52bed0] Add column showing icon for last build cause git bisect good 4c7adb587fd0d0393d9725844ba258ac7c52bed0 bad: [4efe343c3a1ef22263022bfa117f6444daa6eb10] Merge pull request #9 from imod/githookcause git bisect bad 4efe343c3a1ef22263022bfa117f6444daa6eb10 bad: [4efe343c3a1ef22263022bfa117f6444daa6eb10] Merge pull request #9 from imod/githookcause git bisect bad 4efe343c3a1ef22263022bfa117f6444daa6eb10 good: [4f33890d86689641edcb02b4099bf3d04039cbfa] Merge pull request #5 from damienfinck/master git bisect good 4f33890d86689641edcb02b4099bf3d04039cbfa bad: [8b0424d0875c70537cdcf9ea5bd7143928a72faf] Fixing JENKINS-22557 git bisect bad 8b0424d0875c70537cdcf9ea5bd7143928a72faf good: [7d35c0f4ab624da60100e8c8b831b019b57b2837] Create README.md git bisect good 7d35c0f4ab624da60100e8c8b831b019b57b2837 good: [f46db8784a07efca2da971c5c14028d50a8def4c] Merge pull request #7 from bigcplus/master git bisect good f46db8784a07efca2da971c5c14028d50a8def4c first bad commit: [8b0424d0875c70537cdcf9ea5bd7143928a72faf] Fixing JENKINS-22557
            Hide
            batmat Baptiste Mathus added a comment -

            OK, so the commit is https://github.com/jenkinsci/buildtriggerbadge-plugin/commit/8b0424d0875c70537cdcf9ea5bd7143928a72faf and has indeed been there for almost a year.

            I added the link to the associated JIRA. Actually, the text was somehow moved into the image title instead of added. I've asked my comaintainer to check what we wanted to do at that time to decide what to do next.

            Cheers

            Show
            batmat Baptiste Mathus added a comment - OK, so the commit is https://github.com/jenkinsci/buildtriggerbadge-plugin/commit/8b0424d0875c70537cdcf9ea5bd7143928a72faf and has indeed been there for almost a year. I added the link to the associated JIRA. Actually, the text was somehow moved into the image title instead of added. I've asked my comaintainer to check what we wanted to do at that time to decide what to do next. Cheers
            Hide
            batmat Baptiste Mathus added a comment -

            OK, the intent was indeed actually to only show the icon (like elsewhere). So that makes the current issue no more a bug, but an improvement request.
            For me, it's two fold (from a "product" management perspective): either we just close this bug as wontfix because we want to keep the complexity low, or we add a new column variant named for example 'last build trigger - long version' and reintroduce a column with the old behaviour.

            If we were on a big product, I'd say the first solution may be better. In our case, I suppose the second case is feasible since the codebase is still pretty small. Though we sure want to reuse as much code as possible if we introduce that second column being a 'long' variant of the current one.

            Show
            batmat Baptiste Mathus added a comment - OK, the intent was indeed actually to only show the icon (like elsewhere). So that makes the current issue no more a bug, but an improvement request. For me, it's two fold (from a "product" management perspective): either we just close this bug as wontfix because we want to keep the complexity low, or we add a new column variant named for example 'last build trigger - long version' and reintroduce a column with the old behaviour. If we were on a big product, I'd say the first solution may be better. In our case, I suppose the second case is feasible since the codebase is still pretty small. Though we sure want to reuse as much code as possible if we introduce that second column being a 'long' variant of the current one.
            Hide
            danielbeck Daniel Beck added a comment - - edited

            Columns can have configuration. Why not add a checkbox or dropdown menu to configure column behavior (rather than add two different, but similar columns)?

            Advantages would be that it requires less space in the column selection list in the view configuration, and you can more easily switch from one form to the other.

            Show
            danielbeck Daniel Beck added a comment - - edited Columns can have configuration. Why not add a checkbox or dropdown menu to configure column behavior (rather than add two different, but similar columns)? Advantages would be that it requires less space in the column selection list in the view configuration, and you can more easily switch from one form to the other.
            Hide
            batmat Baptiste Mathus added a comment -

            Additional note: for that new column, to not have the issue that led to JENKINS-22557 we certainly want to limit the max number of characters shown to some hard value, and for example show the full version in a title (if there's more).

            Show
            batmat Baptiste Mathus added a comment - Additional note: for that new column, to not have the issue that led to JENKINS-22557 we certainly want to limit the max number of characters shown to some hard value, and for example show the full version in a title (if there's more).
            Hide
            batmat Baptiste Mathus added a comment -

            Thanks a lot Daniel, I wasn't aware it was possible. So that's obviously what I'm gonna do.
            Thanks again.

            Show
            batmat Baptiste Mathus added a comment - Thanks a lot Daniel, I wasn't aware it was possible. So that's obviously what I'm gonna do. Thanks again.
            Hide
            jijohn J John added a comment -

            Awesome. So, we can look forward to a global and local configuration for the column behavior?

            Show
            jijohn J John added a comment - Awesome. So, we can look forward to a global and local configuration for the column behavior?
            Hide
            batmat Baptiste Mathus added a comment -

            Absolutely. But currently having a hard time to do find the time to do it. So if nobody submits the corresponding pull request (hint! Hint! ), it's likely to take still a few weeks before this can be done.
            Cheers

            Show
            batmat Baptiste Mathus added a comment - Absolutely. But currently having a hard time to do find the time to do it. So if nobody submits the corresponding pull request (hint! Hint! ), it's likely to take still a few weeks before this can be done. Cheers
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Lukasz Jader
            Path:
            src/main/java/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn.java
            src/main/resources/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn/column.jelly
            src/main/resources/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn/config.jelly
            http://jenkins-ci.org/commit/buildtriggerbadge-plugin/94eda6518004133f0f11af0c38ee14d1ad593669
            Log:
            JENKINS-26186 Enable changing display format for Last Build Trigger
            Column

            Users can now pick how to display build Cause in mentioned column,
            since not all users want to see long descriptions.

            By default column will display only icon for build cause.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Lukasz Jader Path: src/main/java/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn.java src/main/resources/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn/column.jelly src/main/resources/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn/config.jelly http://jenkins-ci.org/commit/buildtriggerbadge-plugin/94eda6518004133f0f11af0c38ee14d1ad593669 Log: JENKINS-26186 Enable changing display format for Last Build Trigger Column Users can now pick how to display build Cause in mentioned column, since not all users want to see long descriptions. By default column will display only icon for build cause.
            Hide
            ljader Łukasz Jąder added a comment -

            I've prepared a Pull Request for this issue:
            https://github.com/jenkinsci/buildtriggerbadge-plugin/pull/15

            Show
            ljader Łukasz Jąder added a comment - I've prepared a Pull Request for this issue: https://github.com/jenkinsci/buildtriggerbadge-plugin/pull/15
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Baptiste Mathus
            Path:
            src/main/java/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn.java
            src/main/resources/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn/column.jelly
            src/main/resources/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn/config.jelly
            http://jenkins-ci.org/commit/buildtriggerbadge-plugin/0d0fdb4b22b1bccafb262d82ef88a35fe6537200
            Log:
            Merge pull request #15 from jenkinsci/trigger-column-configurable-display

            JENKINS-26186 Enable changing display format for Last Build Trigger Column

            Compare: https://github.com/jenkinsci/buildtriggerbadge-plugin/compare/40ac15121da4...0d0fdb4b22b1

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: src/main/java/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn.java src/main/resources/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn/column.jelly src/main/resources/org/jenkinsci/plugins/buildtriggerbadge/LastBuildTriggerColumn/config.jelly http://jenkins-ci.org/commit/buildtriggerbadge-plugin/0d0fdb4b22b1bccafb262d82ef88a35fe6537200 Log: Merge pull request #15 from jenkinsci/trigger-column-configurable-display JENKINS-26186 Enable changing display format for Last Build Trigger Column Compare: https://github.com/jenkinsci/buildtriggerbadge-plugin/compare/40ac15121da4...0d0fdb4b22b1
            Hide
            ljader Łukasz Jąder added a comment -

            Fixed wit PR; released with 2.1 version.
            If somone encounters any other issues with this column please report it as a new issue.

            Show
            ljader Łukasz Jąder added a comment - Fixed wit PR; released with 2.1 version. If somone encounters any other issues with this column please report it as a new issue.

              People

              Assignee:
              ljader Łukasz Jąder
              Reporter:
              jijohn J John
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: