• Type: Bug
• Resolution: Fixed
• Priority: Major
• Component/s: gerrit-trigger-plugin, OBSOLETE-gerrit-plugin
• Labels:

  • abort
  • gerrit
  • gerrit-trigger

[JENKINS-26323] The "Build Current Patches Only" only works, if NO parameters in the build are altered

Martin Schröder created issue - 2015-01-07 16:28

Martin Schröder made changes - 2015-01-07 16:36

URL		New: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/194
Description	Original: The "Build Current Patches Only" feature currently identifies previous builds based on their parameters as they were present when the build was first scheduled. If you use a plugin that alters the parameters after the job has started, the cancelling of previous builds does not work, since the GerritTrigger#cancelJob() method does not find the job anymore. This is easily and trivially fixed, by not scanning for the parameters, but instead for the GerritEvent that is stored in the GerritCause used to start a build. A pull request will be uploaded ASAP.	New: The "Build Current Patches Only" feature currently identifies previous builds based on their parameters as they were present when the build was first scheduled. If you use a plugin that alters the parameters after the job has started, the cancelling of previous builds does not work, since the GerritTrigger#cancelJob() method does not find the job anymore. This is easily and trivially fixed, by not scanning for the parameters, but instead for the GerritEvent that is stored in the GerritCause used to start a build. A pull request has been uploaded here: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/194
Labels		New: abort gerrit gerrit-trigger

Martin Schröder made changes - 2015-01-07 17:26

Description

Original: The "Build Current Patches Only" feature currently identifies previous builds based on their parameters as they were present when the build was first scheduled. If you use a plugin that alters the parameters after the job has started, the cancelling of previous builds does not work, since the GerritTrigger#cancelJob() method does not find the job anymore. This is easily and trivially fixed, by not scanning for the parameters, but instead for the GerritEvent that is stored in the GerritCause used to start a build. A pull request has been uploaded here: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/194

New: The "Build Current Patches Only" feature currently identifies previous builds based on their parameters as they were present when the build was first scheduled. If you use a plugin that alters the parameters after the job has started, the cancelling of previous builds does not work, since the GerritTrigger#cancelJob() method does not find the job anymore. This is easily and trivially fixed, by not scanning for the parameters, but instead for the GerritEvent that is stored in the GerritCause used to start a build. A pull request has been uploaded here: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/195

Martin Schröder made changes - 2015-01-09 14:55

URL

Original: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/194

New: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/195

Scott Hebert made changes - 2015-11-27 18:35

Assignee

Original: jyrkiput [ jyrkiput ]

Scott Hebert made changes - 2015-11-27 18:35

Resolution		New: Fixed [ 1 ]
Status	Original: Open [ 1 ]	New: Resolved [ 5 ]

R. Tyler Croy made changes - 2016-07-25 23:56

Workflow

Original: JNJira [ 160386 ]

New: JNJira + In-Review [ 196412 ]