Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26399

Utility method in JenkinsRule to wait for build to complete

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      See BindingStepTest.cleanupAfterRestart for example.

          [JENKINS-26399] Utility method in JenkinsRule to wait for build to complete

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
          http://jenkins-ci.org/commit/workflow-plugin/3d3fa348ed9c34e4492b2733802bc47416824e30
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-plugin/3d3fa348ed9c34e4492b2733802bc47416824e30 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ).

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SleepStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/StageTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WorkspaceStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/RunWrapperTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java
          http://jenkins-ci.org/commit/workflow-plugin/fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9
          Log:
          JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SleepStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/StageTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WorkspaceStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/RunWrapperTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java http://jenkins-ci.org/commit/workflow-plugin/fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9 Log: JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          test/src/main/java/org/jvnet/hudson/test/BuildWatcher.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins/9ac2257d0a3fa86928267a82d69d55c5a4e423c1
          Log:
          [FIXED JENKINS-26399] JENKINS-25975 Merged #1609.

          Compare: https://github.com/jenkinsci/jenkins/compare/b02e71e3dfcb...9ac2257d0a3f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/main/java/org/jvnet/hudson/test/BuildWatcher.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins/9ac2257d0a3fa86928267a82d69d55c5a4e423c1 Log: [FIXED JENKINS-26399] JENKINS-25975 Merged #1609. Compare: https://github.com/jenkinsci/jenkins/compare/b02e71e3dfcb...9ac2257d0a3f

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/BuildWatcher.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java
          http://jenkins-ci.org/commit/workflow-plugin/c37ee2bafacb9c512cf9442a073130d888759cec
          Log:
          JENKINS-26399 Noting.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/BuildWatcher.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java http://jenkins-ci.org/commit/workflow-plugin/c37ee2bafacb9c512cf9442a073130d888759cec Log: JENKINS-26399 Noting.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/BuildWatcher.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/CoreStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/CoreWrapperStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/EnvStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SleepStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/StageTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WaitForConditionStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WorkspaceStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepRestartTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/RunWrapperTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java
          http://jenkins-ci.org/commit/workflow-plugin/2f6a9d24d2c8432e9b0abf6a31e00067fafd7ae0
          Log:
          Merge pull request #146 from jglick/standard-test-utils-JENKINS-26399

          JENKINS-26399 Standard test utils

          Compare: https://github.com/jenkinsci/workflow-plugin/compare/d5f5355c2f46...2f6a9d24d2c8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/BuildWatcher.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/JenkinsRuleExt.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/CoreStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/CoreWrapperStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/EnvStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SleepStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/StageTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/TimeoutStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WaitForConditionStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/WorkspaceStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepRestartTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/RunWrapperTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java http://jenkins-ci.org/commit/workflow-plugin/2f6a9d24d2c8432e9b0abf6a31e00067fafd7ae0 Log: Merge pull request #146 from jglick/standard-test-utils- JENKINS-26399 JENKINS-26399 Standard test utils Compare: https://github.com/jenkinsci/workflow-plugin/compare/d5f5355c2f46...2f6a9d24d2c8

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          test/src/main/java/org/jvnet/hudson/test/BuildWatcher.java
          test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
          http://jenkins-ci.org/commit/jenkins-test-harness/fc7807ec16c4c1d495f293332bf5890f2a3fa282
          Log:
          [FIXED JENKINS-26399] JENKINS-25975 Merged #1609.

          Originally-Committed-As: 9ac2257d0a3fa86928267a82d69d55c5a4e423c1

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/main/java/org/jvnet/hudson/test/BuildWatcher.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java http://jenkins-ci.org/commit/jenkins-test-harness/fc7807ec16c4c1d495f293332bf5890f2a3fa282 Log: [FIXED JENKINS-26399] JENKINS-25975 Merged #1609. Originally-Committed-As: 9ac2257d0a3fa86928267a82d69d55c5a4e423c1

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
          http://jenkins-ci.org/commit/workflow-support-plugin/18ad074331b663f565633bf4fa8523ac68dc1a69
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).
          Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-support-plugin/18ad074331b663f565633bf4fa8523ac68dc1a69 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/RunWrapperTest.java
          http://jenkins-ci.org/commit/workflow-support-plugin/284d595ca3d386eaf2ab91f73cf8d2d3f3763f25
          Log:
          JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message
          Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/RunWrapperTest.java http://jenkins-ci.org/commit/workflow-support-plugin/284d595ca3d386eaf2ab91f73cf8d2d3f3763f25 Log: JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-basic-steps-plugin/85812e78a3ab6c837b59002082e30bdc16294688
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).
          Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/85812e78a3ab6c837b59002082e30bdc16294688 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SleepStepTest.java
          http://jenkins-ci.org/commit/workflow-basic-steps-plugin/771871526e77aa276bc4b85e0aead48497956f88
          Log:
          JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message
          Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/SleepStepTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/771871526e77aa276bc4b85e0aead48497956f88 Log: JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-scm-step-plugin/7583bf18eda2968bebc10024b52aee00a3614149
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).
          Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-scm-step-plugin/7583bf18eda2968bebc10024b52aee00a3614149 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-scm-step-plugin/a6a42aeab6b4fcd61993cc0120a3615542b7b121
          Log:
          JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message
          Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-scm-step-plugin/a6a42aeab6b4fcd61993cc0120a3615542b7b121 Log: JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          http://jenkins-ci.org/commit/pipeline-build-step-plugin/301f43677a161db78cde42e3ac9e965ba2c5208d
          Log:
          JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message
          Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java http://jenkins-ci.org/commit/pipeline-build-step-plugin/301f43677a161db78cde42e3ac9e965ba2c5208d Log: JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java
          http://jenkins-ci.org/commit/pipeline-input-step-plugin/1b0385c432ab05b79709b3c97d968b1be2156161
          Log:
          JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message
          Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/1b0385c432ab05b79709b3c97d968b1be2156161 Log: JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/StageTest.java
          http://jenkins-ci.org/commit/pipeline-stage-step-plugin/f676d4c77f8bced08bca52e7751b68a145435521
          Log:
          JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message
          Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/StageTest.java http://jenkins-ci.org/commit/pipeline-stage-step-plugin/f676d4c77f8bced08bca52e7751b68a145435521 Log: JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/89c28b4fca0eb81cf369ff699f7a4d801fc83e83
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).
          Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/89c28b4fca0eb81cf369ff699f7a4d801fc83e83 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/eeeb0b13a82f05d688ea20d804ec65577587a9fb
          Log:
          JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message
          Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/eeeb0b13a82f05d688ea20d804ec65577587a9fb Log: JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/7ef7a8a1bbc1a2e68fdb452ba645297f67ae1772
          Log:
          Merge pull request #146 from jglick/standard-test-utils-JENKINS-26399

          JENKINS-26399 Standard test utils
          Originally-Committed-As: 2f6a9d24d2c8432e9b0abf6a31e00067fafd7ae0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/SingleJobTestBase.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/7ef7a8a1bbc1a2e68fdb452ba645297f67ae1772 Log: Merge pull request #146 from jglick/standard-test-utils- JENKINS-26399 JENKINS-26399 Standard test utils Originally-Committed-As: 2f6a9d24d2c8432e9b0abf6a31e00067fafd7ae0

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/fe863c4a5ba855d65cd68588a71e5293f0bdf641
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).
          Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/fe863c4a5ba855d65cd68588a71e5293f0bdf641 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/57db0a1d1854df30ad5e55ef9c102303f27e8019
          Log:
          JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message
          Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/57db0a1d1854df30ad5e55ef9c102303f27e8019 Log: JENKINS-26399 JenkinsRuleExt.waitForCompletion/Message Originally-Committed-As: fac5ce62db53f18cabb2347f0bb6ae9e3f3ea1f9

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java
          http://jenkins-ci.org/commit/workflow-job-plugin/ce70be6802a77f1d0b2ac5a245d5685059ea129f
          Log:
          Merge pull request #146 from jglick/standard-test-utils-JENKINS-26399

          JENKINS-26399 Standard test utils
          Originally-Committed-As: 2f6a9d24d2c8432e9b0abf6a31e00067fafd7ae0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java http://jenkins-ci.org/commit/workflow-job-plugin/ce70be6802a77f1d0b2ac5a245d5685059ea129f Log: Merge pull request #146 from jglick/standard-test-utils- JENKINS-26399 JENKINS-26399 Standard test utils Originally-Committed-As: 2f6a9d24d2c8432e9b0abf6a31e00067fafd7ae0

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: