Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26438

"Keep this build forever" button not visible if BuildDiscarder other than LogRotator is configured

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • Jenkins 1.565.1

    Description

      The button "Keep this build forever" is not visible in the build summary page when a BuildDiscarder other than LogRotator is configured. I don't think this is intentionally.

      The problem is in Jelly file core\src\main\resources\hudson\model\Run\logKeep.jelly, line 30:

      <j:if test="${it.parent.logRotator!=null and it.canToggleLogKeep()}">
      

      Should be fixed to:

      <j:if test="${it.parent.buildDiscarder!=null and it.canToggleLogKeep()}">
      

      Attachments

        Issue Links

          Activity

            matmoers Matthias Moers created issue -
            danielbeck Daniel Beck made changes -
            Field Original Value New Value
            Assignee Daniel Beck [ danielbeck ]
            danielbeck Daniel Beck added a comment -

            I agree. Great analysis!

            danielbeck Daniel Beck added a comment - I agree. Great analysis!
            jimilian Alexander A made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            jimilian Alexander A added a comment -

            danielbeck, could you fix it in next release, please? It's quite painful to use default LogRotator.

            jimilian Alexander A added a comment - danielbeck , could you fix it in next release, please? It's quite painful to use default LogRotator.
            danielbeck Daniel Beck added a comment -

            Sorry about that delay. I'll try to get it done soon.

            danielbeck Daniel Beck added a comment - Sorry about that delay. I'll try to get it done soon.
            danielbeck Daniel Beck made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            danielbeck Daniel Beck added a comment -

            Again, sorry about the delay. In the future, this is something where you could definitely file a PR to get it fixed more quickly

            https://github.com/jenkinsci/jenkins/pull/2443

            danielbeck Daniel Beck added a comment - Again, sorry about the delay. In the future, this is something where you could definitely file a PR to get it fixed more quickly https://github.com/jenkinsci/jenkins/pull/2443
            danielbeck Daniel Beck made changes -
            Remote Link This issue links to "PR 2443 (Web Link)" [ 14601 ]
            jimilian Alexander A added a comment -

            danielbeck, I didn't know that it's possible to create PR without signed CLA. Anyway, thanks a lot!

            jimilian Alexander A added a comment - danielbeck , I didn't know that it's possible to create PR without signed CLA. Anyway, thanks a lot!
            danielbeck Daniel Beck added a comment -

            Merged towards 2.14.

            danielbeck Daniel Beck added a comment - Merged towards 2.14.
            danielbeck Daniel Beck made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            danielbeck Daniel Beck made changes -
            Labels lts-candidate
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate 2.7.2-fixed lts-candidate
            olivergondza Oliver Gondža made changes -
            Labels 2.7.2-fixed lts-candidate 2.7.2-fixed
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 160505 ] JNJira + In-Review [ 196461 ]

            People

              danielbeck Daniel Beck
              matmoers Matthias Moers
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: