Details
-
Improvement
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
-
Platform: All, OS: All
Description
http://hudson.gotdns.com/wiki/display/JENKINS/Warnings+Plugin
as well as screenshots in
imply that I should be seeing a "Modules" tab in the Hudson results in the above
URL. But there is none; the row of tabs starts with "Packages".
The large Ant-based build traverses hundreds of distinct modules, each with
their own Ant build.xml with a configured project name, so I don't see why no
module name would be calculated.
Attachments
Activity
I just realized that this feature is not yet implemented for the warnings
plug-in. I think that using a similar approach as in the tasks plugin will work.
There I try to map absolute file names to a pom.xml or build.xml file that have
the largest prefix in common.
I believe that approach would work. A typical warning line would be
/hudson/workdir/jobs/test-compilation/workspace/visualweb.webui.themes/src/org/netbeans/modules/visualweb/webui/themes/ThemesFolderNode.java:201:
warning: [unchecked] unchecked call to put(K,V) as a member of the raw type
java.util.Map
themesList.put(lib.getName(), lib);
^
where
/hudson/workdir/jobs/test-compilation/workspace/visualweb.webui.themes/build.xml
contains a <project name='...' ...> root element (though just the relative dir
path 'visualweb.webui.themes' would be fine as a module name too).
It is not working correctly for my project (same URL as before) using Warnings
plugin 2.1 on Hudson 1.273: the handful of source code which happens to be
inside a dir with a pom.xml is marked with the Maven module name, but the
hundreds of Ant modules are listed only as "Default Module".
I think ModuleDetector.createFilesToModuleMapping is incorrect in assuming that
a workspace contains exclusively Maven modules or exclusively Ant modules. (If a
single directory contains both build.xml and pom.xml, as is common, I would
suggest giving the POM preference as it is likely to be a more accurate source
of display name metadata.)
Code changed in jenkins
User: Ulli Hafner
Path:
.settings/org.eclipse.core.resources.prefs
src/main/java/hudson/plugins/analysis/util/ModuleDetector.java
src/test/java/hudson/plugins/analysis/util/ModuleDetectorTest.java
http://jenkins-ci.org/commit/analysis-core-plugin/0077608e2333ba247dfdcb34917673c470529b12
Log:
[FIXED JENKINS-2657] Let maven modules take precedence over ant modules.
Integrated in 
plugins_analysis-core #166
[FIXED JENKINS-2657] Let maven modules take precedence over ant modules.
Ulli Hafner :
Files :
- .settings/org.eclipse.core.resources.prefs
- src/test/java/hudson/plugins/analysis/util/ModuleDetectorTest.java
- src/main/java/hudson/plugins/analysis/util/ModuleDetector.java
Without having tried the new code yet, just a warning that the commit comment "Let maven modules take precedence over ant modules" does not address the primary bug, which was "createFilesToModuleMapping is incorrect in assuming that
a workspace contains exclusively Maven modules or exclusively Ant modules". Perhaps that was fixed earlier, or as part of this patch, but if so the log did not mention it.
The computation is based on file name prefixes (warning file vs. found ant
build.xml files., maybe that guessing does not work in your case...).