Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26643

DescribableList.buildDependencyGraph should catch RuntimeException

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      If a DependencyDeclarer throws a RuntimeException from buildDependencyGraph, it can prevent Jenkins from starting.

      This could happen simply because a project has an invalid configuration, such as in the parameterized trigger plugin.

      Example:

      SEVERE: Failed Finalizing set up
      java.lang.NullPointerException
      at java.util.StringTokenizer.<init>(Unknown Source)
      at java.util.StringTokenizer.<init>(Unknown Source)
      at hudson.model.Items.fromNameList(Items.java:145)
      at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getProjectList(BuildTriggerConfig.java:125)
      at hudson.plugins.parameterizedtrigger.BuildTrigger.buildDependencyGraph(BuildTrigger.java:74)
      at hudson.util.DescribableList.buildDependencyGraph(DescribableList.java:213)
      at hudson.model.Project.buildDependencyGraph(Project.java:201)
      at hudson.model.DependencyGraph.build(DependencyGraph.java:95)
      at jenkins.model.Jenkins.rebuildDependencyGraph(Jenkins.java:3738)
      at jenkins.model.Jenkins$20.run(Jenkins.java:2680)
      at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
      at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282)
      at jenkins.model.Jenkins$7.runTask(Jenkins.java:886)
      at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210)
      at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
      at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
      at java.lang.Thread.run(Unknown Source)

          [JENKINS-26643] DescribableList.buildDependencyGraph should catch RuntimeException

          Ryan Campbell created issue -
          Ryan Campbell made changes -
          Link New: This issue is related to JENKINS-26646 [ JENKINS-26646 ]
          Ryan Campbell made changes -
          Description Original: If a DependencyDeclarer throws a RuntimeException from buildDependencyGraph, it can prevent Jenkins from starting.

          This could happen simply because a project has an invalid configuration, such as in the parameterized trigger plugin.
          New: If a DependencyDeclarer throws a RuntimeException from buildDependencyGraph, it can prevent Jenkins from starting.

          This could happen simply because a project has an invalid configuration, such as in the parameterized trigger plugin.

          Example:

          SEVERE: Failed Finalizing set up
          java.lang.NullPointerException
          at java.util.StringTokenizer.<init>(Unknown Source)
          at java.util.StringTokenizer.<init>(Unknown Source)
          at hudson.model.Items.fromNameList(Items.java:145)
          at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getProjectList(BuildTriggerConfig.java:125)
          at hudson.plugins.parameterizedtrigger.BuildTrigger.buildDependencyGraph(BuildTrigger.java:74)
          at hudson.util.DescribableList.buildDependencyGraph(DescribableList.java:213)
          at hudson.model.Project.buildDependencyGraph(Project.java:201)
          at hudson.model.DependencyGraph.build(DependencyGraph.java:95)
          at jenkins.model.Jenkins.rebuildDependencyGraph(Jenkins.java:3738)
          at jenkins.model.Jenkins$20.run(Jenkins.java:2680)
          at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
          at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282)
          at jenkins.model.Jenkins$7.runTask(Jenkins.java:886)
          at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210)
          at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
          at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
          at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
          at java.lang.Thread.run(Unknown Source)
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 1550 (Web Link)" [ 12033 ]
          Jesse Glick made changes -
          Assignee New: Ryan Campbell [ recampbell ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Ryan Campbell made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 160716 ] New: JNJira + In-Review [ 196541 ]

            recampbell Ryan Campbell
            recampbell Ryan Campbell
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: