Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26670

Support WorkflowJob for Authorize Project

    XMLWordPrintable

Details

    Description

      ProjectQueueItemAuthenticator is restricted to AbstractProject for no apparent reason. It should work on any Job.

      Attachments

        Issue Links

          Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is blocking JENKINS-26393 [ JENKINS-26393 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-25851 [ JENKINS-25851 ]
            jglick Jesse Glick made changes -
            Summary Support WorkflowJob Support WorkflowJob for Authorize Project
            ikedam ikedam made changes -
            Assignee ikedam [ ikedam ]
            ikedam ikedam made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            ikedam ikedam added a comment - https://github.com/jenkinsci/authorize-project-plugin/pull/8
            jglick Jesse Glick made changes -
            Link This issue depends on JENKINS-28258 [ JENKINS-28258 ]

            Code changed in jenkins
            User: Jesse Glick
            Path:
            COMPATIBILITY.md
            http://jenkins-ci.org/commit/workflow-plugin/13c0e810bb77954b2607124260632e30e8b6f52f
            Log:
            JENKINS-26670 Noting.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/13c0e810bb77954b2607124260632e30e8b6f52f Log: JENKINS-26670 Noting.

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty.java
            src/main/java/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectStrategy.java
            src/main/java/org/jenkinsci/plugins/authorizeproject/ProjectQueueItemAuthenticator.java
            src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/AnonymousAuthorizationStrategy.java
            src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/SpecificUsersAuthorizationStrategy.java
            src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/TriggeringUsersAuthorizationStrategy.java
            src/test/java/org/jenkinsci/plugins/authorizeproject/ProjectQueueItemAuthenticatorTest.java
            http://jenkins-ci.org/commit/authorize-project-plugin/63c5d2a2ee91cee3ffb587958bcbdeb51fbc7f56
            Log:
            [FIXED JENKINS-26670] Support Job including WorkflowJob

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty.java src/main/java/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectStrategy.java src/main/java/org/jenkinsci/plugins/authorizeproject/ProjectQueueItemAuthenticator.java src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/AnonymousAuthorizationStrategy.java src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/SpecificUsersAuthorizationStrategy.java src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/TriggeringUsersAuthorizationStrategy.java src/test/java/org/jenkinsci/plugins/authorizeproject/ProjectQueueItemAuthenticatorTest.java http://jenkins-ci.org/commit/authorize-project-plugin/63c5d2a2ee91cee3ffb587958bcbdeb51fbc7f56 Log: [FIXED JENKINS-26670] Support Job including WorkflowJob
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]

            Code changed in jenkins
            User: ikedam
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/authorizeproject/ProjectQueueItemAuthenticatorTest.java
            src/test/java/org/jenkinsci/plugins/authorizeproject/testutil/AuthorizeProjectJenkinsRule.java
            http://jenkins-ci.org/commit/authorize-project-plugin/135849e85bb050329b079136380c3d1e005b0130
            Log:
            JENKINS-26670 Added a test for WorkflowJob as a test for Job. It's commented out as workflow requires Jenkins 1.580.1. Comment in those codes in pom.xml and ProjectQueueItemAuthenticatorTest to run that test locally.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: pom.xml src/test/java/org/jenkinsci/plugins/authorizeproject/ProjectQueueItemAuthenticatorTest.java src/test/java/org/jenkinsci/plugins/authorizeproject/testutil/AuthorizeProjectJenkinsRule.java http://jenkins-ci.org/commit/authorize-project-plugin/135849e85bb050329b079136380c3d1e005b0130 Log: JENKINS-26670 Added a test for WorkflowJob as a test for Job. It's commented out as workflow requires Jenkins 1.580.1. Comment in those codes in pom.xml and ProjectQueueItemAuthenticatorTest to run that test locally.

            Code changed in jenkins
            User: ikedam
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty.java
            src/main/java/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectStrategy.java
            src/main/java/org/jenkinsci/plugins/authorizeproject/ProjectQueueItemAuthenticator.java
            src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/AnonymousAuthorizationStrategy.java
            src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/SpecificUsersAuthorizationStrategy.java
            src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/TriggeringUsersAuthorizationStrategy.java
            src/test/java/org/jenkinsci/plugins/authorizeproject/ProjectQueueItemAuthenticatorTest.java
            src/test/java/org/jenkinsci/plugins/authorizeproject/testutil/AuthorizeProjectJenkinsRule.java
            http://jenkins-ci.org/commit/authorize-project-plugin/9365f685c1fb5e89594a18fac8de9a92b19a99dc
            Log:
            Merge pull request #8 from ikedam/feature/JENKINS-26670_SupportWorkflowJob

            [FIXED JENKINS-26670] Support Job including WorkflowJob

            Compare: https://github.com/jenkinsci/authorize-project-plugin/compare/440d75a4ea5e...9365f685c1fb

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: pom.xml src/main/java/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectProperty.java src/main/java/org/jenkinsci/plugins/authorizeproject/AuthorizeProjectStrategy.java src/main/java/org/jenkinsci/plugins/authorizeproject/ProjectQueueItemAuthenticator.java src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/AnonymousAuthorizationStrategy.java src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/SpecificUsersAuthorizationStrategy.java src/main/java/org/jenkinsci/plugins/authorizeproject/strategy/TriggeringUsersAuthorizationStrategy.java src/test/java/org/jenkinsci/plugins/authorizeproject/ProjectQueueItemAuthenticatorTest.java src/test/java/org/jenkinsci/plugins/authorizeproject/testutil/AuthorizeProjectJenkinsRule.java http://jenkins-ci.org/commit/authorize-project-plugin/9365f685c1fb5e89594a18fac8de9a92b19a99dc Log: Merge pull request #8 from ikedam/feature/ JENKINS-26670 _SupportWorkflowJob [FIXED JENKINS-26670] Support Job including WorkflowJob Compare: https://github.com/jenkinsci/authorize-project-plugin/compare/440d75a4ea5e...9365f685c1fb

            Code changed in jenkins
            User: Jesse Glick
            Path:
            COMPATIBILITY.md
            http://jenkins-ci.org/commit/workflow-plugin/0f7410cb0e3cd5198c8cdf808309fc694b2c7003
            Log:
            JENKINS-26670 Noting.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/0f7410cb0e3cd5198c8cdf808309fc694b2c7003 Log: JENKINS-26670 Noting.
            ikedam ikedam added a comment -

            Fixed in authorize-project 1.1.0.
            It will be available in the update center in a day.

            ikedam ikedam added a comment - Fixed in authorize-project 1.1.0. It will be available in the update center in a day.
            ikedam ikedam made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 160745 ] JNJira + In-Review [ 208385 ]
            abayer Andrew Bayer made changes -
            Labels workflow pipeline workflow
            abayer Andrew Bayer made changes -
            Labels pipeline workflow pipeline

            People

              ikedam ikedam
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: