[JENKINS-26690] Build stats throws illegal argument exception on dashboard view - Jenkins Jira

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Critical
Resolution: Fixed
Component/s: core
Labels:
- regression

Similar Issues:

Show

Description

Dear all,

on jenkins 1.597 (and also 1.598) the build stats on Dashboard view (version 2.9.4) doesn't work because of:

Caught exception evaluating: it.getBuildStat(jobs) in /ci/. Reason: java.lang.IllegalArgumentException: fromKey > toKey
java.lang.IllegalArgumentException: fromKey > toKey
	at java.util.TreeMap$NavigableSubMap.<init>(TreeMap.java:1261)
	at java.util.TreeMap$AscendingSubMap.<init>(TreeMap.java:1699)
	at java.util.TreeMap.subMap(TreeMap.java:877)
	at java.util.TreeMap.subMap(TreeMap.java:918)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.subMap(AbstractLazyLoadRunMap.java:250)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.headMap(AbstractLazyLoadRunMap.java:254)
	at jenkins.model.lazy.AbstractLazyLoadRunMap.headMap(AbstractLazyLoadRunMap.java:88)
	at java.util.Collections$UnmodifiableSortedMap.headMap(Collections.java:1543)
	at hudson.plugins.view.dashboard.stats.StatBuilds.getBuildStat(StatBuilds.java:48)

etc.

Please let me know if you need more info.

Regards

Davide

Attachments

Issue Links

is blocking

JENKINS-24380 Use build numbers as IDs

Resolved

is related to

JENKINS-27186 Dashboard throws illegal argument Exception

Resolved

links to

PR 1586

Activity

Ascending order - Click to sort in descending order

View 4 older comments

Jesse Glick added a comment - 2015-02-26 22:47

SortedMap.headMap is documented to allow the implementation to throw IllegalArgumentException

if this map itself has a restricted range, and toKey lies outside the bounds of the range

and passing a negative argument is clearly “outside the bounds of the range” when the range is Jenkins build numbers, whether or not earlier versions of Jenkins happened to enforce that.

However it looks like I wrote this call to headMap so I am on the hook to fix either the caller or the implementor.

Jesse Glick added a comment - 2015-02-26 22:47 SortedMap.headMap is documented to allow the implementation to throw IllegalArgumentException if this map itself has a restricted range, and toKey lies outside the bounds of the range and passing a negative argument is clearly “outside the bounds of the range” when the range is Jenkins build numbers, whether or not earlier versions of Jenkins happened to enforce that. However it looks like I wrote this call to headMap so I am on the hook to fix either the caller or the implementor.

Jesse Glick added a comment - 2015-02-26 23:06 - edited

danielbeck’s hypothesis is correct, this was a regression in the fix of ~~JENKINS-24380~~.

Jesse Glick added a comment - 2015-02-26 23:06 - edited danielbeck ’s hypothesis is correct, this was a regression in the fix of JENKINS-24380 .

SCM/JIRA link daemon added a comment - 2015-02-27 20:56

Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java
http://jenkins-ci.org/commit/jenkins/db1f805d68a1aaf8e2d6d1c96cb006fc1dd4c087
Log:
[FIXED JENKINS-26690] Integer overflow in AbstractLazyLoadRunMap.headMap with negative arguments.

SCM/JIRA link daemon added a comment - 2015-02-27 20:56 Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java http://jenkins-ci.org/commit/jenkins/db1f805d68a1aaf8e2d6d1c96cb006fc1dd4c087 Log: [FIXED JENKINS-26690] Integer overflow in AbstractLazyLoadRunMap.headMap with negative arguments.

SCM/JIRA link daemon added a comment - 2015-02-27 20:56

Code changed in jenkins
User: Jesse Glick
Path:
changelog.html
core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java
http://jenkins-ci.org/commit/jenkins/dac7dfe94e6c21eee92704acace2079668a023b1
Log:
~~JENKINS-26690~~ Noting merge of #1586.

Compare: https://github.com/jenkinsci/jenkins/compare/a452023789cc...dac7dfe94e6c

SCM/JIRA link daemon added a comment - 2015-02-27 20:56 Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java http://jenkins-ci.org/commit/jenkins/dac7dfe94e6c21eee92704acace2079668a023b1 Log: JENKINS-26690 Noting merge of #1586. Compare: https://github.com/jenkinsci/jenkins/compare/a452023789cc...dac7dfe94e6c

dogfood added a comment - 2015-02-27 22:28

Integrated in jenkins_main_trunk #3987
[FIXED JENKINS-26690] Integer overflow in AbstractLazyLoadRunMap.headMap with negative arguments. (Revision db1f805d68a1aaf8e2d6d1c96cb006fc1dd4c087)

Result = SUCCESS
jesse glick : db1f805d68a1aaf8e2d6d1c96cb006fc1dd4c087
Files :

core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java
core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java

dogfood added a comment - 2015-02-27 22:28 Integrated in jenkins_main_trunk #3987 [FIXED JENKINS-26690] Integer overflow in AbstractLazyLoadRunMap.headMap with negative arguments. (Revision db1f805d68a1aaf8e2d6d1c96cb006fc1dd4c087) Result = SUCCESS jesse glick : db1f805d68a1aaf8e2d6d1c96cb006fc1dd4c087 Files : core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java

Jenkins

Build stats throws illegal argument exception on dashboard view

Details

Description

Attachments

Issue Links

Activity

People

Dates