Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26698

Failure to recover from exception in Publisher.needsToRunAfterFinalized

      If Publisher.needsToRunAfterFinalized throws an exception, the workspace lease is not released.

      Worse, the exception is not even reported anywhere if there was already an exception in the publisher, because Run.handleFatalBuildProblem closed the build log the first time, so the stack trace is lost.

          [JENKINS-26698] Failure to recover from exception in Publisher.needsToRunAfterFinalized

          Jesse Glick created issue -
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 1554 (Web Link)" [ 12036 ]

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/Build.java
          core/src/main/java/hudson/model/Run.java
          test/src/test/java/hudson/model/BuildExecutionTest.java
          http://jenkins-ci.org/commit/jenkins/62af87b67a1097376b9af554421e621d32f7013f
          Log:
          JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease.
          Also stop closing the build log in Run.handleFatalBuildProblem; we want to see any subsequent messages too.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Run.java test/src/test/java/hudson/model/BuildExecutionTest.java http://jenkins-ci.org/commit/jenkins/62af87b67a1097376b9af554421e621d32f7013f Log: JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. Also stop closing the build log in Run.handleFatalBuildProblem; we want to see any subsequent messages too.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/Build.java
          core/src/main/java/hudson/model/Run.java
          core/src/main/java/hudson/slaves/WorkspaceList.java
          test/src/test/java/hudson/model/BuildExecutionTest.java
          http://jenkins-ci.org/commit/jenkins/1f844a55222c4442102d06f37c205f1819e2ce2f
          Log:
          [FiXED JENKINS-26698] Noting merge of #1554.

          Compare: https://github.com/jenkinsci/jenkins/compare/7ad3f5012156...1f844a55222c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Run.java core/src/main/java/hudson/slaves/WorkspaceList.java test/src/test/java/hudson/model/BuildExecutionTest.java http://jenkins-ci.org/commit/jenkins/1f844a55222c4442102d06f37c205f1819e2ce2f Log: [FiXED JENKINS-26698] Noting merge of #1554. Compare: https://github.com/jenkinsci/jenkins/compare/7ad3f5012156...1f844a55222c

          Jesse Glick added a comment -

          JIRA link daemon heed my cries!

          Jesse Glick added a comment - JIRA link daemon heed my cries!
          Jesse Glick made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3960
          JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. (Revision 62af87b67a1097376b9af554421e621d32f7013f)

          Result = SUCCESS
          jesse glick : 62af87b67a1097376b9af554421e621d32f7013f
          Files :

          • core/src/main/java/hudson/model/Build.java
          • core/src/main/java/hudson/model/Run.java
          • test/src/test/java/hudson/model/BuildExecutionTest.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3960 JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. (Revision 62af87b67a1097376b9af554421e621d32f7013f) Result = SUCCESS jesse glick : 62af87b67a1097376b9af554421e621d32f7013f Files : core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Run.java test/src/test/java/hudson/model/BuildExecutionTest.java
          Daniel Beck made changes -
          Labels Original: robustness New: lts-candidate robustness
          Oliver Gondža made changes -
          Labels Original: lts-candidate robustness New: 1.596.2-fixed robustness

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: