Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26828

Add support for installing the NodeJS windows msi

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • nodejs-plugin
    • None
    • Windows

      Currently the code has the following

      // At the moment, windows MSI installer are not handled !
      //} else if (platform == NodeJSInstaller.Platform.WINDOWS){

      A possible solution to automate installation is to use msiexec with following options:

      msiexec TARGETDIR=<install location> /a node-<version>-x86.msi /qn /l* log.txt

      this removes any UAC issues and just unpacks the files to TARGETDIR. also adds logging out to log.txt

          [JENKINS-26828] Add support for installing the NodeJS windows msi

          Charl Thiem added a comment -

          This is more than a year old...but I'm also very interested in this. I have some nodejs projects that build native files (node-gyp modules) which has to run on my windows slave nodes. I know I can manually install the nodejs on the machine....but the auto install saves a lot of effort, especially when trying out different nodejs versions

          Charl Thiem added a comment - This is more than a year old...but I'm also very interested in this. I have some nodejs projects that build native files (node-gyp modules) which has to run on my windows slave nodes. I know I can manually install the nodejs on the machine....but the auto install saves a lot of effort, especially when trying out different nodejs versions

          benoit guerin added a comment -

          PR exists for this : https://github.com/jenkinsci/nodejs-plugin/pull/5

          benoit guerin added a comment - PR exists for this : https://github.com/jenkinsci/nodejs-plugin/pull/5

          Nikolas Falco added a comment -

          I've try the PR and does not work. Should be fixed the URL construction

          Nikolas Falco added a comment - I've try the PR and does not work. Should be fixed the URL construction

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Iain
          Path:
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
          src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
          src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
          http://jenkins-ci.org/commit/nodejs-plugin/f6dfd2631e3237fa679feb3c42b7bdb2ce7c9371
          Log:
          JENKINS-26828 Add support for installing the NodeJS windows msi

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Iain Path: src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java http://jenkins-ci.org/commit/nodejs-plugin/f6dfd2631e3237fa679feb3c42b7bdb2ce7c9371 Log: JENKINS-26828 Add support for installing the NodeJS windows msi

          benoit guerin added a comment -

          Hello nfalco

          I am a working version here if you want :
          https://github.com/netceler/nodejs-plugin/tree/valence-ci

          this is especially this commit :
          https://github.com/netceler/nodejs-plugin/commit/9c79ca0826ad3ec66aca812b0b74ed8560ed8693

          benoit guerin added a comment - Hello nfalco I am a working version here if you want : https://github.com/netceler/nodejs-plugin/tree/valence-ci this is especially this commit : https://github.com/netceler/nodejs-plugin/commit/9c79ca0826ad3ec66aca812b0b74ed8560ed8693

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nikolas Falco
          Path:
          src/main/java/jenkins/plugins/nodejs/tools/CPU.java
          src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
          src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
          src/main/java/jenkins/plugins/nodejs/tools/Platform.java
          src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
          src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
          http://jenkins-ci.org/commit/nodejs-plugin/9ba06f17ab1272bf3afdd963dfe3d0c0fd265c8d
          Log:
          [FIXED JENKINS-26828] Add support for installing the NodeJS windows msi

          Remove unused old method.
          Update some old duplicate code from jenkins core code.
          Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java http://jenkins-ci.org/commit/nodejs-plugin/9ba06f17ab1272bf3afdd963dfe3d0c0fd265c8d Log: [FIXED JENKINS-26828] Add support for installing the NodeJS windows msi Remove unused old method. Update some old duplicate code from jenkins core code. Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nikolas Falco
          Path:
          src/main/java/jenkins/plugins/nodejs/tools/CPU.java
          src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
          src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
          src/main/java/jenkins/plugins/nodejs/tools/Platform.java
          src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
          src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
          src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
          http://jenkins-ci.org/commit/nodejs-plugin/0f8bbb7f58de3eedd3c7783e3a2c243f331ddd1c
          Log:
          FIXED JENKINS-26828 Add support for installing the NodeJS windows msi

          Remove unused old method.
          Update some old duplicate code from jenkins core code.
          Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/0f8bbb7f58de3eedd3c7783e3a2c243f331ddd1c Log: FIXED JENKINS-26828 Add support for installing the NodeJS windows msi Remove unused old method. Update some old duplicate code from jenkins core code. Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nikolas Falco
          Path:
          src/main/java/jenkins/plugins/nodejs/tools/CPU.java
          src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
          src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
          src/main/java/jenkins/plugins/nodejs/tools/Platform.java
          src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
          src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
          src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
          http://jenkins-ci.org/commit/nodejs-plugin/6d0487c12e51701da6ffc71a4f4295fd8f5cb846
          Log:
          JENKINS-26828 Add support for installing the NodeJS windows msi

          Remove unused old method.
          Update some old duplicate code from jenkins core code.
          Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/6d0487c12e51701da6ffc71a4f4295fd8f5cb846 Log: JENKINS-26828 Add support for installing the NodeJS windows msi Remove unused old method. Update some old duplicate code from jenkins core code. Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nikolas Falco
          Path:
          pom.xml
          src/main/java/jenkins/plugins/nodejs/tools/CPU.java
          src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
          src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
          src/main/java/jenkins/plugins/nodejs/tools/Platform.java
          src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
          src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
          src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
          http://jenkins-ci.org/commit/nodejs-plugin/b6169d29b61e7c2241cf162c8d1468c19b9d27b4
          Log:
          JENKINS-26828 Add support for installing the NodeJS windows msi

          Remove unused old method.
          Update some old duplicate code from jenkins core code.
          Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: pom.xml src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/b6169d29b61e7c2241cf162c8d1468c19b9d27b4 Log: JENKINS-26828 Add support for installing the NodeJS windows msi Remove unused old method. Update some old duplicate code from jenkins core code. Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nikolas Falco
          Path:
          src/main/java/jenkins/plugins/nodejs/tools/CPU.java
          src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
          src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
          src/main/java/jenkins/plugins/nodejs/tools/Platform.java
          src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
          src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
          src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
          http://jenkins-ci.org/commit/nodejs-plugin/d733226d24001498193064b0f009795092753aa4
          Log:
          JENKINS-26828 Add support for installing the NodeJS windows msi

          Remove unused old method.
          Update some old duplicate code from jenkins core code.
          Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/d733226d24001498193064b0f009795092753aa4 Log: JENKINS-26828 Add support for installing the NodeJS windows msi Remove unused old method. Update some old duplicate code from jenkins core code. Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nikolas Falco
          Path:
          src/main/java/jenkins/plugins/nodejs/tools/CPU.java
          src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
          src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
          src/main/java/jenkins/plugins/nodejs/tools/Platform.java
          src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
          src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
          src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
          http://jenkins-ci.org/commit/nodejs-plugin/95b8e220d2078e6e6ac2bcbd086d52d68f4539c9
          Log:
          JENKINS-26828 Add support for installing the NodeJS windows msi

          Remove unused old method.
          Update some old duplicate code from jenkins core code.
          Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/95b8e220d2078e6e6ac2bcbd086d52d68f4539c9 Log: JENKINS-26828 Add support for installing the NodeJS windows msi Remove unused old method. Update some old duplicate code from jenkins core code. Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nikolas Falco
          Path:
          src/main/java/jenkins/plugins/nodejs/tools/CPU.java
          src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
          src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
          src/main/java/jenkins/plugins/nodejs/tools/Platform.java
          src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
          src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
          src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
          http://jenkins-ci.org/commit/nodejs-plugin/9038814957cff39ee5c66c4c170e18a6baa16be0
          Log:
          JENKINS-26828 Add support for installing the NodeJS windows msi

          Remove unused old method.
          Update some old duplicate code from jenkins core code.
          Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/9038814957cff39ee5c66c4c170e18a6baa16be0 Log: JENKINS-26828 Add support for installing the NodeJS windows msi Remove unused old method. Update some old duplicate code from jenkins core code. Extend version with range capabilities to check which version has only an msi installer.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nikolas Falco
          Path:
          src/main/java/jenkins/plugins/nodejs/tools/CPU.java
          src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
          src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
          src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
          src/main/java/jenkins/plugins/nodejs/tools/Platform.java
          src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
          src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
          src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
          http://jenkins-ci.org/commit/nodejs-plugin/1db81e46778aa2e3e97bdbe2133603b4b338a977
          Log:
          [FIX JENKINS-26828]

          Compare: https://github.com/jenkinsci/nodejs-plugin/compare/d6772edc891b...1db81e46778a

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/1db81e46778aa2e3e97bdbe2133603b4b338a977 Log: [FIX JENKINS-26828] Compare: https://github.com/jenkinsci/nodejs-plugin/compare/d6772edc891b...1db81e46778a

          Nikolas Falco added a comment -

          Release 1.0 with windows support

          Nikolas Falco added a comment - Release 1.0 with windows support

            nfalco Nikolas Falco
            icoulter Iain Coulter
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: