Details
-
Bug
-
Status: Closed (View Workflow)
-
Blocker
-
Resolution: Fixed
-
None
Description
Boolean return from publishers is deprecated, but there is a total mess in all plugins and core about it. New and right variant now is to fail build with throw AbortException. Such errors are not catched in flexible publish and first thrown publisher stops flexible execution for other publishers nevertheless on configured conditions.
According to my debugging plugin must
try { perform } catch { return false;}
somewhere in root calls in addition to boolean return codes
Executor #1 for master : executing job #73@9386, prio=5, in group 'main', status: 'RUNNING' at hudson.plugins.git.GitPublisher.perform(GitPublisher.java:281) at org.jenkins_ci.plugins.run_condition.BuildStepRunner$2.run(BuildStepRunner.java:110) at org.jenkins_ci.plugins.run_condition.BuildStepRunner$Fail.conditionalRun(BuildStepRunner.java:154) at org.jenkins_ci.plugins.run_condition.BuildStepRunner.perform(BuildStepRunner.java:105) at org.jenkins_ci.plugins.flexible_publish.ConditionalPublisher.perform(ConditionalPublisher.java:183) at org.jenkins_ci.plugins.flexible_publish.FlexiblePublisher.perform(FlexiblePublisher.java:116) at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:756) at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720) at hudson.model.Build$BuildExecution.post2(Build.java:182) at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669) at hudson.model.Run.execute(Run.java:1731) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:232)
Also if flexible-publish needs itself fail build - it must throw AbortException
See https://github.com/KostyaSha/git-plugin/commit/3af2af6af273a10e9c5ab4e4d200222bc39c2f3e for example.
Attachments
Issue Links
- is related to
-
-
- Resolved
-
- links to
Activity
I opened root case https://issues.jenkins-ci.org/browse/JENKINS-26964 and build statuses mess looks like a real blocker, because this is broken and i can't use core flow and can't use flexible publish flow. Fixing core is very dangerous, so fixing and using flexible publish for executing all publishers looks right. So this is blocker for usage. Let's better concentrate on fix 
Code changed in jenkins
User: ikedam
Path:
src/test/java/org/jenkins_ci/plugins/flexible_publish/FlexiblePublisherTest.java
http://jenkins-ci.org/commit/flexible-publish-plugin/f027caae16316b9ae8b3432fa771fd998b92cc82
Log:
JENKINS-26936 Added tests for JENKINS-29636, Flexible Publish aborts execution if a publisher throws Exception.
ikedam
added a comment - https://github.com/jenkinsci/flexible-publish-plugin/pull/12 
The status has merit, but it should be reserved for severe issues that actually make Jenkins really unusable (worse than occasional crashes, data loss and severe memory leak, which are only 'Critical'). This particular issue looks like 'Major loss of functionality' to me.
The problem with "This blocks whatever I'm trying to do, so it's a blocker" is that almost every relatively minor bug or unimplemented feature can be considered a blocker because someone, somewhere, planned to use that specific feature, but can't.