[JENKINS-26936] support thrown from publisher job statuses - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Blocker
Resolution: Fixed
Component/s: flexible-publish-plugin
Labels:
None

Similar Issues:

Show

Description

Boolean return from publishers is deprecated, but there is a total mess in all plugins and core about it. New and right variant now is to fail build with throw AbortException. Such errors are not catched in flexible publish and first thrown publisher stops flexible execution for other publishers nevertheless on configured conditions.
According to my debugging plugin must

try { perform } catch { return false;}

somewhere in root calls in addition to boolean return codes

Executor #1 for master : executing job #73@9386, prio=5, in group 'main', status: 'RUNNING'
	  at hudson.plugins.git.GitPublisher.perform(GitPublisher.java:281)
	  at org.jenkins_ci.plugins.run_condition.BuildStepRunner$2.run(BuildStepRunner.java:110)
	  at org.jenkins_ci.plugins.run_condition.BuildStepRunner$Fail.conditionalRun(BuildStepRunner.java:154)
	  at org.jenkins_ci.plugins.run_condition.BuildStepRunner.perform(BuildStepRunner.java:105)
	  at org.jenkins_ci.plugins.flexible_publish.ConditionalPublisher.perform(ConditionalPublisher.java:183)
	  at org.jenkins_ci.plugins.flexible_publish.FlexiblePublisher.perform(FlexiblePublisher.java:116)
	  at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45)
	  at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:756)
	  at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
	  at hudson.model.Build$BuildExecution.post2(Build.java:182)
	  at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669)
	  at hudson.model.Run.execute(Run.java:1731)
	  at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	  at hudson.model.ResourceController.execute(ResourceController.java:88)
	  at hudson.model.Executor.run(Executor.java:232)

Also if flexible-publish needs itself fail build - it must throw AbortException
See https://github.com/KostyaSha/git-plugin/commit/3af2af6af273a10e9c5ab4e4d200222bc39c2f3e for example.

Attachments

Issue Links

is related to

JENKINS-26964 post-build action statuses handling

Resolved

links to

flexible-publish-plugin/pull/9

flexible-publish-plugin/pull/10

flexible-publish-plugin/pull/11

Activity

Ascending order - Click to sort in descending order

Kanstantsin Shautsou created issue - 2015-02-12 17:21

Kanstantsin Shautsou made changes - 2015-02-12 17:23

Field	Original Value	New Value
Description	Boolean return from publishers is deprecated, but there is a total mess in all plugins and core about it. New and right variant now is to fail build with throw AbortException. Such errors are not catched in flexible publish and first thrown publisher stops flexible execution for other publishers nevertheless on configured conditions. According to my debugging plugin must {code} try { perform } catch { return false;} {code} somewhere in root calls in addition to boolean return codes {code} Executor #1 for master : executing job #73@9386, prio=5, in group 'main', status: 'RUNNING' at hudson.plugins.git.GitPublisher.perform(GitPublisher.java:281) at org.jenkins_ci.plugins.run_condition.BuildStepRunner$2.run(BuildStepRunner.java:110) at org.jenkins_ci.plugins.run_condition.BuildStepRunner$Fail.conditionalRun(BuildStepRunner.java:154) at org.jenkins_ci.plugins.run_condition.BuildStepRunner.perform(BuildStepRunner.java:105) at org.jenkins_ci.plugins.flexible_publish.ConditionalPublisher.perform(ConditionalPublisher.java:183) at org.jenkins_ci.plugins.flexible_publish.FlexiblePublisher.perform(FlexiblePublisher.java:116) at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:756) at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720) at hudson.model.Build$BuildExecution.post2(Build.java:182) at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669) at hudson.model.Run.execute(Run.java:1731) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:232) {code} Also if flexible-publish needs itself fail build - it must throw AbortException	Boolean return from publishers is deprecated, but there is a total mess in all plugins and core about it. New and right variant now is to fail build with throw AbortException. Such errors are not catched in flexible publish and first thrown publisher stops flexible execution for other publishers nevertheless on configured conditions. According to my debugging plugin must {code} try { perform } catch { return false;} {code} somewhere in root calls in addition to boolean return codes {code} Executor #1 for master : executing job #73@9386, prio=5, in group 'main', status: 'RUNNING' at hudson.plugins.git.GitPublisher.perform(GitPublisher.java:281) at org.jenkins_ci.plugins.run_condition.BuildStepRunner$2.run(BuildStepRunner.java:110) at org.jenkins_ci.plugins.run_condition.BuildStepRunner$Fail.conditionalRun(BuildStepRunner.java:154) at org.jenkins_ci.plugins.run_condition.BuildStepRunner.perform(BuildStepRunner.java:105) at org.jenkins_ci.plugins.flexible_publish.ConditionalPublisher.perform(ConditionalPublisher.java:183) at org.jenkins_ci.plugins.flexible_publish.FlexiblePublisher.perform(FlexiblePublisher.java:116) at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:756) at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720) at hudson.model.Build$BuildExecution.post2(Build.java:182) at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669) at hudson.model.Run.execute(Run.java:1731) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:232) {code} Also if flexible-publish needs itself fail build - it must throw AbortException See https://github.com/KostyaSha/git-plugin/commit/3af2af6af273a10e9c5ab4e4d200222bc39c2f3e for example.

Kanstantsin Shautsou made changes - 2015-02-12 17:24

Assignee

bap [ bap ]

ikedam [ ikedam ]

ikedam made changes - 2015-02-15 03:38

Priority

Blocker [ 1 ]

Major [ 3 ]

ikedam made changes - 2015-02-15 03:38

Status

Open [ 1 ]

In Progress [ 3 ]

Kanstantsin Shautsou made changes - 2015-02-15 14:03

Priority

Major [ 3 ]

Blocker [ 1 ]

Kanstantsin Shautsou made changes - 2015-02-15 15:53

Remote Link

This issue links to "flexible-publish-plugin/pull/10 (Web Link)" [ 12110 ]

Kanstantsin Shautsou made changes - 2015-02-15 15:53

Remote Link

This issue links to "flexible-publish-plugin/pull/9 (Web Link)" [ 12111 ]

Kanstantsin Shautsou made changes - 2015-02-15 16:31

Link

This issue is related to ~~JENKINS-26964~~ [ ~~JENKINS-26964~~ ]

Kanstantsin Shautsou made changes - 2015-02-16 02:33

Remote Link

This issue links to "flexible-publish-plugin/pull/11 (Web Link)" [ 12112 ]

ikedam made changes - 2015-03-28 01:53

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

ikedam made changes - 2015-03-28 01:54

Status

Resolved [ 5 ]

Closed [ 6 ]

R. Tyler Croy made changes - 2016-07-26 00:01

Workflow

JNJira [ 161120 ]

JNJira + In-Review [ 208438 ]

People

Assignee:: ikedam

Reporter:: Kanstantsin Shautsou

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2015-02-12 17:21

Updated:: 2015-03-28 01:54

Resolved:: 2015-03-28 01:53