Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2693

Jabber bot status doesn't correctly link to projects with spaces in the name (again)

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • jabber-plugin
    • None
    • Platform: All, OS: All

    Description

      Although https://hudson.dev.java.net/issues/show_bug.cgi?id=909 fixes the issue
      of URL encoding for the group messages, it appears that the per-developer
      'You're suspected of having broken ...' or 'Seems you've fixed' messages have
      not been fixed - neither one is performing a 'Util.encode(lastBuild.getUrl())'
      on the build URL.

      example in jabber client:

      bad: (11:29:28 AM) Hudson: You're suspected of having broken Opsera Common - CI:
      http://alm-test.opsera.com:8070/job/Opsera Common - CI/82/

      good: (12:01:20 PM) hudson@alm-test.opsera.com: Project Opsera Common - CI build
      (84): SUCCESS in 5 min 3 sec and counting:
      http://alm-test.opsera.com/hudson/job/Opsera%20Common%20-%20CI/84/

      Fix is trivial, simply perform proper encoding on URLs before sending them to
      clients

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          skaze skaze created issue -
          skaze skaze added a comment -

          Created an attachment (id=454)
          patch fixes URL encoding issues when messaging developers

          skaze skaze added a comment - Created an attachment (id=454) patch fixes URL encoding issues when messaging developers
          vsellier vsellier added a comment -

          You are right, I will apply the patch and release the plugin on 0.7 version

          vsellier vsellier added a comment - You are right, I will apply the patch and release the plugin on 0.7 version
          vsellier vsellier made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          vsellier vsellier added a comment -

          fixed with url creation centralized to avoid encoding copy and paste.

          Thanks for the patch

          vsellier vsellier added a comment - fixed with url creation centralized to avoid encoding copy and paste. Thanks for the patch
          vsellier vsellier made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          vsellier vsellier added a comment -

          fixed with url creation centralized to avoid encoding copy and paste.

          Thanks for the patch

          vsellier vsellier added a comment - fixed with url creation centralized to avoid encoding copy and paste. Thanks for the patch
          vsellier vsellier added a comment -

          fixed

          vsellier vsellier added a comment - fixed
          vsellier vsellier made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          abayer Andrew Bayer made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 132766 ] JNJira + In-Review [ 201650 ]

          People

            vsellier vsellier
            skaze skaze
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: