Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26964

post-build action statuses handling

    XMLWordPrintable

Details

    Description

      perform method that return boolean for publisher is deprecated now and AbortException with reason message is a new style.

      In current situation when you have two publishers:
      1) If build SUCCESS (build.getResult()) then do action and FAIL the publisher.
      2) if build SUCCESS - do action
      Because of 1) returned boolean build summary result is set to failed.
      So what status will see 2) publisher?
      If 1) publisher fail the build with 'return false', then second publisher will still see SUCCESS state and do unexpected action
      If 1) throw AbortException, then build result will be set to FAILURE and 2) publisher will see correct fail status.

      The error in this place https://github.com/jenkinsci/jenkins/blob/555e2d593fbb419d2fad7e9cfae5911daf3d30e3/core/src/main/java/hudson/model/AbstractBuild.java#L719-L729
      if branch sets build Result immediately for throwen error and later for boolean.

      Also AbortException shouldn't print stacktraces, issue in ancient code here:
      https://github.com/jenkinsci/jenkins/blob/555e2d593fbb419d2fad7e9cfae5911daf3d30e3/core/src/main/java/hudson/model/AbstractBuild.java#L716-L741

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-30730 AbstractBuildExecution#reportError should work will any kind of Build Step

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26936 support thrown from publisher job statuses

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-27066 Matrix project doesn't run all aggregators if one of them throws exception.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          links to

          Web Link jenkins/pull/1577

          Activity

            Ascending order - Click to sort in descending order
            jglick Jesse Glick added a comment -

            Not sure why JIRA link daemon did not notice the merge here.

            jglick Jesse Glick added a comment - Not sure why JIRA link daemon did not notice the merge here.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kanstantsin Shautsou
            Path:
            core/src/main/java/hudson/model/AbstractBuild.java
            test/src/test/java/hudson/model/FreestyleJobPublisherTest.java
            test/src/test/java/hudson/model/utils/AbortExceptionPublisher.java
            test/src/test/java/hudson/model/utils/IOExceptionPublisher.java
            test/src/test/java/hudson/model/utils/ResultWriterPublisher.java
            test/src/test/java/hudson/model/utils/TrueFalsePublisher.java
            http://jenkins-ci.org/commit/jenkins/e18bde37c9e5f02482eb0ab7394029ff733dbf85
            Log:
            [FIXED JENKINS-26964] Handle AbortException right

            (cherry picked from commit 625a22e63b73bd387d2b33cbb66d3ec05037ea26)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kanstantsin Shautsou Path: core/src/main/java/hudson/model/AbstractBuild.java test/src/test/java/hudson/model/FreestyleJobPublisherTest.java test/src/test/java/hudson/model/utils/AbortExceptionPublisher.java test/src/test/java/hudson/model/utils/IOExceptionPublisher.java test/src/test/java/hudson/model/utils/ResultWriterPublisher.java test/src/test/java/hudson/model/utils/TrueFalsePublisher.java http://jenkins-ci.org/commit/jenkins/e18bde37c9e5f02482eb0ab7394029ff733dbf85 Log: [FIXED JENKINS-26964] Handle AbortException right (cherry picked from commit 625a22e63b73bd387d2b33cbb66d3ec05037ea26)
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4292
            [FIXED JENKINS-26964] Handle AbortException right (Revision e18bde37c9e5f02482eb0ab7394029ff733dbf85)

            Result = UNSTABLE
            ogondza : e18bde37c9e5f02482eb0ab7394029ff733dbf85
            Files :

            • test/src/test/java/hudson/model/FreestyleJobPublisherTest.java
            • test/src/test/java/hudson/model/utils/TrueFalsePublisher.java
            • test/src/test/java/hudson/model/utils/ResultWriterPublisher.java
            • core/src/main/java/hudson/model/AbstractBuild.java
            • test/src/test/java/hudson/model/utils/IOExceptionPublisher.java
            • test/src/test/java/hudson/model/utils/AbortExceptionPublisher.java
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4292 [FIXED JENKINS-26964] Handle AbortException right (Revision e18bde37c9e5f02482eb0ab7394029ff733dbf85) Result = UNSTABLE ogondza : e18bde37c9e5f02482eb0ab7394029ff733dbf85 Files : test/src/test/java/hudson/model/FreestyleJobPublisherTest.java test/src/test/java/hudson/model/utils/TrueFalsePublisher.java test/src/test/java/hudson/model/utils/ResultWriterPublisher.java core/src/main/java/hudson/model/AbstractBuild.java test/src/test/java/hudson/model/utils/IOExceptionPublisher.java test/src/test/java/hudson/model/utils/AbortExceptionPublisher.java

            People

              integer Kanstantsin Shautsou
              integer Kanstantsin Shautsou
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: