[JENKINS-27438] Gerrit Trigger NPE causes folder not to load

Type: Bug
Resolution: Unresolved
Priority: Critical
Component/s: gerrit-trigger-plugin
Labels:
None
Environment:
Jenkins LTS 1.580.3 (installed standalone using builtin web container)
Cloudbees enterprise plugins installed
Linux RHEL 6.5
Java version "1.7.0_76"
Gerrit Trigger Plugin 2.12.0

Similar Issues:
Powered by SuggestiMate

Show

Folder containing jobs disappeared. I tried reloading the config from the filesystem option and I still see the same error message. Other team folders are visible and working correctly. Gerrit trigger functionality seems to work as well. I can hit the query and trigger Gerrit Patches link and it works fine.

I see in the logs:

Mar 16, 2015 12:35:20 PM jenkins.InitReactorRunner$1 onTaskFailed
SEVERE: Failed Loading job team_xyz
java.lang.NullPointerException
	at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger.start(GerritTrigger.java:396)
	at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger.start(GerritTrigger.java:124)
	at hudson.model.AbstractProject.onLoad(AbstractProject.java:325)
	at hudson.model.Project.onLoad(Project.java:95)
	at hudson.model.Items.load(Items.java:279)
	at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108)
	at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239)
	at hudson.model.Items.load(Items.java:279)
	at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108)
	at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239)
	at hudson.model.Items.load(Items.java:279)
	at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108)
	at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239)
	at hudson.model.Items.load(Items.java:279)
	at jenkins.model.Jenkins$17.run(Jenkins.java:2656)
	at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282)
	at jenkins.model.Jenkins$7.runTask(Jenkins.java:886)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

Ben Courliss created issue - 2015-03-16 13:31

Ben Courliss made changes - 2015-03-16 13:39

Description	Original: Folder containing jobs disappeared. I see in the logs: Mar 16, 2015 12:35:20 PM jenkins.InitReactorRunner$1 onTaskFailed SEVERE: Failed Loading job team_xyz java.lang.NullPointerException at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger.start(GerritTrigger.java:396) at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger.start(GerritTrigger.java:124) at hudson.model.AbstractProject.onLoad(AbstractProject.java:325) at hudson.model.Project.onLoad(Project.java:95) at hudson.model.Items.load(Items.java:279) at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108) at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239) at hudson.model.Items.load(Items.java:279) at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108) at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239) at hudson.model.Items.load(Items.java:279) at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108) at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239) at hudson.model.Items.load(Items.java:279) at jenkins.model.Jenkins$17.run(Jenkins.java:2656) at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169) at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282) at jenkins.model.Jenkins$7.runTask(Jenkins.java:886) at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210) at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745)	New: Folder containing jobs disappeared. I tried reloading the config from the filesystem option and I still see the same error message. Other team folders are visible and working correctly. Gerrit trigger functionality seems to work as well. I can hit the query and trigger Gerrit Patches link and it works fine. I see in the logs: Mar 16, 2015 12:35:20 PM jenkins.InitReactorRunner$1 onTaskFailed SEVERE: Failed Loading job team_xyz java.lang.NullPointerException at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger.start(GerritTrigger.java:396) at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger.start(GerritTrigger.java:124) at hudson.model.AbstractProject.onLoad(AbstractProject.java:325) at hudson.model.Project.onLoad(Project.java:95) at hudson.model.Items.load(Items.java:279) at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108) at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239) at hudson.model.Items.load(Items.java:279) at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108) at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239) at hudson.model.Items.load(Items.java:279) at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108) at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239) at hudson.model.Items.load(Items.java:279) at jenkins.model.Jenkins$17.run(Jenkins.java:2656) at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169) at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282) at jenkins.model.Jenkins$7.runTask(Jenkins.java:886) at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210) at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745)
Environment	Original: Jenkins 1.580.3, Cloudbees enterprise plugins installed, Linux RHEL 6.5, Java version "1.7.0_76", Gerrit Trigger Plugin 2.12.0	New: Jenkins LTS 1.580.3 (installed standalone using builtin web container) Cloudbees enterprise plugins installed Linux RHEL 6.5 Java version "1.7.0_76" Gerrit Trigger Plugin 2.12.0

rsandell added a comment - 2015-03-18 14:22

Have you tried with the latest 2.13.0-beta-x release? The implementation of the start has changed in that version.

rsandell added a comment - 2015-03-18 14:22 Have you tried with the latest 2.13.0-beta-x release? The implementation of the start has changed in that version.

Yoann Dubreuil added a comment - 2015-03-19 08:26

Just made a PR to guard against this NPE: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/214

Yoann Dubreuil added a comment - 2015-03-19 08:26 Just made a PR to guard against this NPE: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/214

SCM/JIRA link daemon added a comment - 2015-03-19 17:14

Code changed in jenkins
User: Yoann Dubreuil
Path:
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
http://jenkins-ci.org/commit/gerrit-trigger-plugin/9f12892b4f72e63054a6620707ad05e6fbee8a0f
Log:
JENKINS-27438: fix NPE when gerritProjects is null

This NPE is triggered when saving a job where user deleted all Gerrit
Project filters and checked 'Check Non-Reviewed Patchsets'. The job is
saved anyway.

On Jenkins start, it's also triggered when job is loaded, preventing
such jobs to be loaded.

SCM/JIRA link daemon added a comment - 2015-03-19 17:14 Code changed in jenkins User: Yoann Dubreuil Path: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/9f12892b4f72e63054a6620707ad05e6fbee8a0f Log: JENKINS-27438 : fix NPE when gerritProjects is null This NPE is triggered when saving a job where user deleted all Gerrit Project filters and checked 'Check Non-Reviewed Patchsets'. The job is saved anyway. On Jenkins start, it's also triggered when job is loaded, preventing such jobs to be loaded.

SCM/JIRA link daemon added a comment - 2015-03-19 17:14

Code changed in jenkins
User: Robert Sandell
Path:
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
http://jenkins-ci.org/commit/gerrit-trigger-plugin/b43acba07674bfb7a2023989a9d7d07822d3f46a
Log:
Merge pull request #214 from ydubreuil/fix-JENKINS-27438

JENKINS-27438: fix NPE when gerritProjects is null

Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/874cc250031b...b43acba07674

SCM/JIRA link daemon added a comment - 2015-03-19 17:14 Code changed in jenkins User: Robert Sandell Path: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/b43acba07674bfb7a2023989a9d7d07822d3f46a Log: Merge pull request #214 from ydubreuil/fix- JENKINS-27438 JENKINS-27438 : fix NPE when gerritProjects is null Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/874cc250031b...b43acba07674

Alexandru Gheorghe made changes - 2015-06-02 13:03

Description

Original: Folder containing jobs disappeared. I tried reloading the config from the filesystem option and I still see the same error message. Other team folders are visible and working correctly. Gerrit trigger functionality seems to work as well. I can hit the query and trigger Gerrit Patches link and it works fine.

I see in the logs:

Mar 16, 2015 12:35:20 PM jenkins.InitReactorRunner$1 onTaskFailed
SEVERE: Failed Loading job team_xyz
java.lang.NullPointerException
at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger.start(GerritTrigger.java:396)
at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger.start(GerritTrigger.java:124)
at hudson.model.AbstractProject.onLoad(AbstractProject.java:325)
at hudson.model.Project.onLoad(Project.java:95)
at hudson.model.Items.load(Items.java:279)
at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108)
at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239)
at hudson.model.Items.load(Items.java:279)
at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108)
at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239)
at hudson.model.Items.load(Items.java:279)
at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108)
at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239)
at hudson.model.Items.load(Items.java:279)
at jenkins.model.Jenkins$17.run(Jenkins.java:2656)
at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282)
at jenkins.model.Jenkins$7.runTask(Jenkins.java:886)
at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210)
at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)

New: Folder containing jobs disappeared. I tried reloading the config from the filesystem option and I still see the same error message. Other team folders are visible and working correctly. Gerrit trigger functionality seems to work as well. I can hit the query and trigger Gerrit Patches link and it works fine.

I see in the logs:
{noformat}
Mar 16, 2015 12:35:20 PM jenkins.InitReactorRunner$1 onTaskFailed
SEVERE: Failed Loading job team_xyz
java.lang.NullPointerException
at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger.start(GerritTrigger.java:396)
at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger.start(GerritTrigger.java:124)
at hudson.model.AbstractProject.onLoad(AbstractProject.java:325)
at hudson.model.Project.onLoad(Project.java:95)
at hudson.model.Items.load(Items.java:279)
at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108)
at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239)
at hudson.model.Items.load(Items.java:279)
at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108)
at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239)
at hudson.model.Items.load(Items.java:279)
at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:108)
at com.cloudbees.hudson.plugins.folder.Folder.onLoad(Folder.java:239)
at hudson.model.Items.load(Items.java:279)
at jenkins.model.Jenkins$17.run(Jenkins.java:2656)
at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:282)
at jenkins.model.Jenkins$7.runTask(Jenkins.java:886)
at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:210)
at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
{noformat}

R. Tyler Croy made changes - 2016-07-25 23:51

Workflow

Original: JNJira [ 161645 ]

New: JNJira + In-Review [ 180779 ]

Assignee:: rsandell

Reporter:: Ben Courliss

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 2015-03-16 13:31

Updated:: 2015-06-02 13:03

Jenkins

Details

Description

Attachments

Activity

Collapse comment: rsandell added a comment - 2015-03-18 14:22

Expand comment: rsandell added a comment - 2015-03-18 14:22

Collapse comment: Yoann Dubreuil added a comment - 2015-03-19 08:26

Expand comment: Yoann Dubreuil added a comment - 2015-03-19 08:26

Collapse comment: SCM/JIRA link daemon added a comment - 2015-03-19 17:14

Expand comment: SCM/JIRA link daemon added a comment - 2015-03-19 17:14

Collapse comment: SCM/JIRA link daemon added a comment - 2015-03-19 17:14

Expand comment: SCM/JIRA link daemon added a comment - 2015-03-19 17:14

People

Dates