Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27704

Clean up build record storage

XMLWordPrintable

      1. program.dat should be deleted after the build completes.
      2. CpsFlowExecution.owner should be transient.
      3. .script and .loadedScripts could probably be nulled out at the end of the build. (no, would break Replay)
      4. SCMCheckout.changelogFile should be relative.
      5. .pollingBaseline should use null rather than SCMRevisionState.None.
      6. As perhaps should MultiSCMRevisionState.revisionStates.values(). If possible, MultiSCMRevisionState should not be stored at all.
      7. EnvActionImpl should be deleted at the end of the build if empty.

          [JENKINS-27704] Clean up build record storage

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-26761 [ JENKINS-26761 ]
          Jesse Glick made changes -
          Link New: This issue is blocking JENKINS-29571 [ JENKINS-29571 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java
          http://jenkins-ci.org/commit/workflow-plugin/9d087ca7fcb3e6f186d3f44f289bae8861dedad7
          Log:
          JENKINS-29571 reproduced in test and confirmed to depend on part of JENKINS-27704.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java http://jenkins-ci.org/commit/workflow-plugin/9d087ca7fcb3e6f186d3f44f289bae8861dedad7 Log: JENKINS-29571 reproduced in test and confirmed to depend on part of JENKINS-27704 .

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          CHANGES.md
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java
          api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
          cps/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition2Test.java
          job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
          http://jenkins-ci.org/commit/workflow-plugin/b7014e66b8b064794efea6c78f35160c5250cc2e
          Log:
          [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient (JENKINS-27704) to avoid problems after renames/moves.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java cps/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition2Test.java job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-plugin/b7014e66b8b064794efea6c78f35160c5250cc2e Log: [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient ( JENKINS-27704 ) to avoid problems after renames/moves.
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-27531 [ JENKINS-27531 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
          http://jenkins-ci.org/commit/workflow-plugin/fc3851f4df8881e24c079cf51f42b48ec9596ab9
          Log:
          The fix of JENKINS-27531 in #97 seems to be made simpler by the fix of JENKINS-29571 via JENKINS-27704 in #157.
          We only needed getId(WorkflowRun) because CpsFlowExecution.unmarshal was trying to use an Owner.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-plugin/fc3851f4df8881e24c079cf51f42b48ec9596ab9 Log: The fix of JENKINS-27531 in #97 seems to be made simpler by the fix of JENKINS-29571 via JENKINS-27704 in #157. We only needed getId(WorkflowRun) because CpsFlowExecution.unmarshal was trying to use an Owner.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java
          http://jenkins-ci.org/commit/workflow-api-plugin/e26d0b7daa2cccae76ca7494e8fe35a8b31604dd
          Log:
          [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient (JENKINS-27704) to avoid problems after renames/moves.
          Originally-Committed-As: b7014e66b8b064794efea6c78f35160c5250cc2e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java http://jenkins-ci.org/commit/workflow-api-plugin/e26d0b7daa2cccae76ca7494e8fe35a8b31604dd Log: [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient ( JENKINS-27704 ) to avoid problems after renames/moves. Originally-Committed-As: b7014e66b8b064794efea6c78f35160c5250cc2e

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
          cps/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition2Test.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/e4d1b6291b92f6c82f6cbd652b5c62067aeb7119
          Log:
          [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient (JENKINS-27704) to avoid problems after renames/moves.
          Originally-Committed-As: b7014e66b8b064794efea6c78f35160c5250cc2e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java cps/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition2Test.java http://jenkins-ci.org/commit/workflow-cps-plugin/e4d1b6291b92f6c82f6cbd652b5c62067aeb7119 Log: [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient ( JENKINS-27704 ) to avoid problems after renames/moves. Originally-Committed-As: b7014e66b8b064794efea6c78f35160c5250cc2e

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: