Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27763

Rework ActiveDirectorySecurityRealm config UI

    XMLWordPrintable

Details

    Description

      AD plugin has two vastly different implementations. One is based on ADSI (let's call this "ADSI mode") and the other is based on JNDI LDAP calls (let's call this "LDAP mode".) ADSI mode is only available when master is running on Windows.

      When ADSI mode is possible, the plugin offers a different set of configuration options. This UI has a several problem.

      • UI doesn't make it obvious that setting the domain name results in switching to the LDAP mode.
      • When you implicitly choose LDAP mode by specifying a custom domain name, you should get all the configuration options of the LDAP mode, but you don't. See JENKINS-24960 and JENKINS-22727 for how this impacts users.

      Attachments

        Issue Links

          Activity

            kohsuke Kohsuke Kawaguchi created issue -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            src/main/java/hudson/plugins/active_directory/ActiveDirectorySecurityRealm.java
            src/main/resources/hudson/plugins/active_directory/ActiveDirectorySecurityRealm/_config.jelly
            src/main/resources/hudson/plugins/active_directory/ActiveDirectorySecurityRealm/config.jelly
            src/main/resources/hudson/plugins/active_directory/ActiveDirectorySecurityRealm/configAdvanced.jelly
            src/main/resources/hudson/plugins/active_directory/ActiveDirectorySecurityRealm/configAdvanced_pt_BR.properties
            src/main/resources/hudson/plugins/active_directory/ActiveDirectorySecurityRealm/config_de.properties
            http://jenkins-ci.org/commit/active-directory-plugin/b54418bf613cfc9d03b470b55199fb4a998d3926
            Log:
            [FIXED JENKINS-27763] reworked the UI.

            De-emphasize the domain name setting in the ADSI mode, but once the user
            selects that, expose the entire set of options that the LDAP mode has.

            Compare: https://github.com/jenkinsci/active-directory-plugin/compare/1c7438895c9a...b54418bf613c

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: src/main/java/hudson/plugins/active_directory/ActiveDirectorySecurityRealm.java src/main/resources/hudson/plugins/active_directory/ActiveDirectorySecurityRealm/_config.jelly src/main/resources/hudson/plugins/active_directory/ActiveDirectorySecurityRealm/config.jelly src/main/resources/hudson/plugins/active_directory/ActiveDirectorySecurityRealm/configAdvanced.jelly src/main/resources/hudson/plugins/active_directory/ActiveDirectorySecurityRealm/configAdvanced_pt_BR.properties src/main/resources/hudson/plugins/active_directory/ActiveDirectorySecurityRealm/config_de.properties http://jenkins-ci.org/commit/active-directory-plugin/b54418bf613cfc9d03b470b55199fb4a998d3926 Log: [FIXED JENKINS-27763] reworked the UI. De-emphasize the domain name setting in the ADSI mode, but once the user selects that, expose the entire set of options that the LDAP mode has. Compare: https://github.com/jenkinsci/active-directory-plugin/compare/1c7438895c9a...b54418bf613c
            scm_issue_link SCM/JIRA link daemon made changes -
            Field Original Value New Value
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            danielbeck Daniel Beck made changes -
            Link This issue is duplicated by JENKINS-24248 [ JENKINS-24248 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 162310 ] JNJira + In-Review [ 196932 ]

            People

              Unassigned Unassigned
              kohsuke Kohsuke Kawaguchi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: