-
Improvement
-
Resolution: Fixed
-
Minor
-
Windows Server 2012, Jenkins 1.589, Warnings-Plugin 4.4.7
Hi there,
as statet in this MSDN blog post a MSBuild-Warning may contain a subcategory, like in this real warning (note the additional word "Hint")
E:\workspace\project\subdir\file.sub1.sub2.pas(4522): Hint warning H2164: Variable 'lTaskDialog' is declared but never used in 'TDialog.ShowTaskDialog' [E:\workspace\projext\subdir\project.dproj]
Unfortunately the pre-shipped parser MSBuild does not recognise those kind of warning (or error, info,...)
The regular expression attached in MSBuild_pattern_subcategory.txt
solved that problem for us.
We are using a custom parser for now, but it might be desirable to change
the pattern in default MSBuild Parser as the one attached is more close to the default behaviour in msbuild (see blog post).
[JENKINS-27914] MSBuild-Parser ignores optional Subcategory
JAM Software
created issue -
JAM Software
made changes -
| Attachment | New: MSBuild_pattern_subcategory.txt [ 29444 ] |
JAM Software
made changes -
| Description |
Original:
Hi there, as statet in [this MSDN blog post|http://blogs.msdn.com/b/msbuild/archive/2006/11/03/msbuild-visual-studio-aware-error-messages-and-message-formats.aspx] a MSBuild-Warning may contain a subcategory, like in this real warning (note the additional word "Hint") {quote} E:\workspace\project\subdir\file.sub1.sub2.pas(4522): *Hint* warning H2164: Variable 'lTaskDialog' is declared but never used in 'TDialog.ShowTaskDialog' [E:\workspace\projext\subdir\project.dproj] {quote} Unfortunately the pre-shipped parser MSBuild does not recognise those kind of warning (or error, info,...) The regular expression attached in[^MSBuild_pattern_subcategory.txt] solved that problem for us. We are using a custom parser for now, but it might be desirable to change the pattern in default MSBuild Parser as the one attached is more close to the default behaviour in msbuild (see blog post). Links: [MSDN blog post on VisualStudio error Messages|http://blogs.msdn.com/b/msbuild/archive/2006/11/03/msbuild-visual-studio-aware-error-messages-and-message-formats.aspx] |
New:
Hi there, as statet in [this MSDN blog post|http://blogs.msdn.com/b/msbuild/archive/2006/11/03/msbuild-visual-studio-aware-error-messages-and-message-formats.aspx] a MSBuild-Warning may contain a subcategory, like in this real warning (note the additional word "Hint") {quote} E:\workspace\project\subdir\file.sub1.sub2.pas(4522): *Hint* warning H2164: Variable 'lTaskDialog' is declared but never used in 'TDialog.ShowTaskDialog' [E:\workspace\projext\subdir\project.dproj] {quote} Unfortunately the pre-shipped parser MSBuild does not recognise those kind of warning (or error, info,...) The regular expression attached in [^MSBuild_pattern_subcategory.txt] solved that problem for us. We are using a custom parser for now, but it might be desirable to change the pattern in default MSBuild Parser as the one attached is more close to the default behaviour in msbuild (see blog post). Links: [MSDN blog post on VisualStudio error Messages|http://blogs.msdn.com/b/msbuild/archive/2006/11/03/msbuild-visual-studio-aware-error-messages-and-message-formats.aspx] |
JAM Software
added a comment - It will take some time, but we are interested.
Might be possible to accomplish a pull request
during the next month.
What kind of test are you referring to? We have
a lack of java developers so i'm a bit curious.
JAM Software
added a comment - It will take some time, but we are interested.
Might be possible to accomplish a pull request
during the next month.
What kind of test are you referring to? We have
a lack of java developers so i'm a bit curious.
One additional test in the class MsBuildParserTest.java that correctly reads an example file in your message format (subcategory). (And the changed regular expression should not break any of the other tests, too 
These tests typically are just a view lines long, you can basically clone this example.
JAM Software
added a comment - Ahh, okay! Thank you very much for clarifying. We will see what we can do 
JAM Software
added a comment - Ahh, okay! Thank you very much for clarifying. We will see what we can do Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/warnings/parser/MsBuildParser.java
src/test/java/hudson/plugins/warnings/parser/MsBuildParserTest.java
src/test/resources/hudson/plugins/warnings/parser/issue27914.txt
http://jenkins-ci.org/commit/warnings-plugin/7d83faece8d4cfba557a664da6bf8f53018debed
Log:
Merge pull request #58 from x3ntrix/master
[FIXED JENKINS-27914] Support of subcategories in MsBuild parser
Compare: https://github.com/jenkinsci/warnings-plugin/compare/81106442ff35...7d83faece8d4
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: Open [ 1 ] | New: Resolved [ 5 ] |
| Workflow | Original: JNJira [ 162508 ] | New: JNJira + In-Review [ 196969 ] |
Interested in providing a pull request (incl. a test) that improves the regular expression?