Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28058

Excessive classes being sent to slave machine

XMLWordPrintable

      The `Computer.getHostName` method sends the `Computer.class` which will send `Jenkins.class` for only logging. This can lead to slow Jenkins startups.

          [JENKINS-28058] Excessive classes being sent to slave machine

          Steven Christou created issue -

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/model/Computer.java
          http://jenkins-ci.org/commit/jenkins/df831325b6623c479dcf4b215415f4523d10530b
          Log:
          [FIXED JENKINS-28058] Don't send a reference to Computer.class over remoting channels

          • Logging added to help diagnose was actually causing Jenkins.class to be initialized on the remoting side

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/model/Computer.java http://jenkins-ci.org/commit/jenkins/df831325b6623c479dcf4b215415f4523d10530b Log: [FIXED JENKINS-28058] Don't send a reference to Computer.class over remoting channels Logging added to help diagnose was actually causing Jenkins.class to be initialized on the remoting side
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/model/Computer.java
          http://jenkins-ci.org/commit/jenkins/3bf6061786404ddb248d978d27302d800bee87ee
          Log:
          Merge pull request #1668 from jenkinsci/dont-send-excessive-classes

          JENKINS-28058 Don't send a reference to Computer.class over remoting channels

          Compare: https://github.com/jenkinsci/jenkins/compare/463b3fff2b86...3bf606178640

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/model/Computer.java http://jenkins-ci.org/commit/jenkins/3bf6061786404ddb248d978d27302d800bee87ee Log: Merge pull request #1668 from jenkinsci/dont-send-excessive-classes JENKINS-28058 Don't send a reference to Computer.class over remoting channels Compare: https://github.com/jenkinsci/jenkins/compare/463b3fff2b86...3bf606178640

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4106
          [FIXED JENKINS-28058] Don't send a reference to Computer.class over remoting channels (Revision df831325b6623c479dcf4b215415f4523d10530b)

          Result = SUCCESS
          stephen connolly : df831325b6623c479dcf4b215415f4523d10530b
          Files :

          • core/src/main/java/hudson/model/Computer.java

          dogfood added a comment - Integrated in jenkins_main_trunk #4106 [FIXED JENKINS-28058] Don't send a reference to Computer.class over remoting channels (Revision df831325b6623c479dcf4b215415f4523d10530b) Result = SUCCESS stephen connolly : df831325b6623c479dcf4b215415f4523d10530b Files : core/src/main/java/hudson/model/Computer.java
          Stephen Connolly made changes -
          Labels New: lts-candidate

          Daniel Beck added a comment -

          stephenconnolly Improvements are not really eligible for backporting. Can this be considered a bug?

          Daniel Beck added a comment - stephenconnolly Improvements are not really eligible for backporting. Can this be considered a bug?

          Stephen Connolly added a comment -

          https://github.com/jenkinsci/jenkins/commit/df831325b6623c479dcf4b215415f4523d10530b#diff-9fafdcd0712c5a5dab3acb4ea168515aR1197 fixes the actual bug. The other lines are improvements but do not actually change any API contracts.

          IMHO the sending over of Jenkins to remote instances is actually a bug

          Stephen Connolly added a comment - https://github.com/jenkinsci/jenkins/commit/df831325b6623c479dcf4b215415f4523d10530b#diff-9fafdcd0712c5a5dab3acb4ea168515aR1197 fixes the actual bug. The other lines are improvements but do not actually change any API contracts. IMHO the sending over of Jenkins to remote instances is actually a bug

          Daniel Beck added a comment -

          So let's just call this a bug and see what happens.

          Daniel Beck added a comment - So let's just call this a bug and see what happens.
          Daniel Beck made changes -
          Issue Type Original: Improvement [ 4 ] New: Bug [ 1 ]

            Unassigned Unassigned
            schristou Steven Christou
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: