Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28073

Join doesn't trigger if downstream project(s) fail

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Suppose Job A has 2 downstream projects B and C. Project D should execute only after both B and C have completed. D should trigger even if either B or C or both fail.
      A
      / \
      B C
      \ /
      D

      However with the current version of join plugin (1.15), D only executes if B and C are stable/success. If either of the downstream job fail, I get this message "Minimum result threshold not met for join project"

      It will be good to have an option where user can force D to run even if B and/or C fail.
      From he description of the Join plugin it seems like it should allow job D to run once B and C have completed (irrespective of whether they pass or fail).
      "This plugin allows a job to be run after all the immediate downstream jobs have completed"

      For example in the use-case where you want to fire an email notification after both B and C have completed OR send test results after B and C tests have been executed etc.

      The code lies in https://svn.jenkins-ci.org/tags/join-1.6/src/main/java/join/JoinAction.java

      Code:
      Result threshold = this.evenIfDownstreamUnstable ? Result.UNSTABLE : Result.SUCCESS;
      if(this.overallResult.isWorseThan(threshold))

      { listener.getLogger().println("Minimum result threshold not met for join project"); }

      There should be an option to lower the threshold to Result.FAIL from the jenkins UI.

        Attachments

          Issue Links

          duplicates

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-24566 Join job should be run even if some or all downstream jobs fail

          • Major - Major loss of function.
          • Open

            Activity

            Ascending order - Click to sort in descending order
            masoomaf Masooma Faquih created issue -
            masoomaf Masooma Faquih made changes -
            Field Original Value New Value
            Priority Minor [ 4 ] Major [ 3 ]
            masoomaf Masooma Faquih made changes -
            Description Suppose Job A has 2 downstream projects B and C. Project D should execute only after both B and C have completed. D should trigger even if either B or C or both fail.
               A
             / \
             B C
             \ /
               D

            However with the current version of join plugin (1.15), D only executes if B and C are stable/success. If either of the downstream job fail, I get this message "Minimum result threshold not met for join project"

            It will be good to have an option where user can force D to run even if B and/or C fail.

            For example in the use-case where you want to fire an email notification after both B and C have completed OR send test results after B and C tests have been executed etc.

            The code lies in https://svn.jenkins-ci.org/tags/join-1.6/src/main/java/join/JoinAction.java

            Code:
             if(this.overallResult.isWorseThan(threshold)) {
                            listener.getLogger().println("Minimum result threshold not met for join project");
                        }

            There should be an option to lower the threshold to Result.FAIL from the jenkins UI.
            		 Suppose Job A has 2 downstream projects B and C. Project D should execute only after both B and C have completed. D should trigger even if either B or C or both fail.
               A
             / \
             B C
             \ /
               D

            However with the current version of join plugin (1.15), D only executes if B and C are stable/success. If either of the downstream job fail, I get this message "Minimum result threshold not met for join project"

            It will be good to have an option where user can force D to run even if B and/or C fail.

            For example in the use-case where you want to fire an email notification after both B and C have completed OR send test results after B and C tests have been executed etc.

            The code lies in https://svn.jenkins-ci.org/tags/join-1.6/src/main/java/join/JoinAction.java

            Code:
             Result threshold = this.evenIfDownstreamUnstable ? Result.UNSTABLE : Result.SUCCESS;
             if(this.overallResult.isWorseThan(threshold)) {
                            listener.getLogger().println("Minimum result threshold not met for join project");
                        }

            There should be an option to lower the threshold to Result.FAIL from the jenkins UI.
            orrc Christopher Orr made changes -
            Component/s join-plugin [ 15635 ]
            Component/s ci [ 18920 ]
            Key INFRA-281 JENKINS-28073
            Project Infrastructure [ 10301 ] Jenkins [ 10172 ]
            Workflow jira [ 162677 ] JNJira [ 162678 ]
            Hide
            Permalink
            orrc Christopher Orr added a comment -

            Moved to JENKINS project as this was incorrectly filed under the INFRA project.

            Show
            orrc Christopher Orr added a comment - Moved to JENKINS project as this was incorrectly filed under the INFRA project.
            orrc Christopher Orr made changes -
            Assignee R. Tyler Croy [ rtyler ] mdonohue [ mdonohue ]
            masoomaf Masooma Faquih made changes -
            Description Suppose Job A has 2 downstream projects B and C. Project D should execute only after both B and C have completed. D should trigger even if either B or C or both fail.
               A
             / \
             B C
             \ /
               D

            However with the current version of join plugin (1.15), D only executes if B and C are stable/success. If either of the downstream job fail, I get this message "Minimum result threshold not met for join project"

            It will be good to have an option where user can force D to run even if B and/or C fail.

            For example in the use-case where you want to fire an email notification after both B and C have completed OR send test results after B and C tests have been executed etc.

            The code lies in https://svn.jenkins-ci.org/tags/join-1.6/src/main/java/join/JoinAction.java

            Code:
             Result threshold = this.evenIfDownstreamUnstable ? Result.UNSTABLE : Result.SUCCESS;
             if(this.overallResult.isWorseThan(threshold)) {
                            listener.getLogger().println("Minimum result threshold not met for join project");
                        }

            There should be an option to lower the threshold to Result.FAIL from the jenkins UI.
            		 Suppose Job A has 2 downstream projects B and C. Project D should execute only after both B and C have completed. D should trigger even if either B or C or both fail.
               A
             / \
             B C
             \ /
               D

            However with the current version of join plugin (1.15), D only executes if B and C are stable/success. If either of the downstream job fail, I get this message "Minimum result threshold not met for join project"

            It will be good to have an option where user can force D to run even if B and/or C fail.
            From he description of the Join plugin it seems like it should allow job D to run once B and C have completed (irrespective of whether they pass or fail).
            "This plugin allows a job to be run after all the immediate downstream jobs have completed"

            For example in the use-case where you want to fire an email notification after both B and C have completed OR send test results after B and C tests have been executed etc.

            The code lies in https://svn.jenkins-ci.org/tags/join-1.6/src/main/java/join/JoinAction.java

            Code:
             Result threshold = this.evenIfDownstreamUnstable ? Result.UNSTABLE : Result.SUCCESS;
             if(this.overallResult.isWorseThan(threshold)) {
                            listener.getLogger().println("Minimum result threshold not met for join project");
                        }

            There should be an option to lower the threshold to Result.FAIL from the jenkins UI.
            Issue Type Improvement [ 4 ] Bug [ 1 ]
            Priority Major [ 3 ] Blocker [ 1 ]
            robsimon robsimon made changes -
            Link This issue duplicates JENKINS-24566 [ JENKINS-24566 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 162678 ] JNJira + In-Review [ 181020 ]

              People

              Assignee:
              mdonohue mdonohue
              Reporter:
              masoomaf Masooma Faquih
              Votes:
              5 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated: