Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28289

JNLP slave should exclude non proxy hosts when connecting via HTTP proxy

      https://issues.jenkins-ci.org/browse/JENKINS-6167
      The fix submitted for this issue does not take into account the excluded proxy hosts unlike the hudson.remoting.Util.openURLConnection method which implicitly excludes hosts.

      A fix using the same method as sun.net.www.protocol.http.HttpURLConnection is available here :
      https://github.com/hypnoce/remoting/commit/67dbd966e628c42a0aa4d3cd91a56a00b7f95030

      Thanks

          [JENKINS-28289] JNLP slave should exclude non proxy hosts when connecting via HTTP proxy

          Francis JAC created issue -

          Francis JAC added a comment -

          Hi,

          any news on that point ? Is the fix provided suitable for a pull request ?

          Thanks

          François

          Francis JAC added a comment - Hi, any news on that point ? Is the fix provided suitable for a pull request ? Thanks François

          Daniel Beck added a comment -

          Could you submit your fix as a pull request to remoting?

          Daniel Beck added a comment - Could you submit your fix as a pull request to remoting?

          Francis JAC added a comment -

          Francis JAC added a comment - Hello, done : https://github.com/jenkinsci/remoting/pull/55 Thanks.
          James Nord made changes -
          Remote Link New: This issue links to "PR#55 (Web Link)" [ 13144 ]

          Evan Wee added a comment -

          Would you mind resolving the conflict and resubmitting the pull request?

          Evan Wee added a comment - Would you mind resolving the conflict and resubmitting the pull request?

          Evan Wee added a comment -

          I currently do not have a workaround for this.

          Evan Wee added a comment - I currently do not have a workaround for this.
          Evan Wee made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          Evan Wee made changes -
          Description Original: https://issues.jenkins-ci.org/browse/JENKINS-6167
          The fix submitted for this issue does not take into account the excluded proxy hosts unlike the hudson.remoting.Util.openURLConnection method which implicitly excludes hosts.

          A fix using the same method as sun.net.www.protocol.http.HttpURLConnection is available here :
          https://github.com/hypnoce/remoting/commit/67dbd966e628c42a0aa4d3cd91a56a00b7f95030

          Thanks
          New: https://issues.jenkins-ci.org/browse/JENKINS-6167
          The fix submitted for this issue does not take into account the excluded proxy hosts unlike the hudson.remoting.Util.openURLConnection method which implicitly excludes hosts.

          A fix using the same method as sun.net.www.protocol.http.HttpURLConnection is available here :
          https://github.com/hypnoce/remoting/commit/67dbd966e628c42a0aa4d3cd91a56a00b7f95030

          Thanks

          EDIT:
          An updated fix that resolves conflicts is here:
          https://github.com/jenkinsci/remoting/pull/62
          https://github.com/evanx9/remoting/commit/cb2ded8e8ba6a67dd5996a7ca90a2f4f133ec8eb
          Evan Wee made changes -
          Remote Link New: This issue links to "PR#62 (Web Link)" [ 13170 ]

            Unassigned Unassigned
            hypnoce Francis JAC
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: