Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28292

Setting JDK installations not thread-safe

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Due to improper synchronization, it's possible that the list of JDKs is empty while adding or removing one. See https://github.com/jenkinsci/jenkins/blob/jenkins-1.612/core/src/main/java/hudson/model/JDK.java#L170.

        Attachments

          Issue Links

            Activity

            daspilker Daniel Spilker created issue -
            Hide
            daspilker Daniel Spilker added a comment -
            Show
            daspilker Daniel Spilker added a comment - See https://github.com/jenkinsci/jenkins/pull/1692 for a fix.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Spilker
            Path:
            core/src/main/java/hudson/model/JDK.java
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/44eeb10461b0f49fe6c0125a9727f57480d10f10
            Log:
            JENKINS-28292 fixed synchronization issue

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: core/src/main/java/hudson/model/JDK.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/44eeb10461b0f49fe6c0125a9727f57480d10f10 Log: JENKINS-28292 fixed synchronization issue
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/JDK.java
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/67f4dd516633a5ef0f6d0085c0f1b90c5ebf3c8e
            Log:
            Merge pull request #1692 from daspilker/JENKINS-28292

            JENKINS-28292 fixed synchronization issue when setting JDK installations

            Compare: https://github.com/jenkinsci/jenkins/compare/3f0e2926c01b...67f4dd516633

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/JDK.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/67f4dd516633a5ef0f6d0085c0f1b90c5ebf3c8e Log: Merge pull request #1692 from daspilker/ JENKINS-28292 JENKINS-28292 fixed synchronization issue when setting JDK installations Compare: https://github.com/jenkinsci/jenkins/compare/3f0e2926c01b...67f4dd516633
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4177

            Result = SUCCESS

            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4177 Result = SUCCESS
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Labels lts-candidate
            Hide
            daspilker Daniel Spilker added a comment -

            Has been fixed in 1.618.

            Show
            daspilker Daniel Spilker added a comment - Has been fixed in 1.618.
            daspilker Daniel Spilker made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            Hide
            olivergondza Oliver Gondža added a comment -

            Removing lts-candidate label as it is a part of 1.625 baseline.

            Show
            olivergondza Oliver Gondža added a comment - Removing lts-candidate label as it is a part of 1.625 baseline.
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate
            lkarnasiewicz Lukasz Karnasiewicz made changes -
            Link This issue is related to JENKINS-31932 [ JENKINS-31932 ]
            Hide
            lkarnasiewicz Lukasz Karnasiewicz added a comment -
            Show
            lkarnasiewicz Lukasz Karnasiewicz added a comment - Caused JENKINS-31932
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 163126 ] JNJira + In-Review [ 197108 ]

              People

              Assignee:
              daspilker Daniel Spilker
              Reporter:
              daspilker Daniel Spilker
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: