Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28689

Make SSH Agent Plugin compatible with Workflow

XMLWordPrintable

      SSHAgentBuildWrapper as SimpleBuildWrapper

      Making SSHAgentBuildWrapper be a SimpleBuildWrapper would allow it to be used from Workflow builds. The tricky part is that AgentServer cannot be made Serializable. So perhaps a proxy needs to be stored which could call RemoteAgentFactory.start after a Jenkins restart.

          [JENKINS-28689] Make SSH Agent Plugin compatible with Workflow

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/workflow-plugin/54ead25320cfec7eee5af3f33ec45df6ece6c402
          Log:
          JENKINS-28689 Noting.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/54ead25320cfec7eee5af3f33ec45df6ece6c402 Log: JENKINS-28689 Noting.

          Jesse Glick added a comment -

          Specifically for SSHAgentEnvironment to be refactored into a Disposer, which must be serializable, it cannot hold a (non-transient) RemoteAgent reference, since the implementations of that hold on to an AgentServer, which is a live socket. So the Disposer implementation must instead keep a reference to whatever information is necessary to reconstruct a RemoteAgent after deserialization, i.e. whatever information the current SSHAgentEnvironment currently relies on.

          Jesse Glick added a comment - Specifically for SSHAgentEnvironment to be refactored into a Disposer , which must be serializable, it cannot hold a (non- transient ) RemoteAgent reference, since the implementations of that hold on to an AgentServer , which is a live socket. So the Disposer implementation must instead keep a reference to whatever information is necessary to reconstruct a RemoteAgent after deserialization, i.e. whatever information the current SSHAgentEnvironment currently relies on.

          Manuel Recena Soto added a comment -

          jglick, thanks so much for your clue. At this moment, I'm diving in the source source to get used to the classes, terms, etc.

          Manuel Recena Soto added a comment - jglick , thanks so much for your clue. At this moment, I'm diving in the source source to get used to the classes, terms, etc.

          Manuel Recena Soto added a comment -

          This plugin will require Jenkins baseline 1.599 because SimpleBuildWrapper was introduced in this version.

          Manuel Recena Soto added a comment - This plugin will require Jenkins baseline 1.599 because SimpleBuildWrapper was introduced in this version.

          Manuel Recena Soto added a comment -

          If you want to know the full thread of this ticket, I invite you to take a look to this PR

          Manuel Recena Soto added a comment - If you want to know the full thread of this ticket, I invite you to take a look to this PR

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/846bc99eeb5ce40176eaab2f254edbaea462f147
          Log:
          JENKINS-28689 Make compatible with Workflow plugin

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java http://jenkins-ci.org/commit/ssh-agent-plugin/846bc99eeb5ce40176eaab2f254edbaea462f147 Log: JENKINS-28689 Make compatible with Workflow plugin

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/5f0f54bbc6950c05826dc228b7b7582898d368b4
          Log:
          JENKINS-28689 Make compatible with Workflow plugin

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java http://jenkins-ci.org/commit/ssh-agent-plugin/5f0f54bbc6950c05826dc228b7b7582898d368b4 Log: JENKINS-28689 Make compatible with Workflow plugin

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/f850c52c941246fb37a544f6f08468ebedcc270d
          Log:
          JENKINS-28689 Make compatible with Workflow plugin

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java http://jenkins-ci.org/commit/ssh-agent-plugin/f850c52c941246fb37a544f6f08468ebedcc270d Log: JENKINS-28689 Make compatible with Workflow plugin

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentSimpleBuildWrapperTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentSimpleBuildWrapperWorkflowTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/646ae6128ac0b36bd5c7273626569ec1fa167364
          Log:
          JENKINS-28689 Added a new test (sshAgentAvailable)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentSimpleBuildWrapperTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentSimpleBuildWrapperWorkflowTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/646ae6128ac0b36bd5c7273626569ec1fa167364 Log: JENKINS-28689 Added a new test (sshAgentAvailable)

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          pom.xml
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/EchoShellFactory.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHServerTest.java
          src/test/resources/com/cloudbees/jenkins/plugins/sshagent/sshkey
          src/test/resources/com/cloudbees/jenkins/plugins/sshagent/sshkey.pub
          http://jenkins-ci.org/commit/ssh-agent-plugin/c08b1ddf5257ce72391e85df95825b76141125e3
          Log:
          JENKINS-28689 Adding a POC for a basic mock SSH Server

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: pom.xml src/test/java/com/cloudbees/jenkins/plugins/sshagent/EchoShellFactory.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHServerTest.java src/test/resources/com/cloudbees/jenkins/plugins/sshagent/sshkey src/test/resources/com/cloudbees/jenkins/plugins/sshagent/sshkey.pub http://jenkins-ci.org/commit/ssh-agent-plugin/c08b1ddf5257ce72391e85df95825b76141125e3 Log: JENKINS-28689 Adding a POC for a basic mock SSH Server

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHServerTest.java
          src/test/resources/com/cloudbees/jenkins/plugins/sshagent/authorized_keys
          http://jenkins-ci.org/commit/ssh-agent-plugin/7d1b6205cd71cc3844445ee1ca2d5240521c4e65
          Log:
          JENKINS-28689 Adding a POC for a basic mock SSH Server

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHServerTest.java src/test/resources/com/cloudbees/jenkins/plugins/sshagent/authorized_keys http://jenkins-ci.org/commit/ssh-agent-plugin/7d1b6205cd71cc3844445ee1ca2d5240521c4e65 Log: JENKINS-28689 Adding a POC for a basic mock SSH Server

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/EchoShellFactory.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentSimpleBuildWrapperTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentSimpleBuildWrapperWorkflowTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHServerTest.java
          src/test/resources/com/cloudbees/jenkins/plugins/sshagent/authorized_keys
          http://jenkins-ci.org/commit/ssh-agent-plugin/9ea550e9f728ca314c2d87e96fb253663dc97753
          Log:
          JENKINS-28689 SSHAgentBuildWrapperTest has been adapted to use the mock SSH Server

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/test/java/com/cloudbees/jenkins/plugins/sshagent/EchoShellFactory.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentSimpleBuildWrapperTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentSimpleBuildWrapperWorkflowTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHServerTest.java src/test/resources/com/cloudbees/jenkins/plugins/sshagent/authorized_keys http://jenkins-ci.org/commit/ssh-agent-plugin/9ea550e9f728ca314c2d87e96fb253663dc97753 Log: JENKINS-28689 SSHAgentBuildWrapperTest has been adapted to use the mock SSH Server

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          http://jenkins-ci.org/commit/ssh-agent-plugin/6dbe8adbdf1cd8772429a0c91f67f28c718d496a
          Log:
          JENKINS-28689 Merge upstream master

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml http://jenkins-ci.org/commit/ssh-agent-plugin/6dbe8adbdf1cd8772429a0c91f67f28c718d496a Log: JENKINS-28689 Merge upstream master

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperRestartingWorkflowTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/fdb63508f49989ba08ee8f4c0890e4be819d70dc
          Log:
          JENKINS-28689 Tests has been reviewed. Clean up source code

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperRestartingWorkflowTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/fdb63508f49989ba08ee8f4c0890e4be819d70dc Log: JENKINS-28689 Tests has been reviewed. Clean up source code

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperRestartingWorkflowTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java
          src/test/resources/com/cloudbees/jenkins/plugins/sshagent/sshkey
          src/test/resources/com/cloudbees/jenkins/plugins/sshagent/sshkey.pub
          http://jenkins-ci.org/commit/ssh-agent-plugin/96e792fc067297828f1a87839ddc60a7ac4bc42c
          Log:
          JENKINS-28689 Tests has been reviewed. Clean up source code

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperRestartingWorkflowTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java src/test/resources/com/cloudbees/jenkins/plugins/sshagent/sshkey src/test/resources/com/cloudbees/jenkins/plugins/sshagent/sshkey.pub http://jenkins-ci.org/commit/ssh-agent-plugin/96e792fc067297828f1a87839ddc60a7ac4bc42c Log: JENKINS-28689 Tests has been reviewed. Clean up source code

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/2e3e1d3373c331cfc63da67568f63175fed301dc
          Log:
          JENKINS-28689 Improved the way how Mocked SSH Server is launched. Changes proposed by Jesse

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/2e3e1d3373c331cfc63da67568f63175fed301dc Log: JENKINS-28689 Improved the way how Mocked SSH Server is launched. Changes proposed by Jesse

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/c3b7490db08b679a172c0144a8d1e67207b54220
          Log:
          JENKINS-28689 Compilation errors

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java http://jenkins-ci.org/commit/ssh-agent-plugin/c3b7490db08b679a172c0144a8d1e67207b54220 Log: JENKINS-28689 Compilation errors

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/010e968ab2ff8efa23a51d56d9046329140c96b5
          Log:
          JENKINS-28689 First source code modifications related to SSHAgentStep, DescriptorImpl and SSHAgentExecution

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java http://jenkins-ci.org/commit/ssh-agent-plugin/010e968ab2ff8efa23a51d56d9046329140c96b5 Log: JENKINS-28689 First source code modifications related to SSHAgentStep, DescriptorImpl and SSHAgentExecution

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html
          http://jenkins-ci.org/commit/ssh-agent-plugin/88ecd65d6f1273e603b34611cb0a8a215a3e2530
          Log:
          JENKINS-28689 Implemented SSHAgentStep, DescriptorImpl and SSHAgentExecution. Removed everything related to the proposal based on SimpleBuildWrapper

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentDisposer.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html http://jenkins-ci.org/commit/ssh-agent-plugin/88ecd65d6f1273e603b34611cb0a8a215a3e2530 Log: JENKINS-28689 Implemented SSHAgentStep, DescriptorImpl and SSHAgentExecution. Removed everything related to the proposal based on SimpleBuildWrapper

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/17ca77fa7abaa55f30b8c5a9a17bb10de11a3874
          Log:
          JENKINS-28689 Tests has been adapted to AbstractStepImpl

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/17ca77fa7abaa55f30b8c5a9a17bb10de11a3874 Log: JENKINS-28689 Tests has been adapted to AbstractStepImpl

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/790c96d72f14364ec8adb53318ecdba347a2571d
          Log:
          JENKINS-28689 Setting the SSH_AUTH_SOCK environment variable properly

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java http://jenkins-ci.org/commit/ssh-agent-plugin/790c96d72f14364ec8adb53318ecdba347a2571d Log: JENKINS-28689 Setting the SSH_AUTH_SOCK environment variable properly

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/19d632860e5cbf3c0fa6aa4bb999ee020c223a1c
          Log:
          JENKINS-28689 Fixed finbugs issue

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java http://jenkins-ci.org/commit/ssh-agent-plugin/19d632860e5cbf3c0fa6aa4bb999ee020c223a1c Log: JENKINS-28689 Fixed finbugs issue

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html
          http://jenkins-ci.org/commit/ssh-agent-plugin/12c5e1ea42ca815f63eb9cfa3a2019aeec44f3b7
          Log:
          JENKINS-28689 Removed a deprecated annotation. Minor refactors

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html http://jenkins-ci.org/commit/ssh-agent-plugin/12c5e1ea42ca815f63eb9cfa3a2019aeec44f3b7 Log: JENKINS-28689 Removed a deprecated annotation. Minor refactors

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/fa47b4ab2159bd5d295a4da48e1f884f126ffd23
          Log:
          JENKINS-28689 Solved some implementation mistakes

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java http://jenkins-ci.org/commit/ssh-agent-plugin/fa47b4ab2159bd5d295a4da48e1f884f126ffd23 Log: JENKINS-28689 Solved some implementation mistakes

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/cd0f6305f74d65821f43f618057a09b6f20dca01
          Log:
          JENKINS-28689 Removed unused imports

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java http://jenkins-ci.org/commit/ssh-agent-plugin/cd0f6305f74d65821f43f618057a09b6f20dca01 Log: JENKINS-28689 Removed unused imports

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/4413aa8ecc20c8b34d3d49f22eded3a9165a856f
          Log:
          JENKINS-28689 Added two tests (sshAgentUnavailable, sshAgentWithInvalidCredentials)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/4413aa8ecc20c8b34d3d49f22eded3a9165a856f Log: JENKINS-28689 Added two tests (sshAgentUnavailable, sshAgentWithInvalidCredentials)

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/22bfebb76110287c1e465bd0783fceb8d2b79513
          Log:
          JENKINS-28689 onResume() is never invoked

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperWorkflowTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/22bfebb76110287c1e465bd0783fceb8d2b79513 Log: JENKINS-28689 onResume() is never invoked

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/980f3032114567e1f8812ec3e82377404fd7887a
          Log:
          JENKINS-28689 Using Workflow 1.9-beta-2-SNAPSHOT

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java http://jenkins-ci.org/commit/ssh-agent-plugin/980f3032114567e1f8812ec3e82377404fd7887a Log: JENKINS-28689 Using Workflow 1.9-beta-2-SNAPSHOT

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/58ea933ce7821ead2a042be499a8a380fa9a671a
          Log:
          JENKINS-28689 Added purgeSockets() method. Reviewed Callback implementation

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java http://jenkins-ci.org/commit/ssh-agent-plugin/58ea933ce7821ead2a042be499a8a380fa9a671a Log: JENKINS-28689 Added purgeSockets() method. Reviewed Callback implementation

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/7b41d49c21fa0e32388fc65eb25d0daa900ff37f
          Log:
          JENKINS-28689 Fixed some reviews suggested

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/7b41d49c21fa0e32388fc65eb25d0daa900ff37f Log: JENKINS-28689 Fixed some reviews suggested

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/88a22245645d2546e1e75f6f737290df97fed915
          Log:
          JENKINS-28689 Fixed some reviews suggested

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/88a22245645d2546e1e75f6f737290df97fed915 Log: JENKINS-28689 Fixed some reviews suggested

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/7ce22bfa8fc8cd9ceb72ad9070b8e8a9cd4351cc
          Log:
          JENKINS-28689 cleanUp method has been moved from Callback to SSHAgentStepExecution

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java http://jenkins-ci.org/commit/ssh-agent-plugin/7ce22bfa8fc8cd9ceb72ad9070b8e8a9cd4351cc Log: JENKINS-28689 cleanUp method has been moved from Callback to SSHAgentStepExecution

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper/config.jelly
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/config.jelly
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html
          http://jenkins-ci.org/commit/ssh-agent-plugin/bc0dd37381e1316f276401bee34464bd78e90426
          Log:
          JENKINS-28689 Snippet Generator is working

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper/config.jelly src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/config.jelly src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html http://jenkins-ci.org/commit/ssh-agent-plugin/bc0dd37381e1316f276401bee34464bd78e90426 Log: JENKINS-28689 Snippet Generator is working

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html
          http://jenkins-ci.org/commit/ssh-agent-plugin/ee6ce32149a3f71651bf29c230efcad3d5de7303
          Log:
          JENKINS-28689 help.html has been reviewed

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html http://jenkins-ci.org/commit/ssh-agent-plugin/ee6ce32149a3f71651bf29c230efcad3d5de7303 Log: JENKINS-28689 help.html has been reviewed

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/0cefdd3c52ae8d9c8b0f0e1e4646b7066b8e2085
          Log:
          JENKINS-28689 Serial Version UIDs has been reviewed following the Stephen's recommendations

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java http://jenkins-ci.org/commit/ssh-agent-plugin/0cefdd3c52ae8d9c8b0f0e1e4646b7066b8e2085 Log: JENKINS-28689 Serial Version UIDs has been reviewed following the Stephen's recommendations

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/050eebf746e2f8b33a5430d234613d13439dd8d7
          Log:
          JENKINS-28689 Included javadocs to explain that these SerialVersionUID was generated from 1.7

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java http://jenkins-ci.org/commit/ssh-agent-plugin/050eebf746e2f8b33a5430d234613d13439dd8d7 Log: JENKINS-28689 Included javadocs to explain that these SerialVersionUID was generated from 1.7

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper/config.jelly
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/config.jelly
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/5a72bf85a7ec500e8e3a80ac60690da4be03e077
          Log:
          Merge pull request #4 from recena/JENKINS-28689

          JENKINS-28689 Make compatible with Workflow plugin

          Compare: https://github.com/jenkinsci/ssh-agent-plugin/compare/7c398955f660...5a72bf85a7ec

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper/config.jelly src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/config.jelly src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/5a72bf85a7ec500e8e3a80ac60690da4be03e077 Log: Merge pull request #4 from recena/ JENKINS-28689 JENKINS-28689 Make compatible with Workflow plugin Compare: https://github.com/jenkinsci/ssh-agent-plugin/compare/7c398955f660...5a72bf85a7ec

          Manuel Recena Soto added a comment -

          This feature will be released coming soon.

          Manuel Recena Soto added a comment - This feature will be released coming soon.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/workflow-plugin/4f5e0afa6bd5dff7f9d64c4a4dd1af814b6c37bc
          Log:
          JENKINS-28689 Noting release of ssh-agent 1.8.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/4f5e0afa6bd5dff7f9d64c4a4dd1af814b6c37bc Log: JENKINS-28689 Noting release of ssh-agent 1.8.

            recena Manuel Recena Soto
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: