Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28689

Make SSH Agent Plugin compatible with Workflow

XMLWordPrintable

      SSHAgentBuildWrapper as SimpleBuildWrapper

      Making SSHAgentBuildWrapper be a SimpleBuildWrapper would allow it to be used from Workflow builds. The tricky part is that AgentServer cannot be made Serializable. So perhaps a proxy needs to be stored which could call RemoteAgentFactory.start after a Jenkins restart.

          [JENKINS-28689] Make SSH Agent Plugin compatible with Workflow

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue depends on JENKINS-24673 [ JENKINS-24673 ]
          Jesse Glick made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/workflow-plugin/54ead25320cfec7eee5af3f33ec45df6ece6c402
          Log:
          JENKINS-28689 Noting.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/54ead25320cfec7eee5af3f33ec45df6ece6c402 Log: JENKINS-28689 Noting.
          Manuel Recena Soto made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Manuel Recena Soto made changes -
          Assignee New: Manuel Recena Soto [ recena ]

          Jesse Glick added a comment -

          Specifically for SSHAgentEnvironment to be refactored into a Disposer, which must be serializable, it cannot hold a (non-transient) RemoteAgent reference, since the implementations of that hold on to an AgentServer, which is a live socket. So the Disposer implementation must instead keep a reference to whatever information is necessary to reconstruct a RemoteAgent after deserialization, i.e. whatever information the current SSHAgentEnvironment currently relies on.

          Jesse Glick added a comment - Specifically for SSHAgentEnvironment to be refactored into a Disposer , which must be serializable, it cannot hold a (non- transient ) RemoteAgent reference, since the implementations of that hold on to an AgentServer , which is a live socket. So the Disposer implementation must instead keep a reference to whatever information is necessary to reconstruct a RemoteAgent after deserialization, i.e. whatever information the current SSHAgentEnvironment currently relies on.
          Manuel Recena Soto made changes -
          Summary Original: SSHAgentBuildWrapper as SimpleBuildWrapper New: Make compatible with Workflow plugin
          Manuel Recena Soto made changes -
          Description Original: Making {{SSHAgentBuildWrapper}} be a {{SimpleBuildWrapper}} would allow it to be used from Workflow builds. The tricky part is that {{AgentServer}} cannot be made {{Serializable}}. So perhaps a proxy needs to be stored which could call {{RemoteAgentFactory.start}} after a Jenkins restart. New: h4. SSHAgentBuildWrapper as SimpleBuildWrapper

          Making {{SSHAgentBuildWrapper}} be a {{SimpleBuildWrapper}} would allow it to be used from Workflow builds. The tricky part is that {{AgentServer}} cannot be made {{Serializable}}. So perhaps a proxy needs to be stored which could call {{RemoteAgentFactory.start}} after a Jenkins restart.
          Manuel Recena Soto made changes -
          Description Original: h4. SSHAgentBuildWrapper as SimpleBuildWrapper

          Making {{SSHAgentBuildWrapper}} be a {{SimpleBuildWrapper}} would allow it to be used from Workflow builds. The tricky part is that {{AgentServer}} cannot be made {{Serializable}}. So perhaps a proxy needs to be stored which could call {{RemoteAgentFactory.start}} after a Jenkins restart.           		New: *SSHAgentBuildWrapper as SimpleBuildWrapper*

          Making {{SSHAgentBuildWrapper}} be a {{SimpleBuildWrapper}} would allow it to be used from Workflow builds. The tricky part is that {{AgentServer}} cannot be made {{Serializable}}. So perhaps a proxy needs to be stored which could call {{RemoteAgentFactory.start}} after a Jenkins restart.

            recena Manuel Recena Soto
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: