-
New Feature
-
Resolution: Fixed
-
Major
-
Powered by SuggestiMate
Add support for "Manage Ownership" on folders
- depends on
-
JENKINS-32359 Folders do not always persist assigned folder properties
-
- Resolved
-
- is related to
-
JENKINS-32309 CloudBees Folder Items should allow contributing summary info from actions
-
- Resolved
-
- links to
[JENKINS-28881] Add support for CloudBees folder plugin
I've been digging through the code, and Ownership is doing Permission check on "jobs", which I thought Folders are classified as, but maybe not?? Will keep digging, but this may bump over to being an enhance on Folders, we'll see ...
After a couple of days trying to figure out why I was not able to mix ownership and folder I finally found this bug and I happy I'm not alone with this issue.
Is there any ETA for that ?
The pull request is ready: https://github.com/jenkinsci/ownership-plugin/pull/44
BTW I still need to get a fix of JENKINS-32359 before the release
Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/OwnershipActionFactory.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipAction.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipActionFactory.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipHelper.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipProperty.java
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/ItemOwnershipAction/propertyConfig.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipAction/index.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipAction/manage-owners.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipProperty/config.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipProperty/summary.jelly
src/test/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipTest.java
http://jenkins-ci.org/commit/ownership-plugin/1458f9358784c43f1369fa53e4c66722873f3b16
Log:
JENKINS-28881 - Implementation of Ownership property injection
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipProperty.java
http://jenkins-ci.org/commit/ownership-plugin/0be133350496b89778cb0434e05ababccfb4cea3
Log:
JENKINS-28881 - Prevent FolderOwnershipProperty changes on the configuration submission
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/extensions/item_ownership_policy/AssignCreatorPolicy.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderItemListener.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipProperty.java
src/test/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipTest.java
http://jenkins-ci.org/commit/ownership-plugin/206a36c085f35c2a06966af6aca6ea8f80772bc3
Log:
JENKINS-28881 - Support AssignCreatorPolicy for Folders
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerHelper.java
src/main/java/org/jenkinsci/plugins/ownership/model/OwnershipHelperLocator.java
src/test/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerHelperTest.java
http://jenkins-ci.org/commit/ownership-plugin/4afd8a3cdc3d96c3885340112a13144f74742b77
Log:
JENKINS-28881 - Add OwnershipHelperLocator extension point
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/OwnershipDescription.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipHelper.java
src/test/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipHelperTest.java
src/test/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipTest.java
http://jenkins-ci.org/commit/ownership-plugin/8207da507ed68942bb98af1f648e16e671165f6a
Log:
JENKINS-28881 - Support inheritance of Ownership info from folders
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/security/rolestrategy/AbstractOwnershipRoleMacro.java
src/main/java/org/jenkinsci/plugins/ownership/model/runs/RunOwnershipHelper.java
http://jenkins-ci.org/commit/ownership-plugin/74b81be6cf8d5197abf8dc03e8bdf9984c7589a2
Log:
JENKINS-28881 - Fix several issues with explicit JobOwnerProperty usage impacting the inheritance
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerHelper.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/nodes/ComputerOwnerHelper.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/nodes/NodeOwnerHelper.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/nodes/NodeOwnerPropertyHelper.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/util/AbstractOwnershipHelper.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipDescriptionSource.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipHelper.java
src/main/java/org/jenkinsci/plugins/ownership/model/OwnershipDescriptionSource.java
src/main/java/org/jenkinsci/plugins/ownership/model/OwnershipHelperLocator.java
src/main/java/org/jenkinsci/plugins/ownership/model/OwnershipInfo.java
src/main/java/org/jenkinsci/plugins/ownership/model/jobs/JobOwnershipDescriptionSource.java
src/main/java/org/jenkinsci/plugins/ownership/model/nodes/NodeOwnershipDescriptionSource.java
src/main/java/org/jenkinsci/plugins/ownership/model/runs/RunOwnershipHelper.java
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/ItemOwnershipAction/ownershipSource.jelly
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/ItemOwnershipAction/ownershipSource.properties
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerJobAction/manage-owners.jelly
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/nodes/NodeOwnershipAction/manage-owners.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipAction/manage-owners.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipDescriptionSource/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/OwnershipDescriptionSource/DisabledSource/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/OwnershipDescriptionSource/DisabledSource/summary.properties
src/main/resources/org/jenkinsci/plugins/ownership/model/jobs/JobOwnershipDescriptionSource/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/nodes/NodeOwnershipDescriptionSource/summary.jelly
src/test/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipTest.java
http://jenkins-ci.org/commit/ownership-plugin/cd1568f63f2c1480a0b57c69768ae19eb824c521
Log:
JENKINS-28881 - Extend the internal implementation to allow displaying the ownership info source
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipAction.java
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipAction/summary.jelly
http://jenkins-ci.org/commit/ownership-plugin/f5357c99c4f98e553d63d9f98b920cf833abbd76
Log:
JENKINS-28881 - Display Ownership summary boxes for Folders
Code changed in jenkins
User: Oleg Nenashev
Path:
src/test/java/com/synopsys/arc/jenkins/plugins/ownership/wrappers/OwnershipBuildWrapperTest.java
src/test/java/org/jenkinsci/plugins/ownership/model/runs/RunOwnershipActionTest.java
http://jenkins-ci.org/commit/ownership-plugin/1e3e70fb08a59ca70359fd22379c98f13c7b5745
Log:
JENKINS-28881 - Add Folder ownership tests for Run components
Code changed in jenkins
User: Oleg Nenashev
Path:
src/test/java/org/jenkinsci/plugins/ownership/security/rolestrategy/OwnershipBasedSecurityTest.java
src/test/java/org/jenkinsci/plugins/ownership/security/rolestrategy/OwnershipBasedSecurityTestHelper.java
http://jenkins-ci.org/commit/ownership-plugin/535baec000a54decbd214ba6a3206f28f4736e34
Log:
JENKINS-28881 - Add unit tests for Ownership-based security
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerHelper.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/OwnershipActionFactory.java
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/ItemOwnershipAction/ownershipSource.properties
http://jenkins-ci.org/commit/ownership-plugin/6302e837890622d69b99a7534cf1b5523afd96c4
Log:
JENKINS-28881 - Amend ownershipSource warning message according to comments from @olivergondza
Also fixes minor formatting issues
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderItemListener.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipAction.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipActionFactory.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipDescriptionSource.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipHelper.java
src/main/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipProperty.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderItemListener.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipAction.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipActionFactory.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipDescriptionSource.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipHelper.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipProperty.java
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipAction/index.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipAction/manage-owners.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipAction/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipDescriptionSource/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipProperty/config.jelly
src/main/resources/org/jenkinsci/plugins/ownership/folders/FolderOwnershipProperty/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipAction/index.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipAction/manage-owners.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipAction/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipDescriptionSource/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipProperty/config.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipProperty/summary.jelly
src/test/java/com/synopsys/arc/jenkins/plugins/ownership/wrappers/OwnershipBuildWrapperTest.java
src/test/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipHelperTest.java
src/test/java/org/jenkinsci/plugins/ownership/folders/FolderOwnershipTest.java
src/test/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipHelperTest.java
src/test/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipTest.java
src/test/java/org/jenkinsci/plugins/ownership/model/runs/RunOwnershipActionTest.java
src/test/java/org/jenkinsci/plugins/ownership/security/rolestrategy/OwnershipBasedSecurityTest.java
http://jenkins-ci.org/commit/ownership-plugin/e5039a9220b6718501a5aa40c5e1d9a394c3426e
Log:
JENKINS-28881 - Move Folder files. Folders belong to the model
Code changed in jenkins
User: Oleg Nenashev
Path:
src/test/java/org/jenkinsci/plugins/ownership/security/jobrestrictions/OwnersListJobRestrictionTest.java
http://jenkins-ci.org/commit/ownership-plugin/8d1fd0e36e7d36397708c2a657f6803ec3259bff
Log:
JENKINS-28881 - Tests of the JobRestrictions integration
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/OwnershipPluginConfiguration.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerHelper.java
src/main/java/org/jenkinsci/plugins/ownership/config/InheritanceOptions.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipHelper.java
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/OwnershipPluginConfiguration/config.jelly
src/main/resources/org/jenkinsci/plugins/ownership/config/InheritanceOptions/config.jelly
src/main/resources/org/jenkinsci/plugins/ownership/config/InheritanceOptions/help-blockInheritanceFromItemGroups.html
src/test/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipTest.java
src/test/java/org/jenkinsci/plugins/ownership/test/util/OwnershipPluginConfigurer.java
http://jenkins-ci.org/commit/ownership-plugin/3589ce8e035701e42b8aeb926d84df59f3b68967
Log:
JENKINS-28881 - Allow blocking ItemGroup inheritance
Code changed in jenkins
User: Oleg Nenashev
Path:
src/test/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipTest.java
http://jenkins-ci.org/commit/ownership-plugin/b42f2937c1f91bfd521e00650cbee38cd565c6ba
Log:
JENKINS-28881 - Direct unit test for the issue discovered with folders (JENKINS-32359)
Code changed in jenkins
User: Oleg Nenashev
Path:
src/test/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipTest.java
http://jenkins-ci.org/commit/ownership-plugin/a188d3e4e76465b01eeac99deae2188ca470853b
Log:
JENKINS-28881 - Disable the JENKINS-32359 unit test till the CloudBees Folders Plugin gets released
Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/OwnershipDescription.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/OwnershipPluginConfiguration.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/extensions/item_ownership_policy/AssignCreatorPolicy.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerHelper.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/nodes/ComputerOwnerHelper.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/nodes/NodeOwnerHelper.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/nodes/NodeOwnerPropertyHelper.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/security/rolestrategy/AbstractOwnershipRoleMacro.java
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/util/AbstractOwnershipHelper.java
src/main/java/org/jenkinsci/plugins/ownership/config/InheritanceOptions.java
src/main/java/org/jenkinsci/plugins/ownership/model/OwnershipDescriptionSource.java
src/main/java/org/jenkinsci/plugins/ownership/model/OwnershipHelperLocator.java
src/main/java/org/jenkinsci/plugins/ownership/model/OwnershipInfo.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderItemListener.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipAction.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipActionFactory.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipDescriptionSource.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipHelper.java
src/main/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipProperty.java
src/main/java/org/jenkinsci/plugins/ownership/model/jobs/JobOwnershipDescriptionSource.java
src/main/java/org/jenkinsci/plugins/ownership/model/nodes/NodeOwnershipDescriptionSource.java
src/main/java/org/jenkinsci/plugins/ownership/model/runs/RunOwnershipHelper.java
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/ItemOwnershipAction/ownershipSource.jelly
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/ItemOwnershipAction/ownershipSource.properties
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/ItemOwnershipAction/propertyConfig.jelly
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/OwnershipPlugin/propertyConfig.jelly
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/OwnershipPluginConfiguration/config.jelly
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerJobAction/manage-owners.jelly
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerJobAction/propertyConfig.jelly
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/nodes/NodeOwnershipAction/manage-owners.jelly
src/main/resources/com/synopsys/arc/jenkins/plugins/ownership/nodes/NodeOwnershipAction/propertyConfig.jelly
src/main/resources/org/jenkinsci/plugins/ownership/config/InheritanceOptions/config.jelly
src/main/resources/org/jenkinsci/plugins/ownership/config/InheritanceOptions/help-blockInheritanceFromItemGroups.html
src/main/resources/org/jenkinsci/plugins/ownership/model/OwnershipDescriptionSource/DisabledSource/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/OwnershipDescriptionSource/DisabledSource/summary.properties
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipAction/index.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipAction/manage-owners.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipAction/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipDescriptionSource/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipProperty/config.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipProperty/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/jobs/JobOwnershipDescriptionSource/summary.jelly
src/main/resources/org/jenkinsci/plugins/ownership/model/nodes/NodeOwnershipDescriptionSource/summary.jelly
src/test/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerHelperTest.java
src/test/java/com/synopsys/arc/jenkins/plugins/ownership/wrappers/OwnershipBuildWrapperTest.java
src/test/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipHelperTest.java
src/test/java/org/jenkinsci/plugins/ownership/model/folders/FolderOwnershipTest.java
src/test/java/org/jenkinsci/plugins/ownership/model/runs/RunOwnershipActionTest.java
src/test/java/org/jenkinsci/plugins/ownership/security/jobrestrictions/OwnersListJobRestrictionTest.java
src/test/java/org/jenkinsci/plugins/ownership/security/rolestrategy/OwnershipBasedSecurityTest.java
src/test/java/org/jenkinsci/plugins/ownership/security/rolestrategy/OwnershipBasedSecurityTestHelper.java
src/test/java/org/jenkinsci/plugins/ownership/test/util/OwnershipPluginConfigurer.java
http://jenkins-ci.org/commit/ownership-plugin/fe99e468f024c217fda09b75900f74ac38d1e806
Log:
Merge pull request #44 from oleg-nenashev/JENKINS-28881
JENKINS-28881 - Folders plugin support
Compare: https://github.com/jenkinsci/ownership-plugin/compare/9d49867e37cd...fe99e468f024
I have to demo it at Jenkins world
I'm working on "0.9-rc-1", to be released today.
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerColumn.java
http://jenkins-ci.org/commit/ownership-plugin/5c4c19fbf0c9b5d94f1c78a2f9925dfb48d711ce
Log:
JENKINS-28881 - Job Ownership Column should display info for folders
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/com/synopsys/arc/jenkins/plugins/ownership/jobs/JobOwnerColumn.java
http://jenkins-ci.org/commit/ownership-plugin/d042fce3c1a60a9087cc8b0053d445aa0fe03145
Log:
Merge pull request #53 from oleg-nenashev/bug/JENKINS-28881-column-folder-info
JENKINS-28881 - Job Ownership Column should display info for folders
Compare: https://github.com/jenkinsci/ownership-plugin/compare/2550b2393616...d042fce3c1a6
This doesn't seem to be working with multi-branch pipeline. I see that I can set an owner for each branch pipeline job, but not the master configuration.
bhunt Multi-branch parent configurations are not folders, hence it is unlikely related. Could you please create a new issue for it?
Likely I will need to create extension point and implement it in Multibranch Pipeline plugin.
Yes, it would be useful