-
Bug
-
Resolution: Fixed
-
Trivial
This plugin shows in the UI some icons (with different sizes) to indicate actions. These icons are broken because its URL is wrong. i.e.
/**
* {@inheritDoc}
*/
public String getIconFileName() {
return isDeployPossible(owner) ? Jenkins.RESOURCE_PATH
+ "/plugin/cloudbees-deployer-plugin/images/24x24/deploy-now.png" : null;
}
Why is wrong? Because the short-name of this plugin is deployer-framework not cloudbees-deployer-plugin.
[JENKINS-28894] Broken icons
| Assignee | Original: Stephen Connolly [ stephenconnolly ] | New: Manuel Recena Soto [ recena ] |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Code changed in jenkins
User: recena
Path:
src/main/java/com/cloudbees/plugins/deployer/DeployNowProjectAction.java
src/main/java/com/cloudbees/plugins/deployer/DeployNowRunAction.java
src/main/resources/com/cloudbees/plugins/deployer/DeployNowColumn/column.jelly
src/main/resources/com/cloudbees/plugins/deployer/DeployNowJobProperty/config.jelly
src/main/resources/com/cloudbees/plugins/deployer/DeployNowProjectAction/configure.jelly
src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/_deploy.jelly
src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/configure.jelly
src/main/resources/com/cloudbees/plugins/deployer/DeployPublisher/config.jelly
http://jenkins-ci.org/commit/deployer-framework-plugin/df99785f022471124b10ec0b45416c13844a52cc
Log:
Related to JENKINS-28894 - Broken icons
Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/com/cloudbees/plugins/deployer/DeployNowProjectAction.java
src/main/java/com/cloudbees/plugins/deployer/DeployNowRunAction.java
src/main/resources/com/cloudbees/plugins/deployer/DeployNowColumn/column.jelly
src/main/resources/com/cloudbees/plugins/deployer/DeployNowJobProperty/config.jelly
src/main/resources/com/cloudbees/plugins/deployer/DeployNowProjectAction/configure.jelly
src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/_deploy.jelly
src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/configure.jelly
src/main/resources/com/cloudbees/plugins/deployer/DeployPublisher/config.jelly
http://jenkins-ci.org/commit/deployer-framework-plugin/529182f5ddc060f0950b96911dae027175609929
Log:
Merge pull request #1 from recena/master
Related to JENKINS-28894 - Broken icons
Compare: https://github.com/jenkinsci/deployer-framework-plugin/compare/285219287815...529182f5ddc0
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: In Progress [ 3 ] | New: Resolved [ 5 ] |
| Workflow | Original: JNJira [ 163758 ] | New: JNJira + In-Review [ 197308 ] |
Sent PR.