Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28942

Allow plugins to declare that they do not use certain implied dependencies

    XMLWordPrintable

Details

    Description

      Filed against core, as there is no component for the maven-hpi-plugin.

      When a plugin has an older core dependency, Jenkins currently adds all plugins detached from core to the plugins' class path, as they may be used by the plugin.

      This can easily lead to circular dependencies, and core has a solution for that in ClassicPluginStrategy (BREAK_CYCLES).

      However, it would be great if plugins could declare that they do not have certain implied dependencies in their own metadata. This has several advantages:

      • Doesn't require core modifications to break dependency cycles
      • Plugins can explicitly not depend on detached plugins, thereby making careful Jenkins administration easier and more stricter dependency handling (refuse to load plugins that don't have all dependencies) viable.

      Attachments

        Issue Links

          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-21486 Refuse to load a plugin if dependencies are disabled or outdated

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-33095 Upgrade to folder 5.2.1 + matrix-auth 1.3 results in dead Jenkins

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-69034 Mina ssh plugin 2.8.0-30.vf9df64641cb_d has a cyclic dependency, breaks Jenkins plugin loading

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Task - A task that needs to be done. JENKINS-49555 Split most of Spring Framework out of core

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-25785 Windows slaves controlled as Windows Service do not use credentials manager

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-69049 ability for a pure API plugin to skip detached dependencies

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-30685 Hide core dependencies in plugin classpath

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-47634 plugin-compat-tester should load DETACHED_LIST & BREAK_CYCLES from core

          • Major - Major loss of function.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-49651 Extend plugin/update center metadata with known incompatibilities

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. JENKINS-50249 disable "build by token" by default using a system property in Jenkins

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-55681 Release the JAXB Plugin

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link form-element-path 8

          Web Link maven-hpi-plugin PR

          Activity

            Ascending order - Click to sort in descending order
            jglick Jesse Glick added a comment -

            Proposal: manifest header / HPI plugin configuration which lets you say that, for example, while your core baseline is 1.625.3, you wish to use the detached list as of 2.60.1 (i.e., you declare that you are not using anything split between those versions). You can easily verify compliance with such a Jenkinsfile like

            buildPlugin(jenkinsVersions: [null, '2.60.1'])

            (Needs to be tested that this will indeed fail in the expected way if the plugin was in fact relying on one of the plugins split between those versions. Certainly compile-time dependencies will fail.)

            jglick Jesse Glick added a comment - Proposal: manifest header / HPI plugin configuration which lets you say that, for example, while your core baseline is 1.625.3, you wish to use the detached list as of 2.60.1 (i.e., you declare that you are not using anything split between those versions). You can easily verify compliance with such a Jenkinsfile like buildPlugin(jenkinsVersions: [ null , '2.60.1' ]) (Needs to be tested that this will indeed fail in the expected way if the plugin was in fact relying on one of the plugins split between those versions. Certainly compile-time dependencies will fail.)
            jglick Jesse Glick added a comment -

            batmat are you actually working on this?

            My proposal of 2017-07-07 would probably be more practical for plugins using

            buildPlugin(configurations: buildPlugin.recommendedConfigurations())
            jglick Jesse Glick added a comment - batmat are you actually working on this? My proposal of 2017-07-07 would probably be more practical for plugins using buildPlugin(configurations: buildPlugin.recommendedConfigurations())
            jglick Jesse Glick added a comment -

            form-element-path #8 is an example of where this would be helpful.

            jglick Jesse Glick added a comment - form-element-path #8 is an example of where this would be helpful.
            oleg_nenashev Oleg Nenashev added a comment -

            No longer relevant for Java 11 GA

            oleg_nenashev Oleg Nenashev added a comment - No longer relevant for Java 11 GA
            jglick Jesse Glick added a comment -

            This issue has nothing to do with Java versions. Maybe you are referring to JENKINS-55681?

            jglick Jesse Glick added a comment - This issue has nothing to do with Java versions. Maybe you are referring to JENKINS-55681 ?
            oleg_nenashev Oleg Nenashev added a comment -

            jglick is was in the EPIC for Java 11 support, likely because of the JAXB API plugin. I just moved it out of the epic

            oleg_nenashev Oleg Nenashev added a comment - jglick is was in the EPIC for Java 11 support, likely because of the JAXB API plugin. I just moved it out of the epic

            People

              Unassigned Unassigned
              danielbeck Daniel Beck
              Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated: