• Type: Bug
• Resolution: Unresolved
• Priority: Major
• Component/s: patch-parameter-plugin
• Labels:

  None
• Environment:

  Linux

[JENKINS-28984] "patch.diff" is a bad name as env variable due to the dot

Axel Heider created issue - 2015-06-19 12:27

Axel Heider made changes - 2015-06-19 12:28

Description

Original: "patch.diff" is a bad name as env variable due to the dot. This causes an error in shell scripts "${patch.diff}: bad substitution"

New: "patch.diff" is a bad name as env variable due to the dot. This causes an error in shell scripts {noformat} "${patch.diff}: bad substitution" {noformat}

Collapse comment: Axel Heider added a comment - 2016-05-20 08:48

Axel Heider added a comment - 2016-05-20 08:48

work-around in a shell script is using: printenv patch.diff. That should solve the practical problem. But the name patch.diff is still not the best choice. I understand that is cannot be dropped for compatibility reasons, but another env var name like "patch_file" could be introduced in addition.

Expand comment: Axel Heider added a comment - 2016-05-20 08:48

Axel Heider added a comment - 2016-05-20 08:48 work-around in a shell script is using: printenv patch.diff . That should solve the practical problem. But the name patch.diff is still not the best choice. I understand that is cannot be dropped for compatibility reasons, but another env var name like "patch_file" could be introduced in addition.

R. Tyler Croy made changes - 2016-07-25 23:51

Workflow

Original: JNJira [ 163849 ]

New: JNJira + In-Review [ 181404 ]